You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2020/05/14 15:20:24 UTC

[GitHub] [plc4x] ottobackwards opened a new pull request #156: changes to allow running tests not coupled to maven build phase

ottobackwards opened a new pull request #156:
URL: https://github.com/apache/plc4x/pull/156


   If you are just working on c, and in CLion or something, the dependency on BUILD_PHASE for the maven caller doesn't make sense.
   
   Changes so that you can work only in C.
   
   note: you still have to run mvn once to get unity to install in target.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [plc4x] chrisdutz commented on pull request #156: changes to allow running tests not coupled to maven build phase

Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629095469


   Perhaps inverting the logic and allowing to disable tests would be an option ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [plc4x] chrisdutz commented on pull request #156: changes to allow running tests not coupled to maven build phase

Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629095235


   The thing with this is that now you can't build without tests ... I intentionally built it that way, that you can do a maven build and skip tests ...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [plc4x] ottobackwards commented on pull request #156: changes to allow running tests not coupled to maven build phase

Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629213899


   OK, I'll add that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [plc4x] ottobackwards commented on pull request #156: changes to allow running tests not coupled to maven build phase

Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629273548


   never mind


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [plc4x] ottobackwards closed pull request #156: changes to allow running tests not coupled to maven build phase

Posted by GitBox <gi...@apache.org>.
ottobackwards closed pull request #156:
URL: https://github.com/apache/plc4x/pull/156


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org