You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "huanccwang (via GitHub)" <gi...@apache.org> on 2023/12/12 15:18:15 UTC
[PR] expand groupby() parameter [spark]
huanccwang opened a new pull request, #44317:
URL: https://github.com/apache/spark/pull/44317
In some business scenarios, the columns we aggregate are not fixed and unknown. We need to perform dynamic aggregation based on business configuration information, so we need to pass in dynamic columns,I looked at the source code and found that when multiple columns are passed in, it is also converted to Seq, so I expanded the parameters of groupBy() to support passing in Seq.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] expand groupby() parameter [spark]
Posted by "huanccwang (via GitHub)" <gi...@apache.org>.
huanccwang closed pull request #44317: expand groupby() parameter
URL: https://github.com/apache/spark/pull/44317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] expand groupby() parameter [spark]
Posted by "bersprockets (via GitHub)" <gi...@apache.org>.
bersprockets commented on PR #44317:
URL: https://github.com/apache/spark/pull/44317#issuecomment-1853329716
Your IDE seems to have reformatted Dataset.scala such that several hundred lines appear changed. It would be difficult to tell what your change is. Also, your Dataset.scala no longer follows Spark coding style. See https://spark.apache.org/contributing.html "Code style guide".
See https://spark.apache.org/contributing.html, "Pull request" for guidelines on making the pull request (and also on how to get the test workflow to run on your PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] expand groupby() parameter [spark]
Posted by "huanccwang (via GitHub)" <gi...@apache.org>.
huanccwang commented on PR #44317:
URL: https://github.com/apache/spark/pull/44317#issuecomment-1853334315
> Your IDE seems to have reformatted Dataset.scala such that several hundred lines appear changed. It would be difficult to tell what your change is. Also, your Dataset.scala no longer follows Spark coding style. See https://spark.apache.org/contributing.html "Code style guide".
>
> Edit: Probably best to re-apply your change to Dataset.scala without the reformatting.
>
> See https://spark.apache.org/contributing.html, "Pull request" for guidelines on making the pull request (and also on how to get the test workflow to run on your PR).
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org