[GitHub] [iceberg] rdblue commented on a change in pull request #1677: Fix replaced partitions validation in SnapshotManager

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1677:
URL: https://github.com/apache/iceberg/pull/1677#discussion_r514438198



##########
File path: core/src/main/java/org/apache/iceberg/SnapshotManager.java
##########
@@ -255,7 +255,7 @@ private static void validateNonAncestor(TableMetadata meta, long snapshotId) {
 
   private static void validateReplacedPartitions(TableMetadata meta, Long parentId,
                                                  PartitionSet replacedPartitions) {
-    if (replacedPartitions != null) {
+    if (replacedPartitions != null && meta.currentSnapshot() != null) {

Review comment:
       Looks like we should fix that one as well. I think you should be able to FF to any snapshot if there is no current snapshot. Thanks @HeartSaVioR!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org