You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/31 17:19:08 UTC

[GitHub] [airflow] uranusjr opened a new pull request, #27416: Add stub 'yield' to BaseTrigger.run

uranusjr opened a new pull request, #27416:
URL: https://github.com/apache/airflow/pull/27416

   This allows Mypy to correctly recognize the method as an async generator and not emit errors when a subclass (correctly) implements it as so.
   
   Mypy issue: https://github.com/python/mypy/issues/5070
   
   Subclasses currently needs to “fix” the issue by ignoring the error:
   https://github.com/astronomer/astronomer-providers/blob/d5446278489cdf774840b934beff900b330850e9/astronomer/providers/google/cloud/triggers/bigquery.py#L59


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #27416: Add stub 'yield' to BaseTrigger.run

Posted by GitBox <gi...@apache.org>.

potiuk commented on PR #27416:
URL: https://github.com/apache/airflow/pull/27416#issuecomment-1297446507

   🤦 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] pierrejeambrun merged pull request #27416: Add stub 'yield' to BaseTrigger.run

Posted by GitBox <gi...@apache.org>.

pierrejeambrun merged PR #27416:
URL: https://github.com/apache/airflow/pull/27416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org