You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2018/08/28 17:42:09 UTC

[incubator-pulsar] branch master updated: Increase default maxConcurrentLookupRequests to 50k (#2380)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new fa11a3c  Increase default maxConcurrentLookupRequests to 50k (#2380)
fa11a3c is described below

commit fa11a3ca5d36ae6c1cc169e32cd0164fd8e47487
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Tue Aug 28 10:41:14 2018 -0700

    Increase default maxConcurrentLookupRequests to 50k (#2380)
    
    ### Motivation
    
    Increasing the default value of `maxConcurrentLookupRequests` from 10K to 50K to increase limit of sustainable lookups before rejecting requests.
---
 conf/broker.conf                                                      | 3 +--
 conf/proxy.conf                                                       | 2 +-
 conf/standalone.conf                                                  | 2 +-
 deployment/terraform-ansible/templates/broker.conf                    | 2 +-
 deployment/terraform-ansible/templates/proxy.conf                     | 2 +-
 .../src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java  | 2 +-
 .../main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java  | 2 +-
 site2/docs/administration-proxy.md                                    | 2 +-
 site2/docs/reference-configuration.md                                 | 4 ++--
 9 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/conf/broker.conf b/conf/broker.conf
index a8dd44b..11670d3 100644
--- a/conf/broker.conf
+++ b/conf/broker.conf
@@ -161,7 +161,7 @@ dispatchThrottlingRatePerTopicInByte=0
 dispatchThrottlingOnNonBacklogConsumerEnabled=true
 
 # Max number of concurrent lookup request broker allows to throttle heavy incoming lookup traffic
-maxConcurrentLookupRequest=10000
+maxConcurrentLookupRequest=50000
 
 # Max number of concurrent topic loading request broker allows to control number of zk-operations
 maxConcurrentTopicLoadRequest=5000
@@ -557,4 +557,3 @@ gcsManagedLedgerOffloadServiceAccountKeyFile=
 
 # Deprecated. Use configurationStoreServers
 globalZookeeperServers=
-
diff --git a/conf/proxy.conf b/conf/proxy.conf
index 7b7e690..9b307cc 100644
--- a/conf/proxy.conf
+++ b/conf/proxy.conf
@@ -81,7 +81,7 @@ forwardAuthorizationCredentials=false
 maxConcurrentInboundConnections=10000
 
 # Max concurrent outbound connections. The proxy will error out requests beyond that.
-maxConcurrentLookupRequests=10000
+maxConcurrentLookupRequests=50000
 
 ##### --- TLS --- #####
 
diff --git a/conf/standalone.conf b/conf/standalone.conf
index 13bef8a..09d369c 100644
--- a/conf/standalone.conf
+++ b/conf/standalone.conf
@@ -144,7 +144,7 @@ dispatchThrottlingRatePerTopicInByte=0
 dispatchThrottlingOnNonBacklogConsumerEnabled=true
 
 # Max number of concurrent lookup request broker allows to throttle heavy incoming lookup traffic
-maxConcurrentLookupRequest=10000
+maxConcurrentLookupRequest=50000
 
 # Max number of concurrent topic loading request broker allows to control number of zk-operations
 maxConcurrentTopicLoadRequest=5000
diff --git a/deployment/terraform-ansible/templates/broker.conf b/deployment/terraform-ansible/templates/broker.conf
index 8e8c6c2..a4fad1c 100644
--- a/deployment/terraform-ansible/templates/broker.conf
+++ b/deployment/terraform-ansible/templates/broker.conf
@@ -152,7 +152,7 @@ dispatchThrottlingRatePerTopicInByte=0
 dispatchThrottlingOnNonBacklogConsumerEnabled=true
 
 # Max number of concurrent lookup request broker allows to throttle heavy incoming lookup traffic
-maxConcurrentLookupRequest=10000
+maxConcurrentLookupRequest=50000
 
 # Max number of concurrent topic loading request broker allows to control number of zk-operations
 maxConcurrentTopicLoadRequest=5000
diff --git a/deployment/terraform-ansible/templates/proxy.conf b/deployment/terraform-ansible/templates/proxy.conf
index 21fa327..b631aca 100644
--- a/deployment/terraform-ansible/templates/proxy.conf
+++ b/deployment/terraform-ansible/templates/proxy.conf
@@ -81,7 +81,7 @@ forwardAuthorizationCredentials=false
 maxConcurrentInboundConnections=10000
 
 # Max concurrent outbound connections. The proxy will error out requests beyond that.
-maxConcurrentLookupRequests=10000
+maxConcurrentLookupRequests=50000
 
 ##### --- TLS --- #####
 
diff --git a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
index 8057540..e94f6b9 100644
--- a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
+++ b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
@@ -179,7 +179,7 @@ public class ServiceConfiguration implements PulsarConfiguration {
     private boolean dispatchThrottlingOnNonBacklogConsumerEnabled = false;
     // Max number of concurrent lookup request broker allows to throttle heavy incoming lookup traffic
     @FieldContext(dynamic = true)
-    private int maxConcurrentLookupRequest = 10000;
+    private int maxConcurrentLookupRequest = 50000;
     // Max number of concurrent topic loading request broker allows to control number of zk-operations
     @FieldContext(dynamic = true)
     private int maxConcurrentTopicLoadRequest = 5000;
diff --git a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
index 4d02786..b4e8afb 100644
--- a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
+++ b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java
@@ -82,7 +82,7 @@ public class ProxyConfiguration implements PulsarConfiguration {
     private int maxConcurrentInboundConnections = 10000;
 
     // Max concurrent outbound Connections
-    private int maxConcurrentLookupRequests = 10000;
+    private int maxConcurrentLookupRequests = 50000;
 
     // Authentication settings of the proxy itself. Used to connect to brokers
     private String brokerClientAuthenticationPlugin;
diff --git a/site2/docs/administration-proxy.md b/site2/docs/administration-proxy.md
index e4e1a86..3321e80 100644
--- a/site2/docs/administration-proxy.md
+++ b/site2/docs/administration-proxy.md
@@ -56,7 +56,7 @@ The Pulsar proxy can be configured using the [`proxy.conf`](reference-configurat
 |superUserRoles|  Role names that are treated as “super-users,” meaning that they will be able to perform all admin ||
 |forwardAuthorizationCredentials| Whether client authorization credentials are forwared to the broker for re-authorization. Authentication must be enabled via authenticationEnabled=true for this to take effect.  |false|
 |maxConcurrentInboundConnections| Max concurrent inbound connections. The proxy will reject requests beyond that. |10000|
-|maxConcurrentLookupRequests| Max concurrent outbound connections. The proxy will error out requests beyond that. |10000|
+|maxConcurrentLookupRequests| Max concurrent outbound connections. The proxy will error out requests beyond that. |50000|
 |tlsEnabledInProxy| Whether TLS is enabled for the proxy  |false|
 |tlsEnabledWithBroker|  Whether TLS is enabled when communicating with Pulsar brokers |false|
 |tlsCertificateFilePath|  Path for the TLS certificate file ||
diff --git a/site2/docs/reference-configuration.md b/site2/docs/reference-configuration.md
index c5a4738..b74a928 100644
--- a/site2/docs/reference-configuration.md
+++ b/site2/docs/reference-configuration.md
@@ -142,7 +142,7 @@ Pulsar brokers are responsible for handling incoming messages from producers, di
 |tlsAllowInsecureConnection|  Accept untrusted TLS certificate from client  |false|
 |maxUnackedMessagesPerConsumer| Max number of unacknowledged messages allowed to receive messages by a consumer on a shared subscription. Broker will stop sending messages to consumer once, this limit reaches until consumer starts acknowledging messages back. Using a value of 0, is disabling unackeMessage limit check and consumer can receive messages without any restriction  |50000|
 |maxUnackedMessagesPerSubscription| Max number of unacknowledged messages allowed per shared subscription. Broker will stop dispatching messages to all consumers of the subscription once this limit reaches until consumer starts acknowledging messages back and unack count reaches to limit/2. Using a value of 0, is disabling unackedMessage-limit check and dispatcher can dispatch messages without any restriction  |200000|
-|maxConcurrentLookupRequest|  Max number of concurrent lookup request broker allows to throttle heavy incoming lookup traffic |10000|
+|maxConcurrentLookupRequest|  Max number of concurrent lookup request broker allows to throttle heavy incoming lookup traffic |50000|
 |maxConcurrentTopicLoadRequest| Max number of concurrent topic loading request broker allows to control number of zk-operations |5000|
 |authenticationEnabled| Enable authentication |false|
 |authenticationProviders| Autentication provider name list, which is comma separated list of class names  ||
@@ -426,7 +426,7 @@ The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) can be config
 |superUserRoles|  Role names that are treated as “super-users,” meaning that they will be able to perform all admin ||
 |forwardAuthorizationCredentials| Whether client authorization credentials are forwared to the broker for re-authorization. Authentication must be enabled via authenticationEnabled=true for this to take effect.  |false|
 |maxConcurrentInboundConnections| Max concurrent inbound connections. The proxy will reject requests beyond that. |10000|
-|maxConcurrentLookupRequests| Max concurrent outbound connections. The proxy will error out requests beyond that. |10000|
+|maxConcurrentLookupRequests| Max concurrent outbound connections. The proxy will error out requests beyond that. |50000|
 |tlsEnabledInProxy| Whether TLS is enabled for the proxy  |false|
 |tlsEnabledWithBroker|  Whether TLS is enabled when communicating with Pulsar brokers |false|
 |tlsCertificateFilePath|  Path for the TLS certificate file ||