You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by hy...@apache.org on 2019/11/26 13:18:00 UTC

[dubbo] branch master updated: [Dubbo-5200] fix javadoc for Serialization.getContentTypeId (#5201)

This is an automated email from the ASF dual-hosted git repository.

hyunkun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new 170a8c9  [Dubbo-5200] fix javadoc for Serialization.getContentTypeId (#5201)
170a8c9 is described below

commit 170a8c9c2a4cc0147f9a77f763c91311deaa7446
Author: RojerAlone <zh...@xiaomi.com>
AuthorDate: Tue Nov 26 21:17:48 2019 +0800

    [Dubbo-5200] fix javadoc for Serialization.getContentTypeId (#5201)
---
 .../main/java/org/apache/dubbo/common/serialize/Serialization.java  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dubbo-serialization/dubbo-serialization-api/src/main/java/org/apache/dubbo/common/serialize/Serialization.java b/dubbo-serialization/dubbo-serialization-api/src/main/java/org/apache/dubbo/common/serialize/Serialization.java
index 0c09df9..430bfc5 100644
--- a/dubbo-serialization/dubbo-serialization-api/src/main/java/org/apache/dubbo/common/serialize/Serialization.java
+++ b/dubbo-serialization/dubbo-serialization-api/src/main/java/org/apache/dubbo/common/serialize/Serialization.java
@@ -36,7 +36,9 @@ import java.io.OutputStream;
 public interface Serialization {
 
     /**
-     * Get content type unique id, recommended that custom implementations use values greater than 20.
+     * Get content type unique id, recommended that custom implementations use values different with
+     * any value of {@link Constants} and don't greater than ExchangeCodec.SERIALIZATION_MASK (31) 
+     * because dubbo protocol use 5 bits to record serialization ID in header.
      *
      * @return content type id
      */
@@ -71,4 +73,4 @@ public interface Serialization {
     @Adaptive
     ObjectInput deserialize(URL url, InputStream input) throws IOException;
 
-}
\ No newline at end of file
+}