You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2023/01/08 01:29:09 UTC
[GitHub] [ozone] jojochuang opened a new pull request, #4156: HDDS-7722. FSO buckets fail to invalidate open file table cache when committing a key
jojochuang opened a new pull request, #4156:
URL: https://github.com/apache/ozone/pull/4156
## What changes were proposed in this pull request?
Fix incorrect use of openKeyTable/openFileTable, where key/file name, instead of open key/file name is used.
## What is the link to the Apache JIRA
[HDDS-7722](https://issues.apache.org/jira/browse/HDDS-7722)
## How was this patch tested?
Existing unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on a diff in pull request #4156: HDDS-7722. FSO buckets fail to invalidate open file table cache when committing a key
Posted by GitBox <gi...@apache.org>.
errose28 commented on code in PR #4156:
URL: https://github.com/apache/ozone/pull/4156#discussion_r1068808739
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java:
##########
@@ -193,7 +193,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
// Add to cache of open key table and key table.
- OMFileRequest.addOpenFileTableCacheEntry(omMetadataManager, dbFileKey,
+ OMFileRequest.addOpenFileTableCacheEntry(omMetadataManager, dbOpenFileKey,
Review Comment:
@duongkame did [this](https://github.com/apache/ozone/pull/4156#pullrequestreview-1242797126) answer your question or do you still have some concerns about this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen merged pull request #4156: HDDS-7722. FSO buckets fail to invalidate open file table cache when committing a key
Posted by GitBox <gi...@apache.org>.
kaijchen merged PR #4156:
URL: https://github.com/apache/ozone/pull/4156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #4156: HDDS-7722. FSO buckets fail to invalidate open file table cache when committing a key
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #4156:
URL: https://github.com/apache/ozone/pull/4156#issuecomment-1375964403
@duongkame can you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #4156: HDDS-7722. FSO buckets fail to invalidate open file table cache when committing a key
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #4156:
URL: https://github.com/apache/ozone/pull/4156#issuecomment-1381274182
Thanks @duongkame @errose28 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] duongkame commented on a diff in pull request #4156: HDDS-7722. FSO buckets fail to invalidate open file table cache when committing a key
Posted by GitBox <gi...@apache.org>.
duongkame commented on code in PR #4156:
URL: https://github.com/apache/ozone/pull/4156#discussion_r1066133897
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestWithFSO.java:
##########
@@ -193,7 +193,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
}
// Add to cache of open key table and key table.
- OMFileRequest.addOpenFileTableCacheEntry(omMetadataManager, dbFileKey,
+ OMFileRequest.addOpenFileTableCacheEntry(omMetadataManager, dbOpenFileKey,
Review Comment:
Nice catch.
So, what happens is when an FSO key is committed, the open-key entry is not cleaned up. Logically, that should prevent the key from being reopened, e.g. for a overwrite.
Fortunately (or maybe not), when OM opens a key for writing, it just doesn't care if the file has been opened already (even by the same client). I feel like this behavior results in some funny scenarios when multiple clients open and commit the same file. Guess it's something we can think about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #4156: HDDS-7722. FSO buckets fail to invalidate open file table cache when committing a key
Posted by GitBox <gi...@apache.org>.
jojochuang commented on PR #4156:
URL: https://github.com/apache/ozone/pull/4156#issuecomment-1377818171
Thanks Ethan. Good to know that you find it benign.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org