You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/11/29 07:14:44 UTC
[GitHub] zeppelin pull request #1698: Downloading dependency/changing version for an ...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/1698
Downloading dependency/changing version for an interpreter results in error sometimes
### What is this PR for?
At times on downloading dependency/changing version for an interpreter results in error
```
INFO [2016-11-29 11:16:52,998] ({qtp60559178-18} InterpreterRestApi.java[updateSetting]:137) - Update interpreterSetting 2C2ENJBEV
ERROR [2016-11-29 11:16:53,047] ({Thread-61} InterpreterFactory.java[run]:494) - Error while downloading repos for interpreter group : jdbc, go to interpreter setting page click on edit and save it again to make this interpreter work properly. : File does not exist: /Users/xxx/local-repo/2C2ENJBEV/twill-zookeeper-0.6.0-incubating.jar
java.io.FileNotFoundException: File does not exist: /Users/xxx/local-repo/2C2ENJBEV/twill-zookeeper-0.6.0-incubating.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:470)
ERROR [2016-11-29 11:16:53,047] ({Thread-64} InterpreterFactory.java[run]:494) - Error while downloading repos for interpreter group : jdbc, go to interpreter setting page click on edit and save it again to make this interpreter work properly. : File does not exist: /Users/xxx/local-repo/2C2ENJBEV/zookeeper-3.4.6.jar
java.io.FileNotFoundException: File does not exist: /Users/xxx/local-repo/2C2ENJBEV/zookeeper-3.4.6.jar
at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1653)
at org.apache.zeppelin.interpreter.InterpreterFactory$3.run(InterpreterFactory.java:470)
```
but on re-saving it works fine.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
* [ZEPPELIN-1725](https://issues.apache.org/jira/browse/ZEPPELIN-1725)
### How should this be tested?
Configure following as dependencies in JDBC
```
org.apache.hive:hive-jdbc:2.0.1
org.apache.hadoop:hadoop-common:2.7.1
org.apache.hive.shims:hive-shims-0.23:2.1.0
org.apache.phoenix:phoenix-core:4.7.0-HBase-1.1
```
now try changing one of it, say "org.apache.hadoop:hadoop-common:2.7.1" to "org.apache.hadoop:hadoop-common:2.6.0"
Save should happen all the time.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1725
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1698.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1698
----
commit b535bb962f0847885ba2792ba0ffcee01f30942f
Author: Prabhjyot Singh <pr...@gmail.org>
Date: 2016-11-29T07:03:32Z
do a check for FileNotFoundException, which would mean it was already deleted/not present.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1698: Downloading dependency/changing version for an ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1698
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1698: Downloading dependency/changing version for an interpr...
Posted by rconline <gi...@git.apache.org>.
Github user rconline commented on the issue:
https://github.com/apache/zeppelin/pull/1698
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1698: Downloading dependency/changing version for an interpr...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1698
CI failure seems like a candidate for JIRA issue with `flaky-test` label
```
Failed tests:
ZeppelinSparkClusterTest.zRunTest:346 expected:<FINISHED> but was:<ERROR>
```
Seems un-related to the changes. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1698: Downloading dependency/changing version for an interpr...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1698
\U0001f44d LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1698: Downloading dependency/changing version for an interpr...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1698
Will merge this, if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---