[GitHub] [cloudstack] nvazquez commented on a change in pull request #5006: Disk controller vmware deploy as is

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r630118487



##########
File path: ui/src/components/view/DetailSettings.vue
##########
@@ -96,6 +97,7 @@
             :title="`${$t('label.delete.setting')}?`"
             @confirm="deleteDetail(index)"
             :okText="$t('label.yes')"
+            :disabled="deployasistemplate === true && (item.name === 'rootDiskController' || item.name === 'dataDiskController')"

Review comment:
       Same as above

##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2067,9 +2067,7 @@ protected StartAnswer execute(StartCommand cmd) {
                 }
 
                 VirtualMachineDiskInfo matchingExistingDisk = getMatchingExistingDisk(diskInfoBuilder, vol, hyperHost, context);
-                controllerKey = getDiskController(matchingExistingDisk, vol, vmSpec, ideControllerKey, scsiControllerKey);

Review comment:
       Why is this being removed? 

##########
File path: ui/src/components/view/DetailSettings.vue
##########
@@ -85,6 +85,7 @@
           <tooltip-button
             :tooltip="$t('label.edit')"
             icon="edit"
+            :disabled="deployasistemplate === true && (item.name === 'rootDiskController' || item.name === 'dataDiskController')"

Review comment:
       I think `deployasistemplate === true` should be enough in this condition

##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -3273,47 +3271,9 @@ private VirtualMachineDiskInfo getMatchingExistingDisk(VirtualMachineDiskInfoBui
         return null;
     }
 
-    private int getDiskController(VirtualMachineDiskInfo matchingExistingDisk, DiskTO vol, VirtualMachineTO vmSpec, int ideControllerKey, int scsiControllerKey) {

Review comment:
       Same ^^




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org