You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/12/15 08:23:11 UTC
[GitHub] zeppelin pull request #1768: [DOCS] Separate "interpreter exec hooks (experi...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1768
[DOCS] Separate "interpreter exec hooks (experimental)" from interpreter overview page
### What is this PR for?
After #1470 merged, "(Experimental) Interpreter Execution Hooks" is added under https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/manual/interpreters.html page. But i think we need to keep this page as simple as possible since it's explaining the basic concept of Zeppelin interpreters. So I separated "(Experimental) Interpreter Execution Hooks" section from `interpreters.md` and create new page `interpreterexechooks.md`.
And also fixed some wired markdown rendering issues.
### What type of PR is it?
Documentation
### What is the Jira issue?
N/A
### How should this be tested?
Please see below screenshots :)
### Screenshots (if appropriate)
- Before (under [manual/interpreter.md](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/manual/interpreters.html#experimental-interpreter-execution-hooks)
<img width="437" alt="screen shot 2016-12-15 at 5 05 49 pm]" src="https://cloud.githubusercontent.com/assets/10060731/21216362/a3bb89f0-c2e9-11e6-9678-8e6d8749229b.png">
- After
<img width="300" alt="dropdown" src="https://cloud.githubusercontent.com/assets/10060731/21216570/dcca63f0-c2ea-11e6-90a9-969d363b423a.png">
<img width="437" alt="screen shot 2016-12-15 at 5 05 58 pm" src="https://cloud.githubusercontent.com/assets/10060731/21216363/a6c2d82e-c2e9-11e6-920c-a603e25e1699.png">
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin separate-eventhook-section
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1768.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1768
----
commit ce194918479817548d62cc03d5167fe4a57df506
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-12-15T08:09:40Z
Separate 'interpreter exec hooks' from intp overview
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1768: [DOCS] Separate "interpreter exec hooks (experi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1768
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1768: [DOCS] Separate "interpreter exec hooks (experimental)...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1768
@AhyoungRyu Tested and LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1768: [DOCS] Separate "interpreter exec hooks (experimental)...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1768
@agoodm No worries. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1768: [DOCS] Separate "interpreter exec hooks (experimental)...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1768
@agoodm @soralee Thanks for your review!
CI failed only in Selenium test like below and it's not related with this docs change.
```
Results :
Tests in error:
ZeppelinIT.testAngularDisplay:157->AbstractZeppelinIT.waitForText:84 ยป StaleElementReference
Tests run: 18, Failures: 0, Errors: 1, Skipped: 0
```
Merge into master if there are no further discussions :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1768: [DOCS] Separate "interpreter exec hooks (experimental)...
Posted by agoodm <gi...@git.apache.org>.
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1768
Thanks for the update! I probably should have done this when I made the original PR.
Anyways, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1768: [DOCS] Separate "interpreter exec hooks (experimental)...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1768
@agoodm Since you added this section, it'll be appreciated if you can review this one :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---