You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/08/17 05:04:36 UTC
[GitHub] [incubator-kvrocks] Qiaolin-Yu opened a new pull request, #780: Replace backupable_db with backup_engine
Qiaolin-Yu opened a new pull request, #780:
URL: https://github.com/apache/incubator-kvrocks/pull/780
**Motivation**
In [this commit of RocksDB](https://github.com/facebook/rocksdb/commit/78aee6fedc62ca6048e500969912d1e1f0553490), backupable_db.h will be marked as obsolete, and removed from the repository. In order to continue to be compatible with RocksDB in the future, kvrocks should also remove the outdated RocksDB API related to backupable_db.h and replace it with an updated one.
**Impact**
RocksDB has supported the updated API in very early versions, so it will not cause existing compatibility problems.
Co-authored-by: Change72 <gu...@tsinghua.org.cn>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #780: Replace backupable_db with backup_engine
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #780:
URL: https://github.com/apache/incubator-kvrocks/pull/780#issuecomment-1217482772
Thanks all, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] caipengbo commented on pull request #780: Replace backupable_db with backup_engine
Posted by GitBox <gi...@apache.org>.
caipengbo commented on PR #780:
URL: https://github.com/apache/incubator-kvrocks/pull/780#issuecomment-1217466287
Good catch, thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #780: Replace backupable_db with backup_engine
Posted by GitBox <gi...@apache.org>.
git-hulk merged PR #780:
URL: https://github.com/apache/incubator-kvrocks/pull/780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org