You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/27 00:18:12 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7135: Enable
color consistency in a dashboard
codecov-io commented on issue #7135: Enable color consistency in a dashboard
URL: https://github.com/apache/incubator-superset/pull/7135#issuecomment-476907369
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7135?src=pr&el=h1) Report
> Merging [#7135](https://codecov.io/gh/apache/incubator-superset/pull/7135?src=pr&el=desc) into [lyftga](https://codecov.io/gh/apache/incubator-superset/commit/87fb2df9f444cc405bce4c094c1e04562430a0a9?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `27.27%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7135?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## lyftga #7135 +/- ##
==========================================
- Coverage 64.34% 64.21% -0.14%
==========================================
Files 423 425 +2
Lines 20597 20671 +74
Branches 2255 2269 +14
==========================================
+ Hits 13253 13273 +20
- Misses 7211 7265 +54
Partials 133 133
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7135?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...sets/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmRCdWlsZGVyLmpzeA==) | `0% <ø> (ø)` | :arrow_up: |
| [...ssets/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmRIZWFkZXIuanN4) | `100% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/dashboard/util/propShapes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9wcm9wU2hhcGVzLmpzeA==) | `100% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/chart/ChartRenderer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydFJlbmRlcmVyLmpzeA==) | `7.04% <0%> (-0.11%)` | :arrow_down: |
| [...t/assets/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: |
| [...rset/assets/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `43.9% <0%> (-2.26%)` | :arrow_down: |
| [.../src/dashboard/components/BuilderComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9CdWlsZGVyQ29tcG9uZW50UGFuZS5qc3g=) | `28.57% <0%> (+2.25%)` | :arrow_up: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXJBY3Rpb25zRHJvcGRvd24uanN4) | `70% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/dashboard/util/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9jb25zdGFudHMuanM=) | `100% <100%> (ø)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <100%> (+0.1%)` | :arrow_up: |
| ... and [10 more](https://codecov.io/gh/apache/incubator-superset/pull/7135/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7135?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7135?src=pr&el=footer). Last update [87fb2df...4d879e1](https://codecov.io/gh/apache/incubator-superset/pull/7135?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org