You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2025/03/17 15:03:42 UTC
[PR] feat: Native support utf8view for binary operator [datafusion]
zhuqi-lucas opened a new pull request, #15275:
URL: https://github.com/apache/datafusion/pull/15275
## Which issue does this PR close?
- Closes sub_task of
[#15096](https://github.com/apache/datafusion/issues/15096)
## Rationale for this change
feat: Native support utf8view for binary operator
Because upstream arrow-rs already support utf8view for the remaining function for ut8view such as regex_match.
## What changes are included in this PR?
feat: Native support utf8view for binary operator
Because upstream arrow-rs already support utf8view for the remaining function for ut8view such as regex_match.
## Are these changes tested?
Yes
## Are there any user-facing changes?
feat: Native support utf8view for binary operator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Native support utf8view for regex string operators [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #15275:
URL: https://github.com/apache/datafusion/pull/15275#discussion_r1999247151
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1177,26 +1177,6 @@ pub fn string_coercion(lhs_type: &DataType, rhs_type: &DataType) -> Option<DataT
}
}
-/// This will be deprecated when binary operators native support
Review Comment:
outstanding ❤️
##########
datafusion/sqllogictest/test_files/string/string_view.slt:
##########
@@ -1100,7 +1100,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
-01)Projection: CAST(test.column1_utf8view AS Utf8) LIKE Utf8("%an%") AS c1
+01)Projection: test.column1_utf8view ~ Utf8View("an") AS c1
Review Comment:
looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Native support utf8view for regex string operators [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #15275:
URL: https://github.com/apache/datafusion/pull/15275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: Native support utf8view for regex string operators [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #15275:
URL: https://github.com/apache/datafusion/pull/15275#issuecomment-2734067285
Thanks again @zhuqi-lucas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org