You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/21 08:54:31 UTC
[GitHub] [dolphinscheduler-website] czeming opened a new pull request, #779: [Feature-9449] [Doc] Append how to setting imports for code-style
czeming opened a new pull request, #779:
URL: https://github.com/apache/dolphinscheduler-website/pull/779
Append how to setting imports for code-style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] czeming closed pull request #779: [Feature-9449] [Doc] Append how to setting imports for code-style
Posted by GitBox <gi...@apache.org>.
czeming closed pull request #779: [Feature-9449] [Doc] Append how to setting imports for code-style
URL: https://github.com/apache/dolphinscheduler-website/pull/779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #779: [Feature-9449] [Doc] Append how to setting imports for code-style
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #779:
URL: https://github.com/apache/dolphinscheduler-website/pull/779#issuecomment-1106086466
Do not get me wrong, I mean the better way to fix this issue is move your setting into https://github.com/apache/dolphinscheduler-website/pull/779/files#diff-a3045e718256d7ab0a572bebc673b842fdc1ba8ddd8688943177a5674f486559 . and then users could be done all style check config by importing the checke-sytle.xml.
In your case, users have to finish it by two steps:
1. import check-sytle
2. change setting in IDEA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] czeming commented on pull request #779: [Feature-9449] [Doc] Append how to setting imports for code-style
Posted by GitBox <gi...@apache.org>.
czeming commented on PR #779:
URL: https://github.com/apache/dolphinscheduler-website/pull/779#issuecomment-1106141622
> Do not get me wrong, I mean the better way to fix this issue is move your setting into https://github.com/apache/dolphinscheduler-website/pull/779/files#diff-a3045e718256d7ab0a572bebc673b842fdc1ba8ddd8688943177a5674f486559 . and then users could be done all style check config by importing the checke-sytle.xml.
>
> In your case, users have to finish it by two steps:
>
> 1. import check-sytle
> 2. change setting in IDEA.
OK, You mean export the configuration file. I didn't understand before.
---
There is a keyword `JavaCodeStyleSettings` in the configuration file, I didn't find anything in `dolphinscheduler` by searching `JavaCodeStyleSettings`.
I'll add the file to the `dolphinscheduler` and modify this pr to explain how to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] czeming commented on pull request #779: [Feature-9449] [Doc] Append how to setting imports for code-style
Posted by GitBox <gi...@apache.org>.
czeming commented on PR #779:
URL: https://github.com/apache/dolphinscheduler-website/pull/779#issuecomment-1106238824
> Do not get me wrong, I mean the better way to fix this issue is move your setting into https://github.com/apache/dolphinscheduler-website/pull/779/files#diff-a3045e718256d7ab0a572bebc673b842fdc1ba8ddd8688943177a5674f486559 . and then users could be done all style check config by importing the checke-sytle.xml.
>
> In your case, users have to finish it by two steps:
>
> 1. import check-sytle
> 2. change setting in IDEA.
Oh! I see, `checksytle.xml` can also be used for `Preferences -> Editor -> Code Style -> Java`.
I thought he was just can used for `Preferences -> Tool -> Checkstyle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] czeming commented on pull request #779: [Feature-9449] [Doc] Append how to setting imports for code-style
Posted by GitBox <gi...@apache.org>.
czeming commented on PR #779:
URL: https://github.com/apache/dolphinscheduler-website/pull/779#issuecomment-1105978119
> Hi @czeming I think we should add this rule into https://github.com/apache/dolphinscheduler/blob/60457284286b06007c06a1efef7f9706ca848320/style/checkstyle.xml instead of in doc. BTW, does it not exists in our checkstyle now?
Yes, it already exists in the current version.
But considering that some developers do not have settings or do not know what they can set, adding documents can provide guidance to set `preferences - > editor - > code style - > java - > imports`.
The default import will be different for different developers. If it is not set, there will be more conflicts or import with *
for example:
Sometimes it can be conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #779: [Feature-9449] [Doc] Append how to setting imports for code-style
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #779:
URL: https://github.com/apache/dolphinscheduler-website/pull/779#issuecomment-1105941534
Hi @czeming I think we should add this rule into https://github.com/apache/dolphinscheduler/blob/60457284286b06007c06a1efef7f9706ca848320/style/checkstyle.xml instead of in doc. BTW, does it not exists in our checkstyle now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #779: [Feature-9449] [Doc] Append how to setting imports for code-style
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #779:
URL: https://github.com/apache/dolphinscheduler-website/pull/779#issuecomment-1107292193
> > Do not get me wrong, I mean the better way to fix this issue is move your setting into https://github.com/apache/dolphinscheduler-website/pull/779/files#diff-a3045e718256d7ab0a572bebc673b842fdc1ba8ddd8688943177a5674f486559 . and then users could be done all style check config by importing the checke-sytle.xml.
> > In your case, users have to finish it by two steps:
> >
> > 1. import check-sytle
> > 2. change setting in IDEA.
>
> Oh! I see, `checksytle.xml` can also be used for `Preferences -> Editor -> Code Style -> Java`.
>
> I thought it was just can used for `Preferences -> Tool -> Checkstyle`.
Yeah, that is exactly what i mean. Do you want to add it in our `checksytle.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org