You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "apocelipes (via GitHub)" <gi...@apache.org> on 2025/11/20 09:55:45 UTC

[PR] Fix incorrect openssl dynamic library link order (brpc)

apocelipes opened a new pull request, #3159:
URL: https://github.com/apache/brpc/pull/3159

   ### What problem does this PR solve?
   
   Issue Number: null
   
   Problem Summary: The incorrect linking order of libssl and libcrypto caused our CI to encounter errors during compilation and linking:
   
   <img width="1162" height="469" alt="image" src="https://github.com/user-attachments/assets/d34bb30c-242a-40eb-9ecc-8d56e2d31add" />
   
   Full CI logs: [link](https://github.com/xmake-io/xmake-repo/actions/runs/18766632034/job/53542833211?pr=8475)
   
   Adjusting their link orders can resolve the error.
   
   ### What is changed and the side effects?
   
   Changed:
   
   Side effects:
   - Performance effects:
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [PR] Fix incorrect openssl dynamic library link order (brpc)

Posted by "wasphin (via GitHub)" <gi...@apache.org>.
wasphin merged PR #3159:
URL: https://github.com/apache/brpc/pull/3159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [PR] Fix incorrect openssl dynamic library link order (brpc)

Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #3159:
URL: https://github.com/apache/brpc/pull/3159#issuecomment-3557808185

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org