You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/11 01:39:33 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #11229: WIP: Export databases as a ZIP bundle
betodealmeida opened a new pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.55%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.04% -5.56%
==========================================
Files 828 395 -433
Lines 39167 24804 -14363
Branches 3589 0 -3589
==========================================
- Hits 25694 14893 -10801
+ Misses 13361 9911 -3450
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.04% <95.69%> (-0.99%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.89% <94.73%> (-2.47%)` | :arrow_down: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.10% <0.00%> (-25.33%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| ... and [472 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...1bcf9f0](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.37%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.22% -5.38%
==========================================
Files 828 395 -433
Lines 39167 24836 -14331
Branches 3589 0 -3589
==========================================
- Hits 25694 14957 -10737
+ Misses 13361 9879 -3482
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.22% <95.69%> (-0.81%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [467 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...e68b228](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `3.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 62.40% -3.20%
==========================================
Files 828 438 -390
Lines 39167 14681 -24486
Branches 3589 3592 +3
==========================================
- Hits 25694 9162 -16532
+ Misses 13361 5338 -8023
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset/migrations/versions/65903709c321\_allow\_dml.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy82NTkwMzcwOWMzMjFfYWxsb3dfZG1sLnB5) | | |
| [...s/versions/eca4694defa7\_sqllab\_setting\_defaults.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lY2E0Njk0ZGVmYTdfc3FsbGFiX3NldHRpbmdfZGVmYXVsdHMucHk=) | | |
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvdXBkYXRlQ29tcG9uZW50UGFyZW50c0xpc3QuanM=) | | |
| [...end/src/components/Select/WindowedSelect/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9TZWxlY3QvV2luZG93ZWRTZWxlY3QvaW5kZXgudHN4) | | |
| [...tor-superset/superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnQuanN4) | | |
| [...rset/superset-frontend/src/logger/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvbG9nZ2VyL2FjdGlvbnMvaW5kZXguanM=) | | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL0V4cGxvcmVWaWV3Q29udGFpbmVyLmpzeA==) | | |
| [superset/models/datasource\_access\_request.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2RhdGFzb3VyY2VfYWNjZXNzX3JlcXVlc3QucHk=) | | |
| [superset/views/base\_schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9zY2hlbWFzLnB5) | | |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MYWJlbC9MYWJlbC5zdG9yaWVzLnRzeA==) | | |
| ... and [1251 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...4783343](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.54%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.05% -4.55%
==========================================
Files 828 833 +5
Lines 39167 39476 +309
Branches 3589 3592 +3
==========================================
- Hits 25694 24103 -1591
- Misses 13361 15192 +1831
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `60.25% <95.69%> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [903 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...c906ac2](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `9.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 55.87% -9.73%
==========================================
Files 828 404 -424
Lines 39167 13405 -25762
Branches 3589 3390 -199
==========================================
- Hits 25694 7490 -18204
+ Misses 13361 5733 -7628
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.87% <ø> (+0.42%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...d/src/dashboard/util/updateComponentParentsList.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvdXBkYXRlQ29tcG9uZW50UGFyZW50c0xpc3QuanM=) | | |
| [...uperset/superset-frontend/src/components/Timer.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9UaW1lci50c3g=) | | |
| [.../migrations/versions/c617da68de7d\_form\_nullable.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jNjE3ZGE2OGRlN2RfZm9ybV9udWxsYWJsZS5weQ==) | | |
| [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | | |
| [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL3dpdGhWZXJpZmljYXRpb24uanN4) | | |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9FcnJvck1lc3NhZ2UvSXNzdWVDb2RlLnRzeA==) | | |
| [...et-frontend/src/components/ListView/ActionsBar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlldy9BY3Rpb25zQmFyLnRzeA==) | | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | | |
| [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | | |
| ... and [1217 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...6ebf352](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.45%`.
> The diff coverage is `96.93%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.14% -5.46%
==========================================
Files 828 394 -434
Lines 39167 24920 -14247
Branches 3589 0 -3589
==========================================
- Hits 25694 14989 -10705
+ Misses 13361 9931 -3430
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.14% <96.93%> (-0.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.23% <95.23%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| ... and [478 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.16%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.43% -4.17%
==========================================
Files 828 833 +5
Lines 39167 39535 +368
Branches 3589 3598 +9
==========================================
- Hits 25694 24289 -1405
- Misses 13361 15064 +1703
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.36%)` | :arrow_up: |
| #python | `60.70% <95.69%> (-0.33%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| ... and [896 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...a15f1b1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.13%`.
> The diff coverage is `96.84%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.47% -4.14%
==========================================
Files 828 835 +7
Lines 39167 39648 +481
Branches 3589 3610 +21
==========================================
- Hits 25694 24372 -1322
- Misses 13361 15095 +1734
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.73% <96.84%> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.65% <95.65%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.29% <100.00%> (+0.92%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
| ... and [907 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...d09e861](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r505316002
##########
File path: requirements/base.txt
##########
@@ -6,7 +6,7 @@
# pip-compile-multi
#
-e file:. # via -r requirements/base.in
-aiohttp==3.6.2 # via slackclient
+aiohttp==3.6.3 # via slackclient
Review comment:
Do we need to bump dependencies on this PR? If not open a separate PR for it, since it makes release cherry picking harder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.27%`.
> The diff coverage is `96.93%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.33% -4.28%
==========================================
Files 828 835 +7
Lines 39167 39652 +485
Branches 3589 3610 +21
==========================================
- Hits 25694 24319 -1375
- Misses 13361 15152 +1791
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.51% <96.93%> (-0.52%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.23% <95.23%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| ... and [908 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.78%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.81% -4.79%
==========================================
Files 828 833 +5
Lines 39167 39476 +309
Branches 3589 3592 +3
==========================================
- Hits 25694 24008 -1686
- Misses 13361 15287 +1926
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `59.87% <95.69%> (-1.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.38% <ø> (-0.53%)` | :arrow_down: |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `82.52% <94.73%> (-6.84%)` | :arrow_down: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| ... and [916 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...6b9b6a2](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.54%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.05% -4.55%
==========================================
Files 828 833 +5
Lines 39167 39476 +309
Branches 3589 3592 +3
==========================================
- Hits 25694 24103 -1591
- Misses 13361 15192 +1831
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `60.25% <95.69%> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [903 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...0180322](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `10.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
===========================================
- Coverage 65.60% 55.21% -10.39%
===========================================
Files 828 404 -424
Lines 39167 13405 -25762
Branches 3589 3390 -199
===========================================
- Hits 25694 7402 -18292
+ Misses 13361 5813 -7548
- Partials 112 190 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.21% <ø> (-0.24%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dao/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFvL2V4Y2VwdGlvbnMucHk=) | | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9JbmRldGVybWluYXRlQ2hlY2tib3gudHN4) | | |
| [superset/views/log/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | | |
| [...erset/superset-frontend/src/components/FormRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Gb3JtUm93LmpzeA==) | | |
| [...uperset/utils/dashboard\_filter\_scopes\_converter.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ZpbHRlcl9zY29wZXNfY29udmVydGVyLnB5) | | |
| [...c/visualizations/TimeTable/TimeTableChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlzdWFsaXphdGlvbnMvVGltZVRhYmxlL1RpbWVUYWJsZUNoYXJ0UGx1Z2luLmpz) | | |
| [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU2NoZWR1bGVRdWVyeUJ1dHRvbi5qc3g=) | | |
| [...40e8ea\_change\_table\_schema\_description\_to\_long\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84OTExNWE0MGU4ZWFfY2hhbmdlX3RhYmxlX3NjaGVtYV9kZXNjcmlwdGlvbl90b19sb25nXy5weQ==) | | |
| [...end/src/visualizations/TimeTable/SparklineCell.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlzdWFsaXphdGlvbnMvVGltZVRhYmxlL1NwYXJrbGluZUNlbGwuanN4) | | |
| ... and [1217 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...6ebf352](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.01%`.
> The diff coverage is `96.84%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.58% -4.02%
==========================================
Files 828 835 +7
Lines 39167 39648 +481
Branches 3589 3610 +21
==========================================
- Hits 25694 24417 -1277
- Misses 13361 15050 +1689
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.91% <96.84%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.65% <95.65%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.29% <100.00%> (+0.92%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| ... and [905 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...d09e861](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `3.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 62.40% -3.20%
==========================================
Files 828 438 -390
Lines 39167 14681 -24486
Branches 3589 3592 +3
==========================================
- Hits 25694 9162 -16532
+ Misses 13361 5338 -8023
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | | |
| [superset/migrations/versions/ae19b4ee3692\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZTE5YjRlZTM2OTJfLnB5) | | |
| [superset/examples/country\_map.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyeV9tYXAucHk=) | | |
| [.../e557699a813e\_add\_tables\_relation\_to\_row\_level\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lNTU3Njk5YTgxM2VfYWRkX3RhYmxlc19yZWxhdGlvbl90b19yb3dfbGV2ZWxfLnB5) | | |
| [...superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Qb3BvdmVyL2luZGV4LnRzeA==) | | |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU3FsRWRpdG9yLmpzeA==) | | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | | |
| [...superset/superset-frontend/src/SqlLab/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbnN0YW50cy50cw==) | | |
| [...ntend/src/dashboard/components/PublishedStatus.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvUHVibGlzaGVkU3RhdHVzLmpzeA==) | | |
| [...rontend/src/components/ListView/CardCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlldy9DYXJkQ29sbGVjdGlvbi50c3g=) | | |
| ... and [1251 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...6b9b6a2](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `10.40%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
===========================================
- Coverage 65.60% 55.19% -10.41%
===========================================
Files 828 404 -424
Lines 39167 13405 -25762
Branches 3589 3390 -199
===========================================
- Hits 25694 7399 -18295
+ Misses 13361 5816 -7545
- Partials 112 190 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.19% <ø> (-0.26%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ator-superset/superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlld3MvbWVudS50c3g=) | | |
| [...frontend/src/dashboard/util/newComponentFactory.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvbmV3Q29tcG9uZW50RmFjdG9yeS5qcw==) | | |
| [...ntend/src/explore/components/AdhocFilterOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL0FkaG9jRmlsdGVyT3B0aW9uLmpzeA==) | | |
| [...t/superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MYWJlbC9pbmRleC50c3g=) | | |
| [superset/db\_engine\_specs/exasol.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2V4YXNvbC5weQ==) | | |
| [...et/superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9BbmNob3JMaW5rLmpzeA==) | | |
| [superset/models/user\_attributes.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3VzZXJfYXR0cmlidXRlcy5weQ==) | | |
| [superset/utils/feature\_flag\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZmVhdHVyZV9mbGFnX21hbmFnZXIucHk=) | | |
| [...rset-frontend/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlldy9MaXN0Vmlldy50c3g=) | | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
| ... and [1218 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...51582d1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.44%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.15% -5.45%
==========================================
Files 828 395 -433
Lines 39167 24836 -14331
Branches 3589 0 -3589
==========================================
- Hits 25694 14940 -10754
+ Misses 13361 9896 -3465
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.15% <95.69%> (-0.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...e68b228](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504863042
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
+
+ buf = BytesIO(rv.data)
+ self.assertTrue(is_zipfile(buf))
+
+ def test_export_database_not_allowed(self):
+ """
+ Database API: Test export database
Review comment:
Good catch, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **increase** coverage by `7.98%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
+ Coverage 65.60% 73.58% +7.98%
==========================================
Files 828 438 -390
Lines 39167 14684 -24483
Branches 3589 3592 +3
==========================================
- Hits 25694 10805 -14889
+ Misses 13361 3771 -9590
+ Partials 112 108 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.86% <ø> (+0.41%)` | :arrow_up: |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Ub29sdGlwV3JhcHBlci5qc3g=) | | |
| [...set/superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2FjdGlvbnMvc3FsTGFiLmpz) | | |
| [...et/migrations/versions/ddd6ebdd853b\_annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kZGQ2ZWJkZDg1M2JfYW5ub3RhdGlvbnMucHk=) | | |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | | |
| [...superset-frontend/src/components/Menu/UserMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9NZW51L1VzZXJNZW51LnRzeA==) | | |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | | |
| [superset/examples/long\_lat.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbG9uZ19sYXQucHk=) | | |
| [...ions/versions/7e3ddad2a00b\_results\_key\_to\_query.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83ZTNkZGFkMmEwMGJfcmVzdWx0c19rZXlfdG9fcXVlcnkucHk=) | | |
| [superset/migrations/versions/472d2f73dfd4\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NzJkMmY3M2RmZDRfLnB5) | | |
| ... and [1251 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...00a0200](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504579667
##########
File path: superset/databases/commands/exceptions.py
##########
@@ -28,7 +28,7 @@
class DatabaseInvalidError(CommandInvalidError):
- message = _("Dashboard parameters are invalid.")
+ message = _("Database parameters are invalid.")
Review comment:
ups ;)
##########
File path: superset/databases/commands/export.py
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+import json
+import os.path
+from io import BytesIO
+from typing import Any, Dict
+from zipfile import ZipFile
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.databases.dao import DatabaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize
+
+
+class ExportDatabaseCommand(BaseCommand):
+ def __init__(self, database_id: int, filename: str):
+ self.database_id = database_id
+ self.filename = filename
+
+ def run(self) -> BytesIO:
+ self.validate()
+
+ root = os.path.splitext(self.filename)[0]
+ database = DatabaseDAO.find_by_id(self.database_id)
+ name = sanitize(database.database_name)
+ database_filename = f"{root}/databases/{name}.yaml"
+
+ payload: Dict[Any, Any]
+ payload = database.export_to_dict(
+ recursive=False,
+ include_parent_ref=False,
+ include_defaults=True,
+ export_uuids=True,
+ )
+ if "extra" in payload:
+ try:
+ payload["extra"] = json.loads(payload["extra"])
+ except json.decoder.JSONDecodeError:
+ pass
+
+ payload["version"] = IMPORT_EXPORT_VERSION
+
+ buf = BytesIO()
+ with ZipFile(buf, "w") as bundle:
Review comment:
Assuming no file is ever created on the FS, is this correct?
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
+
+ buf = BytesIO(rv.data)
+ self.assertTrue(is_zipfile(buf))
+
+ def test_export_database_not_allowed(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="gamma")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 401)
Review comment:
This should return a 404, right?
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
+
+ buf = BytesIO(rv.data)
+ self.assertTrue(is_zipfile(buf))
+
+ def test_export_database_not_allowed(self):
+ """
+ Database API: Test export database
Review comment:
nit: `Database API: Test export database not allowed`
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
Review comment:
Fetch a database `get_examples_database` then use the id from the model itself
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
+
+ buf = BytesIO(rv.data)
+ self.assertTrue(is_zipfile(buf))
+
+ def test_export_database_not_allowed(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="gamma")
+ uri = "api/v1/database/1/export/"
Review comment:
Fetch a database get_examples_database then use the id from the model itself
##########
File path: superset/databases/commands/export.py
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+import json
+import os.path
+from io import BytesIO
+from typing import Any, Dict
+from zipfile import ZipFile
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.databases.dao import DatabaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize
+
+
+class ExportDatabaseCommand(BaseCommand):
+ def __init__(self, database_id: int, filename: str):
+ self.database_id = database_id
+ self.filename = filename
+
+ def run(self) -> BytesIO:
+ self.validate()
+
+ root = os.path.splitext(self.filename)[0]
+ database = DatabaseDAO.find_by_id(self.database_id)
+ name = sanitize(database.database_name)
+ database_filename = f"{root}/databases/{name}.yaml"
+
+ payload: Dict[Any, Any]
+ payload = database.export_to_dict(
+ recursive=False,
+ include_parent_ref=False,
+ include_defaults=True,
+ export_uuids=True,
+ )
+ if "extra" in payload:
Review comment:
Should this logic live inside `export_to_dict` ?
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
Review comment:
nit: assert rv.status_code == 200
##########
File path: superset/databases/commands/export.py
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+import json
+import os.path
+from io import BytesIO
+from typing import Any, Dict
+from zipfile import ZipFile
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.databases.dao import DatabaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize
+
+
+class ExportDatabaseCommand(BaseCommand):
+ def __init__(self, database_id: int, filename: str):
+ self.database_id = database_id
+ self.filename = filename
+
+ def run(self) -> BytesIO:
+ self.validate()
+
+ root = os.path.splitext(self.filename)[0]
+ database = DatabaseDAO.find_by_id(self.database_id)
Review comment:
Avoid this extra fetch by using validate: https://github.com/apache/incubator-superset/blob/master/superset/databases/commands/update.py#L74
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
+
+ buf = BytesIO(rv.data)
+ self.assertTrue(is_zipfile(buf))
+
+ def test_export_database_not_allowed(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="gamma")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 401)
Review comment:
nit: add one more test with a non existent database_id (use max then plus 1).
##########
File path: tests/datasets/api_tests.py
##########
@@ -189,10 +190,9 @@ def pg_test_query_parameter(query_parameter, expected_response):
"admin_database",
"information_schema",
"public",
- "superset",
]
expected_response = {
- "count": 5,
+ "count": 4,
Review comment:
This should be replaced by an actual db.query instead of the hardcoded value
##########
File path: tests/datasets/api_tests.py
##########
@@ -165,6 +165,7 @@ def test_get_dataset_distinct_schema(self):
"""
Dataset API: Test get dataset distinct schema
"""
+ self.maxDiff = None
Review comment:
remove (debug I know) :)
##########
File path: superset/databases/commands/export.py
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+import json
+import os.path
+from io import BytesIO
+from typing import Any, Dict
+from zipfile import ZipFile
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.databases.dao import DatabaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize
+
+
+class ExportDatabaseCommand(BaseCommand):
+ def __init__(self, database_id: int, filename: str):
+ self.database_id = database_id
+ self.filename = filename
+
+ def run(self) -> BytesIO:
+ self.validate()
+
+ root = os.path.splitext(self.filename)[0]
+ database = DatabaseDAO.find_by_id(self.database_id)
+ name = sanitize(database.database_name)
+ database_filename = f"{root}/databases/{name}.yaml"
+
+ payload: Dict[Any, Any]
+ payload = database.export_to_dict(
+ recursive=False,
+ include_parent_ref=False,
+ include_defaults=True,
+ export_uuids=True,
+ )
+ if "extra" in payload:
+ try:
+ payload["extra"] = json.loads(payload["extra"])
+ except json.decoder.JSONDecodeError:
+ pass
+
+ payload["version"] = IMPORT_EXPORT_VERSION
+
+ buf = BytesIO()
+ with ZipFile(buf, "w") as bundle:
+ with bundle.open(database_filename, "w") as fp:
+ fp.write(yaml.safe_dump(payload, sort_keys=False).encode())
+
+ for dataset in database.tables:
+ name = sanitize(dataset.table_name)
+ dataset_filename = f"{root}/datasets/{name}.yaml"
+
+ # TODO (betodealmeida): reuse logic from ExportDatasetCommand
+ # once it's implemented
+ payload = dataset.export_to_dict(
+ recursive=True,
+ include_parent_ref=False,
+ include_defaults=True,
+ export_uuids=True,
+ )
+ payload["version"] = IMPORT_EXPORT_VERSION
Review comment:
Should `export_to_dict` have this logic?
##########
File path: tests/dashboards/api_tests.py
##########
@@ -955,12 +956,14 @@ def test_export(self):
self.login(username="admin")
argument = [1, 2]
uri = f"api/v1/dashboard/export/?q={prison.dumps(argument)}"
- rv = self.get_assert_metric(uri, "export")
+
+ # freeze time to ensure filename is deterministic
+ with freeze_time("2020-01-01T00:00:00Z"):
+ rv = self.get_assert_metric(uri, "export")
+ headers = generate_download_headers("json")["Content-Disposition"]
+
self.assertEqual(rv.status_code, 200)
- self.assertEqual(
- rv.headers["Content-Disposition"],
- generate_download_headers("json")["Content-Disposition"],
- )
+ self.assertEqual(rv.headers["Content-Disposition"], headers)
Review comment:
nit: We are currently preferring `assert rv.headers["Content-Disposition"] == headers`. More inline with pytest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.35%`.
> The diff coverage is `96.84%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.24% -5.36%
==========================================
Files 828 394 -434
Lines 39167 24928 -14239
Branches 3589 0 -3589
==========================================
- Hits 25694 15018 -10676
+ Misses 13361 9910 -3451
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.24% <96.84%> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.65% <95.65%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.29% <100.00%> (+0.92%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| ... and [469 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...d09e861](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504868577
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
+
+ buf = BytesIO(rv.data)
+ self.assertTrue(is_zipfile(buf))
+
+ def test_export_database_not_allowed(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="gamma")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 401)
Review comment:
Hmmm, I think 403 would be more appropriate, no? The user is authenticated (as "gamma") but not authorized.
I'll add another test for an non-existent database returning 404.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504864056
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
+
+ buf = BytesIO(rv.data)
+ self.assertTrue(is_zipfile(buf))
+
+ def test_export_database_not_allowed(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="gamma")
+ uri = "api/v1/database/1/export/"
Review comment:
Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.55%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.04% -5.56%
==========================================
Files 828 395 -433
Lines 39167 24806 -14361
Branches 3589 0 -3589
==========================================
- Hits 25694 14895 -10799
+ Misses 13361 9911 -3450
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.04% <95.69%> (-0.99%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.89% <94.73%> (-2.47%)` | :arrow_down: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...1bcf9f0](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504866785
##########
File path: superset/databases/commands/export.py
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+import json
+import os.path
+from io import BytesIO
+from typing import Any, Dict
+from zipfile import ZipFile
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.databases.dao import DatabaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize
+
+
+class ExportDatabaseCommand(BaseCommand):
+ def __init__(self, database_id: int, filename: str):
+ self.database_id = database_id
+ self.filename = filename
+
+ def run(self) -> BytesIO:
+ self.validate()
+
+ root = os.path.splitext(self.filename)[0]
+ database = DatabaseDAO.find_by_id(self.database_id)
+ name = sanitize(database.database_name)
+ database_filename = f"{root}/databases/{name}.yaml"
+
+ payload: Dict[Any, Any]
+ payload = database.export_to_dict(
+ recursive=False,
+ include_parent_ref=False,
+ include_defaults=True,
+ export_uuids=True,
+ )
+ if "extra" in payload:
+ try:
+ payload["extra"] = json.loads(payload["extra"])
+ except json.decoder.JSONDecodeError:
+ pass
+
+ payload["version"] = IMPORT_EXPORT_VERSION
+
+ buf = BytesIO()
+ with ZipFile(buf, "w") as bundle:
+ with bundle.open(database_filename, "w") as fp:
+ fp.write(yaml.safe_dump(payload, sort_keys=False).encode())
+
+ for dataset in database.tables:
+ name = sanitize(dataset.table_name)
+ dataset_filename = f"{root}/datasets/{name}.yaml"
+
+ # TODO (betodealmeida): reuse logic from ExportDatasetCommand
+ # once it's implemented
+ payload = dataset.export_to_dict(
+ recursive=True,
+ include_parent_ref=False,
+ include_defaults=True,
+ export_uuids=True,
+ )
+ payload["version"] = IMPORT_EXPORT_VERSION
Review comment:
It should not, otherwise downloads in the old format (single YAML file) would have the version of the new format (zipped YAML files).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.41%`.
> The diff coverage is `96.84%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.18% -5.42%
==========================================
Files 828 394 -434
Lines 39167 24928 -14239
Branches 3589 0 -3589
==========================================
- Hits 25694 15002 -10692
+ Misses 13361 9926 -3435
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.18% <96.84%> (-0.85%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.65% <95.65%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.29% <100.00%> (+0.92%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| ... and [470 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...d09e861](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.13%`.
> The diff coverage is `96.84%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.46% -4.14%
==========================================
Files 828 835 +7
Lines 39167 39648 +481
Branches 3589 3610 +21
==========================================
- Hits 25694 24371 -1323
- Misses 13361 15096 +1735
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.73% <96.84%> (-0.30%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.65% <95.65%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.29% <100.00%> (+0.92%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [908 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...d09e861](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `3.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 62.40% -3.20%
==========================================
Files 828 438 -390
Lines 39167 14681 -24486
Branches 3589 3592 +3
==========================================
- Hits 25694 9162 -16532
+ Misses 13361 5338 -8023
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | | |
| [superset/views/chart/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvZmlsdGVycy5weQ==) | | |
| [superset/views/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc2NoZWR1bGVzLnB5) | | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | | |
| [...-superset/superset-frontend/src/logger/LogUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvbG9nZ2VyL0xvZ1V0aWxzLmpz) | | |
| [...rontend/src/dashboard/util/shouldWrapChildInRow.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvc2hvdWxkV3JhcENoaWxkSW5Sb3cuanM=) | | |
| [...nd/src/dashboard/util/getDetailedComponentWidth.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RGV0YWlsZWRDb21wb25lbnRXaWR0aC5qcw==) | | |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU2hhcmVTcWxMYWJRdWVyeS5qc3g=) | | |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | | |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RmlsdGVyU2NvcGVGcm9tTm9kZXNUcmVlLmpz) | | |
| ... and [1252 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...c906ac2](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.72%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 59.87% -5.73%
==========================================
Files 828 395 -433
Lines 39167 24795 -14372
Branches 3589 0 -3589
==========================================
- Hits 25694 14846 -10848
+ Misses 13361 9949 -3412
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.87% <95.69%> (-1.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `82.52% <94.73%> (-6.84%)` | :arrow_down: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [477 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...0180322](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504596651
##########
File path: superset/views/base_api.py
##########
@@ -127,7 +127,7 @@ class BaseSupersetModelRestApi(ModelRestApi):
"data": "list",
"delete": "delete",
"distinct": "list",
- "export": "mulexport",
+ "export": "list",
Review comment:
there is you can bring this mapping to the leaf class itself. But why do we want a new permission name(it's already mapped to it's class domain) ?
##########
File path: superset/views/base_api.py
##########
@@ -127,7 +127,7 @@ class BaseSupersetModelRestApi(ModelRestApi):
"data": "list",
"delete": "delete",
"distinct": "list",
- "export": "mulexport",
+ "export": "list",
Review comment:
there is, you can bring this mapping to the leaf class itself. But why do we want a new permission name(it's already mapped to it's class domain) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504269193
##########
File path: tests/dashboards/api_tests.py
##########
@@ -955,12 +956,14 @@ def test_export(self):
self.login(username="admin")
argument = [1, 2]
uri = f"api/v1/dashboard/export/?q={prison.dumps(argument)}"
- rv = self.get_assert_metric(uri, "export")
+
+ # freeze time to ensure filename is deterministic
+ with freeze_time("2020-01-01T00:00:00Z"):
+ rv = self.get_assert_metric(uri, "export")
+ headers = generate_download_headers("json")["Content-Disposition"]
+
self.assertEqual(rv.status_code, 200)
- self.assertEqual(
- rv.headers["Content-Disposition"],
- generate_download_headers("json")["Content-Disposition"],
- )
+ self.assertEqual(rv.headers["Content-Disposition"], headers)
Review comment:
This test failed with me once, because the call to `get_assert_metric` and the call to `generate_download_headers` can result in different timestamps. Using `freeze_time` here will make the test always succeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r505054950
##########
File path: superset/views/base_api.py
##########
@@ -127,7 +127,7 @@ class BaseSupersetModelRestApi(ModelRestApi):
"data": "list",
"delete": "delete",
"distinct": "list",
- "export": "mulexport",
+ "export": "list",
Review comment:
I think I'm misunderstanding how this works, and I think I also need `mulexport` for databases (so we can select multiple dbs and export them at once). Let me take another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `96.93%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 65.55% -0.06%
==========================================
Files 828 835 +7
Lines 39167 39655 +488
Branches 3589 3610 +21
==========================================
+ Hits 25694 25994 +300
- Misses 13361 13548 +187
- Partials 112 113 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.30% <ø> (-0.15%)` | :arrow_down: |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.92% <96.93%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.23% <95.23%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| ... and [906 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `10.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
===========================================
- Coverage 65.60% 55.21% -10.40%
===========================================
Files 828 404 -424
Lines 39167 13405 -25762
Branches 3589 3390 -199
===========================================
- Hits 25694 7401 -18293
+ Misses 13361 5814 -7547
- Partials 112 190 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.21% <ø> (-0.24%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/versions/4e6a06bad7a8\_init.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80ZTZhMDZiYWQ3YThfaW5pdC5weQ==) | | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL0RhdGFzb3VyY2VDb250cm9sLmpzeA==) | | |
| [...et/superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9yZWR1Y2Vycy9pbmRleC5qcw==) | | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | | |
| [...ons/versions/18e88e1cc004\_making\_audit\_nullable.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xOGU4OGUxY2MwMDRfbWFraW5nX2F1ZGl0X251bGxhYmxlLnB5) | | |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | | |
| [...nd/src/messageToasts/components/ToastPresenter.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvbWVzc2FnZVRvYXN0cy9jb21wb25lbnRzL1RvYXN0UHJlc2VudGVyLnRzeA==) | | |
| [...t/superset-frontend/src/profile/components/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvcHJvZmlsZS9jb21wb25lbnRzL0FwcC50c3g=) | | |
| [...d7c1a0d6f2da\_remove\_limit\_used\_from\_query\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kN2MxYTBkNmYyZGFfcmVtb3ZlX2xpbWl0X3VzZWRfZnJvbV9xdWVyeV9tb2RlbC5weQ==) | | |
| [.../migrations/versions/1a1d627ebd8e\_position\_json.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8xYTFkNjI3ZWJkOGVfcG9zaXRpb25fanNvbi5weQ==) | | |
| ... and [1218 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...26234eb](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `9.65%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 55.94% -9.66%
==========================================
Files 828 404 -424
Lines 39167 13410 -25757
Branches 3589 3392 -197
==========================================
- Hits 25694 7502 -18192
+ Misses 13361 5726 -7635
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.94% <ø> (+0.49%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/migrations/versions/ef8843b41dac\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lZjg4NDNiNDFkYWNfLnB5) | | |
| [superset/cachekeys/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2FjaGVrZXlzL3NjaGVtYXMucHk=) | | |
| [...erset/superset-frontend/src/components/FormRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Gb3JtUm93LmpzeA==) | | |
| [superset/sql\_validators/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvX19pbml0X18ucHk=) | | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9JbmRldGVybWluYXRlQ2hlY2tib3gudHN4) | | |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC50c3g=) | | |
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGF0YXNvdXJjZS9DaGFuZ2VEYXRhc291cmNlTW9kYWwudHN4) | | |
| [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | | |
| [...tend/src/dashboard/util/getFilterScopeNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RmlsdGVyU2NvcGVOb2Rlc1RyZWUuanM=) | | |
| [...igrations/versions/ad82a75afd82\_add\_query\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZDgyYTc1YWZkODJfYWRkX3F1ZXJ5X21vZGVsLnB5) | | |
| ... and [1216 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 65.50% -0.10%
==========================================
Files 828 833 +5
Lines 39167 39538 +371
Branches 3589 3598 +9
==========================================
+ Hits 25694 25898 +204
- Misses 13361 13527 +166
- Partials 112 113 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.29% <ø> (-0.16%)` | :arrow_down: |
| #javascript | `62.67% <ø> (+0.36%)` | :arrow_up: |
| #python | `60.88% <95.69%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| ... and [895 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...a15f1b1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504857698
##########
File path: superset/databases/commands/export.py
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+import json
+import os.path
+from io import BytesIO
+from typing import Any, Dict
+from zipfile import ZipFile
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.databases.dao import DatabaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize
+
+
+class ExportDatabaseCommand(BaseCommand):
+ def __init__(self, database_id: int, filename: str):
+ self.database_id = database_id
+ self.filename = filename
+
+ def run(self) -> BytesIO:
+ self.validate()
+
+ root = os.path.splitext(self.filename)[0]
+ database = DatabaseDAO.find_by_id(self.database_id)
Review comment:
Good point, will fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.13%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.46% -4.14%
==========================================
Files 828 833 +5
Lines 39167 39494 +327
Branches 3589 3593 +4
==========================================
- Hits 25694 24276 -1418
- Misses 13361 15037 +1676
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.62% <ø> (+0.32%)` | :arrow_up: |
| #python | `60.78% <95.69%> (-0.25%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.65% <0.00%> (-8.43%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.59% <0.00%> (-2.41%)` | :arrow_down: |
| ... and [897 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...474167a](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `3.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 62.40% -3.20%
==========================================
Files 828 438 -390
Lines 39167 14681 -24486
Branches 3589 3592 +3
==========================================
- Hits 25694 9162 -16532
+ Misses 13361 5338 -8023
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | | |
| [...-frontend/src/dashboard/util/getDragDropManager.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RHJhZ0Ryb3BNYW5hZ2VyLmpz) | | |
| [...et/migrations/versions/ddd6ebdd853b\_annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kZGQ2ZWJkZDg1M2JfYW5ub3RhdGlvbnMucHk=) | | |
| [...7bf4f117f9\_adding\_extra\_field\_to\_database\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy84NjdiZjRmMTE3ZjlfYWRkaW5nX2V4dHJhX2ZpZWxkX3RvX2RhdGFiYXNlX21vZGVsLnB5) | | |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL0RhdGVGaWx0ZXJDb250cm9sLmpzeA==) | | |
| [superset/databases/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | | |
| [...perset/superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBQbHVnaW5zLnRz) | | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
| [...-frontend/src/SqlLab/reducers/localStorageUsage.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL3JlZHVjZXJzL2xvY2FsU3RvcmFnZVVzYWdlLmpz) | | |
| ... and [1252 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...26234eb](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.78%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.81% -4.79%
==========================================
Files 828 833 +5
Lines 39167 39476 +309
Branches 3589 3592 +3
==========================================
- Hits 25694 24008 -1686
- Misses 13361 15287 +1926
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `59.87% <95.69%> (-1.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `82.52% <94.73%> (-6.84%)` | :arrow_down: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [915 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...0180322](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.05%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.54% -4.06%
==========================================
Files 828 833 +5
Lines 39167 39535 +368
Branches 3589 3598 +9
==========================================
- Hits 25694 24332 -1362
- Misses 13361 15021 +1660
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.36%)` | :arrow_up: |
| #python | `60.88% <95.69%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| ... and [895 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...a15f1b1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r502853118
##########
File path: superset/views/base_api.py
##########
@@ -127,7 +127,7 @@ class BaseSupersetModelRestApi(ModelRestApi):
"data": "list",
"delete": "delete",
"distinct": "list",
- "export": "mulexport",
+ "export": "list",
Review comment:
@dpgaspar, can you help me with this? I had to change this to `list` in order to make the new export work, but I assume this will break the old export (which I want to keep for now). What is `mulexport` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r505309073
##########
File path: tests/databases/api_tests.py
##########
@@ -801,3 +803,26 @@ def test_get_database_related_objects_not_found(self):
uri = f"api/v1/database/{database.id}/related_objects/"
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 404)
+
+ def test_export_database(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="admin")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 200)
+
+ buf = BytesIO(rv.data)
+ self.assertTrue(is_zipfile(buf))
+
+ def test_export_database_not_allowed(self):
+ """
+ Database API: Test export database
+ """
+ self.login(username="gamma")
+ uri = "api/v1/database/1/export/"
+ rv = self.client.get(uri)
+
+ self.assertEqual(rv.status_code, 401)
Review comment:
Oh! I was misunderstanding this!
It's actually denied because of FAB's permissions. I was thinking that it was a test to infer the user had no access to view/list/get that particular database, btw that's a good test to add also: https://github.com/apache/incubator-superset/blob/master/tests/databases/api_tests.py#L542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 65.21% -0.39%
==========================================
Files 828 833 +5
Lines 39167 39479 +312
Branches 3589 3592 +3
==========================================
+ Hits 25694 25748 +54
- Misses 13361 13622 +261
+ Partials 112 109 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.89% <ø> (+0.44%)` | :arrow_up: |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `60.25% <95.69%> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [903 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...0180322](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
+ Coverage 65.60% 65.65% +0.05%
==========================================
Files 828 833 +5
Lines 39167 39538 +371
Branches 3589 3598 +9
==========================================
+ Hits 25694 25959 +265
- Misses 13361 13471 +110
+ Partials 112 108 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.98% <ø> (+0.53%)` | :arrow_up: |
| #javascript | `62.67% <ø> (+0.36%)` | :arrow_up: |
| #python | `60.88% <95.69%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.50% <0.00%> (-2.50%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| ... and [895 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...a15f1b1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.31%`.
> The diff coverage is `96.93%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.29% -4.32%
==========================================
Files 828 835 +7
Lines 39167 39652 +485
Branches 3589 3610 +21
==========================================
- Hits 25694 24303 -1391
- Misses 13361 15168 +1807
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.44% <96.93%> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.23% <95.23%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| ... and [909 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.01%`.
> The diff coverage is `96.93%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.58% -4.02%
==========================================
Files 828 835 +7
Lines 39167 39652 +485
Branches 3589 3610 +21
==========================================
- Hits 25694 24421 -1273
- Misses 13361 15050 +1689
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.92% <96.93%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.23% <95.23%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| ... and [906 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.47%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.12% -4.48%
==========================================
Files 828 833 +5
Lines 39167 39535 +368
Branches 3589 3598 +9
==========================================
- Hits 25694 24167 -1527
- Misses 13361 15186 +1825
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.36%)` | :arrow_up: |
| #python | `60.21% <95.69%> (-0.82%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [899 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...a15f1b1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.78%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.81% -4.79%
==========================================
Files 828 833 +5
Lines 39167 39476 +309
Branches 3589 3592 +3
==========================================
- Hits 25694 24008 -1686
- Misses 13361 15287 +1926
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `59.87% <95.69%> (-1.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `82.52% <94.73%> (-6.84%)` | :arrow_down: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [915 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...c906ac2](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.74%`.
> The diff coverage is `96.84%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 59.85% -5.75%
==========================================
Files 828 394 -434
Lines 39167 24917 -14250
Branches 3589 0 -3589
==========================================
- Hits 25694 14915 -10779
+ Misses 13361 10002 -3359
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.85% <96.84%> (-1.17%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.65% <95.65%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.00% <100.00%> (-6.36%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...d09e861](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **increase** coverage by `7.59%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
+ Coverage 65.60% 73.19% +7.59%
==========================================
Files 828 438 -390
Lines 39167 14684 -24483
Branches 3589 3592 +3
==========================================
- Hits 25694 10748 -14946
+ Misses 13361 3823 -9538
- Partials 112 113 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.18% <ø> (-0.27%)` | :arrow_down: |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...s/versions/3c3ffe173e4f\_add\_sql\_string\_to\_table.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zYzNmZmUxNzNlNGZfYWRkX3NxbF9zdHJpbmdfdG9fdGFibGUucHk=) | | |
| [...frontend/src/dashboard/util/dropOverflowsParent.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZHJvcE92ZXJmbG93c1BhcmVudC5qcw==) | | |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | | |
| [...superset/superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaW5rLnRzeA==) | | |
| [.../src/dashboard/components/BuilderComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvQnVpbGRlckNvbXBvbmVudFBhbmUuanN4) | | |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | | |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | | |
| [...igrations/versions/c5756bec8b47\_time\_grain\_sqla.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9jNTc1NmJlYzhiNDdfdGltZV9ncmFpbl9zcWxhLnB5) | | |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL0NvbGxlY3Rpb25Db250cm9sLmpzeA==) | | |
| [...tend/src/dashboard/util/getFilterScopeNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RmlsdGVyU2NvcGVOb2Rlc1RyZWUuanM=) | | |
| ... and [1251 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...4783343](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `96.93%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
+ Coverage 65.60% 65.69% +0.09%
==========================================
Files 828 835 +7
Lines 39167 39655 +488
Branches 3589 3610 +21
==========================================
+ Hits 25694 26050 +356
- Misses 13361 13496 +135
+ Partials 112 109 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.96% <ø> (+0.51%)` | :arrow_up: |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.92% <96.93%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.23% <95.23%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| ... and [906 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504902865
##########
File path: tests/datasets/api_tests.py
##########
@@ -189,10 +190,9 @@ def pg_test_query_parameter(query_parameter, expected_response):
"admin_database",
"information_schema",
"public",
- "superset",
]
expected_response = {
- "count": 5,
+ "count": 4,
Review comment:
But then if there's a regression in reading from the DB the unit test wouldn't capture it, since the expected value and the API response are both built from the DB call. Wouldn't it be better to leave the hardcoded data to detect that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `0.52%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 65.07% -0.53%
==========================================
Files 828 833 +5
Lines 39167 39479 +312
Branches 3589 3592 +3
==========================================
- Hits 25694 25692 -2
- Misses 13361 13674 +313
- Partials 112 113 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.24% <ø> (-0.22%)` | :arrow_down: |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `60.25% <95.69%> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [903 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...0180322](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.43%`.
> The diff coverage is `96.84%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.16% -4.44%
==========================================
Files 828 835 +7
Lines 39167 39648 +481
Branches 3589 3610 +21
==========================================
- Hits 25694 24250 -1444
- Misses 13361 15217 +1856
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.71% <ø> (+0.41%)` | :arrow_up: |
| #python | `60.24% <96.84%> (-0.79%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.65% <95.65%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.29% <100.00%> (+0.92%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `80.63% <0.00%> (-7.83%)` | :arrow_down: |
| ... and [910 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...d09e861](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **increase** coverage by `7.97%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
+ Coverage 65.60% 73.57% +7.97%
==========================================
Files 828 438 -390
Lines 39167 14684 -24483
Branches 3589 3592 +3
==========================================
- Hits 25694 10804 -14890
+ Misses 13361 3771 -9590
+ Partials 112 109 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.82% <ø> (+0.37%)` | :arrow_up: |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL1RpbWVTZXJpZXNDb2x1bW5Db250cm9sLmpzeA==) | | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | | |
| [...frontend/src/SqlLab/components/QueryStateLabel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlTdGF0ZUxhYmVsLmpzeA==) | | |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
| [superset/dashboards/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | | |
| [...rc/explore/components/controls/ViewportControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL1ZpZXdwb3J0Q29udHJvbC5qc3g=) | | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9hY3Rpb25zL2V4cGxvcmVBY3Rpb25zLmpz) | | |
| [...frontend/src/dashboard/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3JlZHVjZXJzL2dldEluaXRpYWxTdGF0ZS5qcw==) | | |
| [...bator-superset/superset-frontend/src/CRUD/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvQ1JVRC91dGlscy5qcw==) | | |
| ... and [1251 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...4783343](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `2.93%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 62.67% -2.94%
==========================================
Files 828 438 -390
Lines 39167 14688 -24479
Branches 3589 3598 +9
==========================================
- Hits 25694 9205 -16489
+ Misses 13361 5301 -8060
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.36%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | | |
| [superset/security/analytics\_db\_safety.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvYW5hbHl0aWNzX2RiX3NhZmV0eS5weQ==) | | |
| [...ws/CRUD/data/savedquery/SavedQueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlld3MvQ1JVRC9kYXRhL3NhdmVkcXVlcnkvU2F2ZWRRdWVyeVByZXZpZXdNb2RhbC50c3g=) | | |
| [...set-frontend/src/explore/actions/exploreActions.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9hY3Rpb25zL2V4cGxvcmVBY3Rpb25zLmpz) | | |
| [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvTGltaXRDb250cm9sLnRzeA==) | | |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | | |
| [...ions/bf706ae5eb46\_cal\_heatmap\_metric\_to\_metrics.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iZjcwNmFlNWViNDZfY2FsX2hlYXRtYXBfbWV0cmljX3RvX21ldHJpY3MucHk=) | | |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | | |
| [.../migrations/versions/bddc498dd179\_adhoc\_filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9iZGRjNDk4ZGQxNzlfYWRob2NfZmlsdGVycy5weQ==) | | |
| ... and [1252 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...a15f1b1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.15%`.
> The diff coverage is `96.93%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.44% -5.16%
==========================================
Files 828 394 -434
Lines 39167 24931 -14236
Branches 3589 0 -3589
==========================================
- Hits 25694 15070 -10624
+ Misses 13361 9861 -3500
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.44% <96.93%> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.23% <95.23%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| ... and [468 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504854097
##########
File path: tests/dashboards/api_tests.py
##########
@@ -955,12 +956,14 @@ def test_export(self):
self.login(username="admin")
argument = [1, 2]
uri = f"api/v1/dashboard/export/?q={prison.dumps(argument)}"
- rv = self.get_assert_metric(uri, "export")
+
+ # freeze time to ensure filename is deterministic
+ with freeze_time("2020-01-01T00:00:00Z"):
+ rv = self.get_assert_metric(uri, "export")
+ headers = generate_download_headers("json")["Content-Disposition"]
+
self.assertEqual(rv.status_code, 200)
- self.assertEqual(
- rv.headers["Content-Disposition"],
- generate_download_headers("json")["Content-Disposition"],
- )
+ self.assertEqual(rv.headers["Content-Disposition"], headers)
Review comment:
Will do!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `3.19%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 62.40% -3.20%
==========================================
Files 828 438 -390
Lines 39167 14681 -24486
Branches 3589 3592 +3
==========================================
- Hits 25694 9162 -16532
+ Misses 13361 5338 -8023
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | | |
| [superset/db\_engine\_specs/cockroachdb.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NvY2tyb2FjaGRiLnB5) | | |
| [...rontend/src/SqlLab/components/ShareSqlLabQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvU2hhcmVTcWxMYWJRdWVyeS5qc3g=) | | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | | |
| [superset/migrations/versions/5ccf602336a0\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy81Y2NmNjAyMzM2YTBfLnB5) | | |
| [...superset-frontend/src/components/Popover/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9Qb3BvdmVyL2luZGV4LnRzeA==) | | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
| [superset/migrations/versions/fc480c87706c\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mYzQ4MGM4NzcwNmNfLnB5) | | |
| [...set-frontend/src/dashboard/util/getLocationHash.ts](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0TG9jYXRpb25IYXNoLnRz) | | |
| [...frontend/src/profile/components/CreatedContent.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvcHJvZmlsZS9jb21wb25lbnRzL0NyZWF0ZWRDb250ZW50LnRzeA==) | | |
| ... and [1251 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...00a0200](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.78%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.81% -4.79%
==========================================
Files 828 833 +5
Lines 39167 39476 +309
Branches 3589 3592 +3
==========================================
- Hits 25694 24008 -1686
- Misses 13361 15287 +1926
- Partials 112 181 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `59.87% <95.69%> (-1.16%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `82.52% <94.73%> (-6.84%)` | :arrow_down: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| ... and [915 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...26234eb](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-708887742
@dpgaspar I'm going to change some things, I'll ping you when it's ready for review again. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `5.18%`.
> The diff coverage is `96.93%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 60.41% -5.19%
==========================================
Files 828 394 -434
Lines 39167 24931 -14236
Branches 3589 0 -3589
==========================================
- Hits 25694 15063 -10631
+ Misses 13361 9868 -3493
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.41% <96.93%> (-0.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.23% <95.23%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `90.56% <100.00%> (+1.20%)` | :arrow_up: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| ... and [471 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r505320162
##########
File path: tests/datasets/api_tests.py
##########
@@ -189,10 +190,9 @@ def pg_test_query_parameter(query_parameter, expected_response):
"admin_database",
"information_schema",
"public",
- "superset",
]
expected_response = {
- "count": 5,
+ "count": 4,
Review comment:
Good point, I've done the same, but I'm wondering if it's the actual count from what's on the DB if it would be better for us to change this? (non blocking for sure)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **increase** coverage by `7.56%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
+ Coverage 65.60% 73.16% +7.56%
==========================================
Files 828 438 -390
Lines 39167 14684 -24483
Branches 3589 3592 +3
==========================================
- Hits 25694 10744 -14950
+ Misses 13361 3827 -9534
- Partials 112 113 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.17% <ø> (-0.28%)` | :arrow_down: |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rations/versions/7dbf98566af7\_slice\_description.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83ZGJmOTg1NjZhZjdfc2xpY2VfZGVzY3JpcHRpb24ucHk=) | | |
| [...d/src/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | | |
| [...rontend/src/components/ListView/CardCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9MaXN0Vmlldy9DYXJkQ29sbGVjdGlvbi50c3g=) | | |
| [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL2NvbnRyb2xzL1ZpelR5cGVDb250cm9sLmpzeA==) | | |
| [...end/src/explore/components/ControlPanelSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL0NvbnRyb2xQYW5lbFNlY3Rpb24uanN4) | | |
| [...superset-frontend/src/components/FlashProvider.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9GbGFzaFByb3ZpZGVyLnRzeA==) | | |
| [...s/versions/3c3ffe173e4f\_add\_sql\_string\_to\_table.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zYzNmZmUxNzNlNGZfYWRkX3NxbF9zdHJpbmdfdG9fdGFibGUucHk=) | | |
| [superset/migrations/versions/705732c70154\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy83MDU3MzJjNzAxNTRfLnB5) | | |
| ... and [1251 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...00a0200](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `9.73%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 55.86% -9.74%
==========================================
Files 828 404 -424
Lines 39167 13405 -25762
Branches 3589 3390 -199
==========================================
- Hits 25694 7489 -18205
+ Misses 13361 5734 -7627
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.86% <ø> (+0.41%)` | :arrow_up: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/examples/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY3NzX3RlbXBsYXRlcy5weQ==) | | |
| [...s/versions/eca4694defa7\_sqllab\_setting\_defaults.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lY2E0Njk0ZGVmYTdfc3FsbGFiX3NldHRpbmdfZGVmYXVsdHMucHk=) | | |
| [...or-superset/superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvYWRkU2xpY2UvQXBwLnRzeA==) | | |
| [...ashboard/components/gridComponents/new/NewTabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZ3JpZENvbXBvbmVudHMvbmV3L05ld1RhYnMuanN4) | | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | | |
| [superset/models/user\_attributes.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3VzZXJfYXR0cmlidXRlcy5weQ==) | | |
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlTZWFyY2guanN4) | | |
| [...-frontend/src/components/Button/Button.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9CdXR0b24vQnV0dG9uLnN0b3JpZXMuanN4) | | |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvZ2V0RGFzaGJvYXJkRmlsdGVyS2V5LnRz) | | |
| [...d7c1a0d6f2da\_remove\_limit\_used\_from\_query\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9kN2MxYTBkNmYyZGFfcmVtb3ZlX2xpbWl0X3VzZWRfZnJvbV9xdWVyeV9tb2RlbC5weQ==) | | |
| ... and [1218 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...26234eb](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.05%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.55% -4.06%
==========================================
Files 828 833 +5
Lines 39167 39535 +368
Branches 3589 3598 +9
==========================================
- Hits 25694 24334 -1360
- Misses 13361 15019 +1658
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.36%)` | :arrow_up: |
| #python | `60.88% <95.69%> (-0.14%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | `86.48% <0.00%> (-1.82%)` | :arrow_down: |
| [superset/views/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYWxlcnRzLnB5) | `82.97% <0.00%> (-1.44%)` | :arrow_down: |
| [superset/models/alerts.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2FsZXJ0cy5weQ==) | `96.00% <0.00%> (-0.85%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.05% <0.00%> (-0.63%)` | :arrow_down: |
| ... and [893 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...a15f1b1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504857584
##########
File path: superset/databases/commands/export.py
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+import json
+import os.path
+from io import BytesIO
+from typing import Any, Dict
+from zipfile import ZipFile
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.databases.dao import DatabaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize
+
+
+class ExportDatabaseCommand(BaseCommand):
+ def __init__(self, database_id: int, filename: str):
+ self.database_id = database_id
+ self.filename = filename
+
+ def run(self) -> BytesIO:
+ self.validate()
+
+ root = os.path.splitext(self.filename)[0]
+ database = DatabaseDAO.find_by_id(self.database_id)
+ name = sanitize(database.database_name)
+ database_filename = f"{root}/databases/{name}.yaml"
+
+ payload: Dict[Any, Any]
+ payload = database.export_to_dict(
+ recursive=False,
+ include_parent_ref=False,
+ include_defaults=True,
+ export_uuids=True,
+ )
+ if "extra" in payload:
+ try:
+ payload["extra"] = json.loads(payload["extra"])
+ except json.decoder.JSONDecodeError:
+ pass
+
+ payload["version"] = IMPORT_EXPORT_VERSION
+
+ buf = BytesIO()
+ with ZipFile(buf, "w") as bundle:
Review comment:
Right, it's created in memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.46%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 61.13% -4.47%
==========================================
Files 828 833 +5
Lines 39167 39524 +357
Branches 3589 3598 +9
==========================================
- Hits 25694 24164 -1530
- Misses 13361 15178 +1817
- Partials 112 182 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.67% <ø> (+0.36%)` | :arrow_up: |
| #python | `60.23% <95.69%> (-0.80%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [903 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...a15f1b1](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r504867641
##########
File path: superset/databases/commands/export.py
##########
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# isort:skip_file
+
+import json
+import os.path
+from io import BytesIO
+from typing import Any, Dict
+from zipfile import ZipFile
+
+import yaml
+
+from superset.commands.base import BaseCommand
+from superset.databases.commands.exceptions import DatabaseNotFoundError
+from superset.databases.dao import DatabaseDAO
+from superset.utils.dict_import_export import IMPORT_EXPORT_VERSION, sanitize
+
+
+class ExportDatabaseCommand(BaseCommand):
+ def __init__(self, database_id: int, filename: str):
+ self.database_id = database_id
+ self.filename = filename
+
+ def run(self) -> BytesIO:
+ self.validate()
+
+ root = os.path.splitext(self.filename)[0]
+ database = DatabaseDAO.find_by_id(self.database_id)
+ name = sanitize(database.database_name)
+ database_filename = f"{root}/databases/{name}.yaml"
+
+ payload: Dict[Any, Any]
+ payload = database.export_to_dict(
+ recursive=False,
+ include_parent_ref=False,
+ include_defaults=True,
+ export_uuids=True,
+ )
+ if "extra" in payload:
Review comment:
Maybe, but if we change this we also need to change the import path, and I was trying to keep the old export/import path unchanged.
I think once we have the new import/export as the default we can move the logic there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `10.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
===========================================
- Coverage 65.60% 55.28% -10.32%
===========================================
Files 828 404 -424
Lines 39167 13410 -25757
Branches 3589 3392 -197
===========================================
- Hits 25694 7414 -18280
+ Misses 13361 5806 -7555
- Partials 112 190 +78
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.28% <ø> (-0.17%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...dashboard/util/logging/findTopLevelComponentIds.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvbG9nZ2luZy9maW5kVG9wTGV2ZWxDb21wb25lbnRJZHMuanM=) | | |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvUHJvcGVydGllc01vZGFsLmpzeA==) | | |
| [...ations/versions/2e5a0ee25ed4\_refractor\_alerting.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yZTVhMGVlMjVlZDRfcmVmcmFjdG9yX2FsZXJ0aW5nLnB5) | | |
| [superset/examples/deck.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZGVjay5weQ==) | | |
| [...igrations/versions/ad82a75afd82\_add\_query\_model.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9hZDgyYTc1YWZkODJfYWRkX3F1ZXJ5X21vZGVsLnB5) | | |
| [...src/dashboard/components/gridComponents/Column.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2NvbXBvbmVudHMvZ3JpZENvbXBvbmVudHMvQ29sdW1uLmpzeA==) | | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | | |
| [...ions/versions/956a063c52b3\_adjusting\_key\_length.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy85NTZhMDYzYzUyYjNfYWRqdXN0aW5nX2tleV9sZW5ndGgucHk=) | | |
| [...set-frontend/src/explore/components/ControlRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9jb21wb25lbnRzL0NvbnRyb2xSb3cuanN4) | | |
| [...c/visualizations/FilterBox/FilterBoxChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlzdWFsaXphdGlvbnMvRmlsdGVyQm94L0ZpbHRlckJveENoYXJ0UGx1Z2luLmpz) | | |
| ... and [1216 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...3438852](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#issuecomment-706636672
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=h1) Report
> Merging [#11229](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `0.38%`.
> The diff coverage is `95.69%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
==========================================
- Coverage 65.60% 65.21% -0.39%
==========================================
Files 828 833 +5
Lines 39167 39479 +312
Branches 3589 3592 +3
==========================================
+ Hits 25694 25748 +54
- Misses 13361 13622 +261
+ Partials 112 109 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.89% <ø> (+0.44%)` | :arrow_up: |
| #javascript | `62.40% <ø> (+0.10%)` | :arrow_up: |
| #python | `60.25% <95.69%> (-0.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.91% <94.44%> (+0.47%)` | :arrow_up: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.80% <94.73%> (+0.44%)` | :arrow_up: |
| [superset/databases/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.45% <95.45%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `90.62% <100.00%> (ø)` | |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `64.81% <100.00%> (+9.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/views/css\_templates.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY3NzX3RlbXBsYXRlcy5weQ==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| ... and [903 more](https://codecov.io/gh/apache/incubator-superset/pull/11229/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=footer). Last update [b6728d8...0180322](https://codecov.io/gh/apache/incubator-superset/pull/11229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229#discussion_r502853118
##########
File path: superset/views/base_api.py
##########
@@ -127,7 +127,7 @@ class BaseSupersetModelRestApi(ModelRestApi):
"data": "list",
"delete": "delete",
"distinct": "list",
- "export": "mulexport",
+ "export": "list",
Review comment:
@dpgaspar, can you help me with this? I had to change this to `list` in order to make the new export work (in `api/v1/database/${id}/export/`, but then it broke the dataset export.
Is there a way to have `list` for database export, and `mulexport` for dataset export?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #11229: feat: export databases as a ZIP bundle
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #11229:
URL: https://github.com/apache/incubator-superset/pull/11229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org