[GitHub] [skywalking] wu-sheng edited a comment on pull request #6093: Added statement access frequency statistics

[GitBox <gi...@apache.org>]

wu-sheng edited a comment on pull request #6093:
URL: https://github.com/apache/skywalking/pull/6093#issuecomment-751752623


   > High-frequency SQL is also one of the reasons that affect database performance, but the [No statement] shown in my screenshot is not What I care about, this will block the writing of this data in actual use
   
   Let's separate your issues to be clear what need to do.
   1. High-frequency SQL may or may not an issue. How to statistic all SQLs? Some SQLs are very long, we saw 7k length. So, if you want to discuss this deeply, you need to know what is the ID of a SQL. Because statistic is targeting for the entity which requires an ID.
   2. Ignoring `[No statement]` is quite simple. Isn't it? Change the `MultiScopesAnalysisListener` to exclude this case, and provide a configuration.(Ignore could be default, I think).
   3. All things you want to resolve are irrelative with this query. That is why in the open source collaboration, you should discuss first.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org