You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Emilian Bold <em...@protonmail.ch> on 2018/05/01 07:23:05 UTC
(Git) Diff Window horizontal space rescue
Hello,
It seems to me that a lot of horizontal space is wasted by the current Git Diff window which means I get to see fewer and fewer line of source code. And what I really want to see in the diff window is my source code -- I almost never touch any other button other than 'Commit Changes'.
I've already made this PR https://github.com/apache/incubator-netbeans/pull/529 which moves the so-called 'tree selection panel' from its own horizontal component into the toolbar.
This saves about 70 pixels on my machine and I get to see 2 extra lines of source code in the Diff window.
There are two other areas wasting pixels in this window I would like to approach:
* there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
* there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
Of secondary concern I note that:
* at the bottom of the diff component there is a huge border of about 20 pixels that could almost show another line. It's unclear to me why that is there or if it's LnF specific (I'm on macOS).
* the Graphical diff component has a header showing you what you are comparing (HEAD / Modified in working tree). This seems almost redundant given we have the comboboxes in the 'tree selection panel' showing you what you are comparing (although the order is different!). It could also be replaced by something smarter, I'm thinking of a floating, semi-transparent label. Not sure where to put the label showing you the current chunk number (1/10, 2/10, etc).
Let me know your thought. If anybody wants to help, join me!
--emi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Eirik Bakke <eb...@ultorg.com>.
> Closing the frame would dock the contained TopComponent "back".
Ah, not a bad idea! I assume dragging an additional tab into the frame
would make tabs appear again.
On 5/9/18, 6:59 PM, "Emilian Bold" <em...@protonmail.ch> wrote:
>> That would be nice--but how would one dock the TopComponent again if
>>there is no tab to right-click or drag?
>
>Closing the frame would dock the contained TopComponent "back".
>
>> Personally I don't see a reason to change the way undocked top
>> compoents are displayed. I work with netbeans and so I'm either on a
>> large enough laptop screen (15,4 inch) or a dual head setup. In both
>> cases, the overhead for the tab is neglectable.
>
>This might be a tricky thing to implement.
>
>Still -- the whole purpose of this thread is to get rid of all these
>negligible components that keep eating vertical space and leave our users
>see 10 lines for diffs. The classical 80x25 terminal has better
>ergonomics...
>
>Tangentially, I also speculate users generally have a single undocked
>topcomponent floating which means that title tab is redundant.
>
>--emi
>
>------- Original Message -------
>
>On 5 May 2018 12:42 AM, Eirik Bakke <eb...@ultorg.com> wrote:
>
>> That would be nice--but how would one dock the TopComponent again if
>>there is no tab to right-click or drag?
>>
>> On MacOS, there's a "Window.style" client property that can be set to
>>"small", like this:
>>
>> rootPane.putClientProperty("Window.style", "small");
>>
>> (See
>>https://developer.apple.com/library/content/technotes/tn2007/tn2196.html#
>>WINDOWS )
>>
>> This makes the title bar take up much less space, and omits the window
>>title, while still allowing the window to be dragged by its frame,
>>maximized, and such. I use it in my own NetBeans app, for a "filter"
>>widget, seen here: https://pasteboard.co/HjFRlqT.png
>>
>> Unfortunately, no equivalent exists on Windows. It would have to be
>>emulated with a custom-painted undecorated window (which would also have
>>to implement drag-to-resize logic).
>>
>> -- Eirik
>>
>> On 5/4/18, 1:34 PM, "Emilian Bold"
>><em...@protonmail.ch> wrote:
>>
>> I think Chris is mentioning that a floating (editor-) topcomponent
>>still has a tab with the topcomponent title, even if it's the single
>>topcomponent. So, what Chris wants is that if you make the Diff
>>topcomponent floating, only the operating system frame has the title /
>>icon and there's no other tab from the Windows System API.
>>
>> I'm actually wondering myself why there is no Windows System flag for
>>this thing... it seems an obvious need for some topcomponens eg.
>>floating palette window.
>>
>> --emi
>>
>> ------- Original Message -------
>>
>> On 4 May 2018 6:39 PM, Matthias Bläsing
>><mb...@doppel-helix.eu> wrote:
>>
>> Hi,
>>
>> Am Freitag, den 04.05.2018, 14:42 +0000 schrieb Eirik Bakke:
>>
>> > On the other hand, I think the Diff panel should remain a regular
>> >
>> > TopComponent--those can be undocked, full-screened, moved to different
>> >
>> > monitors, and so on. Making it into a Dialog is a step backwards, in
>>my
>> >
>> > opinion. But the internal layout of the diff panel could certainly be
>> >
>> > rearranged to save some space.
>>
>> I aggree with this assessment. Modifying the diff view to be a dialog
>>
>> would be a step backwards.
>>
>> Greetings
>>
>> Matthias
>>
>>
>>
>>-------------------------------------------------------------------------
>>-------------------------------------------------
>>
>> To unsubscribe, e-mail:
>>dev-unsubscribe@netbeans.incubator.apache.orgmailto:dev-unsubscribe@netbe
>>ans.incubator.apache.org
>>
>> For additional commands, e-mail:
>>dev-help@netbeans.incubator.apache.orgmailto:dev-help@netbeans.incubator.
>>apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>>
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>-------------------------------------------------------------------------
>>---------------------------------------------------------------
>>
>> To unsubscribe, e-mail:
>>dev-unsubscribe@netbeans.incubator.apache.orgmailto:dev-unsubscribe@netbe
>>ans.incubator.apache.org
>>
>> For additional commands, e-mail:
>>dev-help@netbeans.incubator.apache.orgmailto:dev-help@netbeans.incubator.
>>apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>>
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
>For further information about the NetBeans mailing lists, visit:
>https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
It was mostly meant to be a reply to Matthias' comment:
> Because you try to force your use-case down my throat.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 14 May 2018 3:29 PM, Neil C Smith <ne...@apache.org> wrote:
> On Thu, 10 May 2018 at 20:20 Emilian Bold emilian.bold@protonmail.ch
>
> wrote:
>
> > This email thread is also a form of brainstorming. I have no problems
> >
> > exploring ideas even if they never get implemented.
> >
> > Starting from my plan of increasing the vertical space available for
> >
> > actual code in the diff top component, several other ideas were explored:
> >
> > - the fact the even if we make the diff topcomponent float, we still waste
> >
> > space with that tab title (unlike IntelliJ).
> >
> >
> > ** then we went into why the Window System doesn't handle this usecase
>
> Was this meant to be in response to my email or not?
>
> Because what I was trying to say is that if we do look to implement this,
>
> it shouldn't be either / or. Having multiple tabs in windows makes sense
>
> for certain things, even on one screen, but definitely on multiple.
>
> Undocking things also makes sense for other things.
>
> So, IMO it shouldn't be a behaviour option setting, it should be two menu
>
> options in the tab menu - eg. open in new window (acts like current float)
>
> and undock (opens as you suggest).
>
> 2c
>
> Best wishes,
>
> Neil
>
>
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Neil C Smith
>
> Artist & Technologist
>
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
> Hmm. Developers who want to do real coding should use real hardware.
>
> <ducks>
>
> Seriously though, there is some minimum screen real-estate we should
>
> design for. iPads and 13" monitors are a non-target in my opinion.
>
> Portability comes at a cost of productivity. People using such devices
>
> should expect as much.
Wasted pixels are wasted pixels. Of course, on a 30" display some waste is much more easily ignored.
I suppose we still stick to these system requirements: https://netbeans.org/community/releases/82/relnotes.html#system_requirements
> Note: The IDE's minimum screen resolution is 1024x768 pixels.
Also note the minimum hardware requirements. An iPad is faster than the 800MHz Intel Pentium III or equivalent with 512 MB RAM we should still run on.
Lots of students and developers have 13" laptops. We should definitively support them.
> I agree with you that we should be collecting usage statistics to help
>
> make such decisions. Can we use old data from netbeans.org?
I assume the old data is still live for a while, until the domain itself is donated to Apache. After that... it's going to be tough.
--emi
>
> Gili
>
> On 2018-05-13 6:49 AM, Emilian Bold wrote:
>
> > Too bad we don't have any statistics about NetBeans usage anymore.
> >
> > I also only use my 15" MacBook Pro without any external display. I briefly used an external display for a Linux VM where I had another NetBeans running :-) So, I never use NetBeans in a true multi-display setup.
> >
> > At least for me, on macOS, the diff window is rather tiny. I can only imagine how tiny it would be if I were to use a 13" MacBook.
> >
> > --emi
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On 13 May 2018 1:33 PM, Christian Lenz christian.lenz@gmx.net wrote:
> >
> > > I think this is a real Problem, not everyone have big enough Monitors. Sure if you are working with a Docking Station, this is Maybe not a big Problem but if you have your Laptop with your, e.g. on a coding session at a conference, then this is a Problem. I can Show you some other Problems with the UI with NetBeans where a small monitor is a pain in the ass, but this is an other Topic.
> > >
> > > Cheers
> > >
> > > Chris
> > >
> > > Von: Emilian Bold
> > >
> > > Gesendet: Donnerstag, 10. Mai 2018 21:20
> > >
> > > An: dev@netbeans.incubator.apache.org
> > >
> > > Betreff: Re: AW: (Git) Diff Window horizontal space rescue
> > >
> > > This email thread is also a form of brainstorming. I have no problems exploring ideas even if they never get implemented.
> > >
> > > Starting from my plan of increasing the vertical space available for actual code in the diff top component, several other ideas were explored:
> > >
> > > - the fact the even if we make the diff topcomponent float, we still waste space with that tab title (unlike IntelliJ).
> > >
> > > ** then we went into why the Window System doesn't handle this usecase
> > >
> > > *** then we went into how this usecase might be implemented and how docking, closing would work
> > >
> > > ***… except it doesn't need to if people would just buy bigger monitors
> > >
> > > - that people end up having multiple diff topcomponents open, even for the same group of files and some re-use might help
> > >
> > > - syncing selection between the git(?) topcomponent and diff
> > >
> > > --emi
> > >
> > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > >
> > > On 10 May 2018 5:20 PM, Neil C Smith neilcsmith@apache.org wrote:
> > >
> > >
> > > > On Thu, 10 May 2018 at 14:25 Emilian Bold emilian.bold@protonmail.ch
> > > >
> > > > wrote:
> > > >
> > > > > Not sure why you have to be so adamant about this.
> > > > >
> > > > > I could add some flag per topcomponent that says 'no-individual-tab'.
> > > > >
> > > > > Then, if I have a floating window holding that single topcomponent it won't
> > > > >
> > > > > have the title bar.
> > > > >
> > > > > Play nice people! ;-)
> > > >
> > > > I actually agree with both of you. I'd be really annoyed if we lost the
> > > >
> > > > current tab behaviour, and yet also would love an option to selectively
> > > >
> > > > open top components in separate windows without any tab support,
> > > >
> > > > particularly within my RCP app rather than IDE.
> > > >
> > > > Is the problem that we conflate two ideas in Float? One is SDI and the
> > > >
> > > > other is MDI across multiple windows. Perhaps we need different options
> > > >
> > > > with Float (or Undock) being single window, and an option more like New
> > > >
> > > > Document Tab Group that opens in a new tab-able window?
> > > >
> > > > But while we only have one option, my vote is on keeping the current
> > > >
> > > > behaviour.
> > > >
> > > > Best wishes,
> > > >
> > > > Neil
> > > >
> > > > Neil C Smith
> > > >
> > > > Artist & Technologist
> > > >
> > > > www.neilcsmith.net
> > > >
> > > > Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
> > > >
> > > > --
> > >
> > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > >
> > > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> > >
> > > For further information about the NetBeans mailing lists, visit:
> > >
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
> --
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: AW: (Git) Diff Window horizontal space rescue
Posted by cowwoc <co...@bbs.darktech.org>.
Hmm. Developers who want to do real coding should use real hardware.
<ducks>
Seriously though, there is some minimum screen real-estate we should
design for. iPads and 13" monitors are a non-target in my opinion.
Portability comes at a cost of productivity. People using such devices
should expect as much.
I agree with you that we should be collecting usage statistics to help
make such decisions. Can we use old data from netbeans.org?
Gili
On 2018-05-13 6:49 AM, Emilian Bold wrote:
> Too bad we don't have any statistics about NetBeans usage anymore.
>
> I also only use my 15" MacBook Pro without any external display. I briefly used an external display for a Linux VM where I had another NetBeans running :-) So, I never use NetBeans in a true multi-display setup.
>
> At least for me, on macOS, the diff window is rather tiny. I can only imagine how tiny it would be if I were to use a 13" MacBook.
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 13 May 2018 1:33 PM, Christian Lenz <ch...@gmx.net> wrote:
>
>> I think this is a real Problem, not everyone have big enough Monitors. Sure if you are working with a Docking Station, this is Maybe not a big Problem but if you have your Laptop with your, e.g. on a coding session at a conference, then this is a Problem. I can Show you some other Problems with the UI with NetBeans where a small monitor is a pain in the ass, but this is an other Topic.
>>
>> Cheers
>>
>> Chris
>>
>> Von: Emilian Bold
>>
>> Gesendet: Donnerstag, 10. Mai 2018 21:20
>>
>> An: dev@netbeans.incubator.apache.org
>>
>> Betreff: Re: AW: (Git) Diff Window horizontal space rescue
>>
>> This email thread is also a form of brainstorming. I have no problems exploring ideas even if they never get implemented.
>>
>> Starting from my plan of increasing the vertical space available for actual code in the diff top component, several other ideas were explored:
>>
>> - the fact the even if we make the diff topcomponent float, we still waste space with that tab title (unlike IntelliJ).
>>
>> ** then we went into why the Window System doesn't handle this usecase
>>
>> *** then we went into how this usecase might be implemented and how docking, closing would work
>>
>> ***… except it doesn't need to if people would just buy bigger monitors
>>
>> - that people end up having multiple diff topcomponents open, even for the same group of files and some re-use might help
>> - syncing selection between the git(?) topcomponent and diff
>>
>> --emi
>>
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>
>> On 10 May 2018 5:20 PM, Neil C Smith neilcsmith@apache.org wrote:
>>
>>
>>> On Thu, 10 May 2018 at 14:25 Emilian Bold emilian.bold@protonmail.ch
>>>
>>> wrote:
>>>
>>>> Not sure why you have to be so adamant about this.
>>>>
>>>> I could add some flag per topcomponent that says 'no-individual-tab'.
>>>>
>>>> Then, if I have a floating window holding that single topcomponent it won't
>>>>
>>>> have the title bar.
>>> Play nice people! ;-)
>>>
>>> I actually agree with both of you. I'd be really annoyed if we lost the
>>>
>>> current tab behaviour, and yet also would love an option to selectively
>>>
>>> open top components in separate windows without any tab support,
>>>
>>> particularly within my RCP app rather than IDE.
>>>
>>> Is the problem that we conflate two ideas in Float? One is SDI and the
>>>
>>> other is MDI across multiple windows. Perhaps we need different options
>>>
>>> with Float (or Undock) being single window, and an option more like New
>>>
>>> Document Tab Group that opens in a new tab-able window?
>>>
>>> But while we only have one option, my vote is on keeping the current
>>>
>>> behaviour.
>>>
>>> Best wishes,
>>>
>>> Neil
>>>
>>> Neil C Smith
>>>
>>> Artist & Technologist
>>>
>>> www.neilcsmith.net
>>>
>>> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
>> --
>>
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>
>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>>
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
Too bad we don't have any statistics about NetBeans usage anymore.
I also only use my 15" MacBook Pro without any external display. I briefly used an external display for a Linux VM where I had another NetBeans running :-) So, I never use NetBeans in a true multi-display setup.
At least for me, on macOS, the diff window is rather tiny. I can only imagine how tiny it would be if I were to use a 13" MacBook.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 13 May 2018 1:33 PM, Christian Lenz <ch...@gmx.net> wrote:
> I think this is a real Problem, not everyone have big enough Monitors. Sure if you are working with a Docking Station, this is Maybe not a big Problem but if you have your Laptop with your, e.g. on a coding session at a conference, then this is a Problem. I can Show you some other Problems with the UI with NetBeans where a small monitor is a pain in the ass, but this is an other Topic.
>
> Cheers
>
> Chris
>
> Von: Emilian Bold
>
> Gesendet: Donnerstag, 10. Mai 2018 21:20
>
> An: dev@netbeans.incubator.apache.org
>
> Betreff: Re: AW: (Git) Diff Window horizontal space rescue
>
> This email thread is also a form of brainstorming. I have no problems exploring ideas even if they never get implemented.
>
> Starting from my plan of increasing the vertical space available for actual code in the diff top component, several other ideas were explored:
>
> - the fact the even if we make the diff topcomponent float, we still waste space with that tab title (unlike IntelliJ).
>
> ** then we went into why the Window System doesn't handle this usecase
>
> *** then we went into how this usecase might be implemented and how docking, closing would work
>
> ***… except it doesn't need to if people would just buy bigger monitors
>
> - that people end up having multiple diff topcomponents open, even for the same group of files and some re-use might help
> - syncing selection between the git(?) topcomponent and diff
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 10 May 2018 5:20 PM, Neil C Smith neilcsmith@apache.org wrote:
>
>
> > On Thu, 10 May 2018 at 14:25 Emilian Bold emilian.bold@protonmail.ch
> >
> > wrote:
> >
> > > Not sure why you have to be so adamant about this.
> > >
> > > I could add some flag per topcomponent that says 'no-individual-tab'.
> > >
> > > Then, if I have a floating window holding that single topcomponent it won't
> > >
> > > have the title bar.
> >
> > Play nice people! ;-)
> >
> > I actually agree with both of you. I'd be really annoyed if we lost the
> >
> > current tab behaviour, and yet also would love an option to selectively
> >
> > open top components in separate windows without any tab support,
> >
> > particularly within my RCP app rather than IDE.
> >
> > Is the problem that we conflate two ideas in Float? One is SDI and the
> >
> > other is MDI across multiple windows. Perhaps we need different options
> >
> > with Float (or Undock) being single window, and an option more like New
> >
> > Document Tab Group that opens in a new tab-able window?
> >
> > But while we only have one option, my vote is on keeping the current
> >
> > behaviour.
> >
> > Best wishes,
> >
> > Neil
> >
> > Neil C Smith
> >
> > Artist & Technologist
> >
> > www.neilcsmith.net
> >
> > Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
>
> --
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
AW: AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
Yes, I meant Output, not Options.
Von: Neil C Smith
Gesendet: Montag, 14. Mai 2018 14:49
An: dev@netbeans.incubator.apache.org
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
On Mon, 14 May 2018 at 13:37 Christian Lenz <ch...@gmx.net> wrote:
> Why couldn’t it be handled as the Options window e.g.? If there is only
> one running Task, there is no tab, but if you have mulitple running Tasks,
> you have tabs, which you can close. So If we want to have multiple tabs in
> one undocked window, this could make sense in my opinion.
>
Matthias kind of covered this earlier. Think you meant Output window?
That doesn't really have to handle docking, grouping, dragging etc. in the
same way (they're just plain tabs). I'd be interested in a UI example that
does manage all that without tabs.
Firefox and Chrome handle tabs / windows in the two ways I described AFAIK,
although neither offer the fully undocked without additional plugin? Mind
you, current NB behaviour is somewhat in between, in that the new window
does not have menu and toolbar.
Best wishes,
Neil
--
Neil C Smith
Artist & Technologist
www.neilcsmith.net
Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Neil C Smith <ne...@apache.org>.
On Mon, 14 May 2018 at 13:37 Christian Lenz <ch...@gmx.net> wrote:
> Why couldn’t it be handled as the Options window e.g.? If there is only
> one running Task, there is no tab, but if you have mulitple running Tasks,
> you have tabs, which you can close. So If we want to have multiple tabs in
> one undocked window, this could make sense in my opinion.
>
Matthias kind of covered this earlier. Think you meant Output window?
That doesn't really have to handle docking, grouping, dragging etc. in the
same way (they're just plain tabs). I'd be interested in a UI example that
does manage all that without tabs.
Firefox and Chrome handle tabs / windows in the two ways I described AFAIK,
although neither offer the fully undocked without additional plugin? Mind
you, current NB behaviour is somewhat in between, in that the new window
does not have menu and toolbar.
Best wishes,
Neil
--
Neil C Smith
Artist & Technologist
www.neilcsmith.net
Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
AW: AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
Why couldn’t it be handled as the Options window e.g.? If there is only one running Task, there is no tab, but if you have mulitple running Tasks, you have tabs, which you can close. So If we want to have multiple tabs in one undocked window, this could make sense in my opinion.
Cheers
Chris
Von: Neil C Smith
Gesendet: Montag, 14. Mai 2018 14:29
An: dev@netbeans.incubator.apache.org; Emilian Bold
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
On Thu, 10 May 2018 at 20:20 Emilian Bold <em...@protonmail.ch>
wrote:
> This email thread is also a form of brainstorming. I have no problems
> exploring ideas even if they never get implemented.
>
> Starting from my plan of increasing the vertical space available for
> actual code in the diff top component, several other ideas were explored:
>
> * the fact the even if we make the diff topcomponent float, we still waste
> space with that tab title (unlike IntelliJ).
>
> ** then we went into why the Window System doesn't handle this usecase
>
Was this meant to be in response to my email or not?
Because what I was trying to say is that if we do look to implement this,
it shouldn't be either / or. Having multiple tabs in windows makes sense
for certain things, even on one screen, but definitely on multiple.
Undocking things also makes sense for other things.
So, IMO it shouldn't be a behaviour option setting, it should be two menu
options in the tab menu - eg. open in new window (acts like current float)
and undock (opens as you suggest).
2c
Best wishes,
Neil
--
Neil C Smith
Artist & Technologist
www.neilcsmith.net
Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Neil C Smith <ne...@apache.org>.
On Thu, 10 May 2018 at 20:20 Emilian Bold <em...@protonmail.ch>
wrote:
> This email thread is also a form of brainstorming. I have no problems
> exploring ideas even if they never get implemented.
>
> Starting from my plan of increasing the vertical space available for
> actual code in the diff top component, several other ideas were explored:
>
> * the fact the even if we make the diff topcomponent float, we still waste
> space with that tab title (unlike IntelliJ).
>
> ** then we went into why the Window System doesn't handle this usecase
>
Was this meant to be in response to my email or not?
Because what I was trying to say is that if we do look to implement this,
it shouldn't be either / or. Having multiple tabs in windows makes sense
for certain things, even on one screen, but definitely on multiple.
Undocking things also makes sense for other things.
So, IMO it shouldn't be a behaviour option setting, it should be two menu
options in the tab menu - eg. open in new window (acts like current float)
and undock (opens as you suggest).
2c
Best wishes,
Neil
--
Neil C Smith
Artist & Technologist
www.neilcsmith.net
Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
AW: AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
Great,
only wanted to Rescue the other suggestions like textual/graphical to make a Checkbox and Checkbox for hide the files and remove the tab etc.
Cheers
Chris
Von: Eirik Bakke
Gesendet: Freitag, 7. September 2018 17:06
An: dev@netbeans.incubator.apache.org
Betreff: RE: AW: (Git) Diff Window horizontal space rescue
On the topic of saving space, I have implemented a patch for https://issues.apache.org/jira/browse/NETBEANS-731 , which hides the menu bar in full screen mode (while letting the user still access it by moving the mouse to the top of the screen). This is standard behavior on MacOS, but not on other platforms.
I'll be testing it for a few days in my own IDE before submitting a pull request.
-- Eirik
-----Original Message-----
From: Christian Lenz <ch...@gmx.net>
Sent: Friday, September 7, 2018 7:16 AM
To: dev@netbeans.incubator.apache.org
Subject: AW: AW: (Git) Diff Window horizontal space rescue
Hey Emilian,
what is the Progress of this Task? I tried NB 9.0 and it is only that you moved the 2 drop downs (diff: Dropdown to: Dropdown) to the lines with the icons. But what About the other suggestions?
Cheers
Chris
Von: Christian Lenz
Gesendet: Sonntag, 13. Mai 2018 12:33
An: dev@netbeans.incubator.apache.org; Emilian Bold
Betreff: AW: AW: (Git) Diff Window horizontal space rescue
I think this is a real Problem, not everyone have big enough Monitors. Sure if you are working with a Docking Station, this is Maybe not a big Problem but if you have your Laptop with your, e.g. on a coding session at a conference, then this is a Problem. I can Show you some other Problems with the UI with NetBeans where a small monitor is a pain in the ass, but this is an other Topic.
Cheers
Chris
Von: Emilian Bold
Gesendet: Donnerstag, 10. Mai 2018 21:20
An: dev@netbeans.incubator.apache.org
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
This email thread is also a form of brainstorming. I have no problems exploring ideas even if they never get implemented.
Starting from my plan of increasing the vertical space available for actual code in the diff top component, several other ideas were explored:
* the fact the even if we make the diff topcomponent float, we still waste space with that tab title (unlike IntelliJ).
** then we went into why the Window System doesn't handle this usecase
*** then we went into how this usecase might be implemented and how docking, closing would work
***… except it doesn't need to if people would just buy bigger monitors
* that people end up having multiple diff topcomponents open, even for the same group of files and some re-use might help
* syncing selection between the git(?) topcomponent and diff
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 10 May 2018 5:20 PM, Neil C Smith <ne...@apache.org> wrote:
> On Thu, 10 May 2018 at 14:25 Emilian Bold emilian.bold@protonmail.ch
>
> wrote:
>
> > Not sure why you have to be so adamant about this.
> >
> > I could add some flag per topcomponent that says 'no-individual-tab'.
> >
> > Then, if I have a floating window holding that single topcomponent it won't
> >
> > have the title bar.
>
> Play nice people! ;-)
>
> I actually agree with both of you. I'd be really annoyed if we lost the
>
> current tab behaviour, and yet also would love an option to selectively
>
> open top components in separate windows without any tab support,
>
> particularly within my RCP app rather than IDE.
>
> Is the problem that we conflate two ideas in Float? One is SDI and the
>
> other is MDI across multiple windows. Perhaps we need different options
>
> with Float (or Undock) being single window, and an option more like New
>
> Document Tab Group that opens in a new tab-able window?
>
> But while we only have one option, my vote is on keeping the current
>
> behaviour.
>
> Best wishes,
>
> Neil
>
>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Neil C Smith
>
> Artist & Technologist
>
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
RE: AW: (Git) Diff Window horizontal space rescue
Posted by Eirik Bakke <eb...@ultorg.com>.
On the topic of saving space, I have implemented a patch for https://issues.apache.org/jira/browse/NETBEANS-731 , which hides the menu bar in full screen mode (while letting the user still access it by moving the mouse to the top of the screen). This is standard behavior on MacOS, but not on other platforms.
I'll be testing it for a few days in my own IDE before submitting a pull request.
-- Eirik
-----Original Message-----
From: Christian Lenz <ch...@gmx.net>
Sent: Friday, September 7, 2018 7:16 AM
To: dev@netbeans.incubator.apache.org
Subject: AW: AW: (Git) Diff Window horizontal space rescue
Hey Emilian,
what is the Progress of this Task? I tried NB 9.0 and it is only that you moved the 2 drop downs (diff: Dropdown to: Dropdown) to the lines with the icons. But what About the other suggestions?
Cheers
Chris
Von: Christian Lenz
Gesendet: Sonntag, 13. Mai 2018 12:33
An: dev@netbeans.incubator.apache.org; Emilian Bold
Betreff: AW: AW: (Git) Diff Window horizontal space rescue
I think this is a real Problem, not everyone have big enough Monitors. Sure if you are working with a Docking Station, this is Maybe not a big Problem but if you have your Laptop with your, e.g. on a coding session at a conference, then this is a Problem. I can Show you some other Problems with the UI with NetBeans where a small monitor is a pain in the ass, but this is an other Topic.
Cheers
Chris
Von: Emilian Bold
Gesendet: Donnerstag, 10. Mai 2018 21:20
An: dev@netbeans.incubator.apache.org
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
This email thread is also a form of brainstorming. I have no problems exploring ideas even if they never get implemented.
Starting from my plan of increasing the vertical space available for actual code in the diff top component, several other ideas were explored:
* the fact the even if we make the diff topcomponent float, we still waste space with that tab title (unlike IntelliJ).
** then we went into why the Window System doesn't handle this usecase
*** then we went into how this usecase might be implemented and how docking, closing would work
***… except it doesn't need to if people would just buy bigger monitors
* that people end up having multiple diff topcomponents open, even for the same group of files and some re-use might help
* syncing selection between the git(?) topcomponent and diff
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 10 May 2018 5:20 PM, Neil C Smith <ne...@apache.org> wrote:
> On Thu, 10 May 2018 at 14:25 Emilian Bold emilian.bold@protonmail.ch
>
> wrote:
>
> > Not sure why you have to be so adamant about this.
> >
> > I could add some flag per topcomponent that says 'no-individual-tab'.
> >
> > Then, if I have a floating window holding that single topcomponent it won't
> >
> > have the title bar.
>
> Play nice people! ;-)
>
> I actually agree with both of you. I'd be really annoyed if we lost the
>
> current tab behaviour, and yet also would love an option to selectively
>
> open top components in separate windows without any tab support,
>
> particularly within my RCP app rather than IDE.
>
> Is the problem that we conflate two ideas in Float? One is SDI and the
>
> other is MDI across multiple windows. Perhaps we need different options
>
> with Float (or Undock) being single window, and an option more like New
>
> Document Tab Group that opens in a new tab-able window?
>
> But while we only have one option, my vote is on keeping the current
>
> behaviour.
>
> Best wishes,
>
> Neil
>
>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Neil C Smith
>
> Artist & Technologist
>
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
AW: AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
Hey Emilian,
what is the Progress of this Task? I tried NB 9.0 and it is only that you moved the 2 drop downs (diff: Dropdown to: Dropdown) to the lines with the icons. But what About the other suggestions?
Cheers
Chris
Von: Christian Lenz
Gesendet: Sonntag, 13. Mai 2018 12:33
An: dev@netbeans.incubator.apache.org; Emilian Bold
Betreff: AW: AW: (Git) Diff Window horizontal space rescue
I think this is a real Problem, not everyone have big enough Monitors. Sure if you are working with a Docking Station, this is Maybe not a big Problem but if you have your Laptop with your, e.g. on a coding session at a conference, then this is a Problem. I can Show you some other Problems with the UI with NetBeans where a small monitor is a pain in the ass, but this is an other Topic.
Cheers
Chris
Von: Emilian Bold
Gesendet: Donnerstag, 10. Mai 2018 21:20
An: dev@netbeans.incubator.apache.org
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
This email thread is also a form of brainstorming. I have no problems exploring ideas even if they never get implemented.
Starting from my plan of increasing the vertical space available for actual code in the diff top component, several other ideas were explored:
* the fact the even if we make the diff topcomponent float, we still waste space with that tab title (unlike IntelliJ).
** then we went into why the Window System doesn't handle this usecase
*** then we went into how this usecase might be implemented and how docking, closing would work
***… except it doesn't need to if people would just buy bigger monitors
* that people end up having multiple diff topcomponents open, even for the same group of files and some re-use might help
* syncing selection between the git(?) topcomponent and diff
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 10 May 2018 5:20 PM, Neil C Smith <ne...@apache.org> wrote:
> On Thu, 10 May 2018 at 14:25 Emilian Bold emilian.bold@protonmail.ch
>
> wrote:
>
> > Not sure why you have to be so adamant about this.
> >
> > I could add some flag per topcomponent that says 'no-individual-tab'.
> >
> > Then, if I have a floating window holding that single topcomponent it won't
> >
> > have the title bar.
>
> Play nice people! ;-)
>
> I actually agree with both of you. I'd be really annoyed if we lost the
>
> current tab behaviour, and yet also would love an option to selectively
>
> open top components in separate windows without any tab support,
>
> particularly within my RCP app rather than IDE.
>
> Is the problem that we conflate two ideas in Float? One is SDI and the
>
> other is MDI across multiple windows. Perhaps we need different options
>
> with Float (or Undock) being single window, and an option more like New
>
> Document Tab Group that opens in a new tab-able window?
>
> But while we only have one option, my vote is on keeping the current
>
> behaviour.
>
> Best wishes,
>
> Neil
>
>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Neil C Smith
>
> Artist & Technologist
>
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
AW: AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
I think this is a real Problem, not everyone have big enough Monitors. Sure if you are working with a Docking Station, this is Maybe not a big Problem but if you have your Laptop with your, e.g. on a coding session at a conference, then this is a Problem. I can Show you some other Problems with the UI with NetBeans where a small monitor is a pain in the ass, but this is an other Topic.
Cheers
Chris
Von: Emilian Bold
Gesendet: Donnerstag, 10. Mai 2018 21:20
An: dev@netbeans.incubator.apache.org
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
This email thread is also a form of brainstorming. I have no problems exploring ideas even if they never get implemented.
Starting from my plan of increasing the vertical space available for actual code in the diff top component, several other ideas were explored:
* the fact the even if we make the diff topcomponent float, we still waste space with that tab title (unlike IntelliJ).
** then we went into why the Window System doesn't handle this usecase
*** then we went into how this usecase might be implemented and how docking, closing would work
***… except it doesn't need to if people would just buy bigger monitors
* that people end up having multiple diff topcomponents open, even for the same group of files and some re-use might help
* syncing selection between the git(?) topcomponent and diff
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 10 May 2018 5:20 PM, Neil C Smith <ne...@apache.org> wrote:
> On Thu, 10 May 2018 at 14:25 Emilian Bold emilian.bold@protonmail.ch
>
> wrote:
>
> > Not sure why you have to be so adamant about this.
> >
> > I could add some flag per topcomponent that says 'no-individual-tab'.
> >
> > Then, if I have a floating window holding that single topcomponent it won't
> >
> > have the title bar.
>
> Play nice people! ;-)
>
> I actually agree with both of you. I'd be really annoyed if we lost the
>
> current tab behaviour, and yet also would love an option to selectively
>
> open top components in separate windows without any tab support,
>
> particularly within my RCP app rather than IDE.
>
> Is the problem that we conflate two ideas in Float? One is SDI and the
>
> other is MDI across multiple windows. Perhaps we need different options
>
> with Float (or Undock) being single window, and an option more like New
>
> Document Tab Group that opens in a new tab-able window?
>
> But while we only have one option, my vote is on keeping the current
>
> behaviour.
>
> Best wishes,
>
> Neil
>
>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Neil C Smith
>
> Artist & Technologist
>
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
This email thread is also a form of brainstorming. I have no problems exploring ideas even if they never get implemented.
Starting from my plan of increasing the vertical space available for actual code in the diff top component, several other ideas were explored:
* the fact the even if we make the diff topcomponent float, we still waste space with that tab title (unlike IntelliJ).
** then we went into why the Window System doesn't handle this usecase
*** then we went into how this usecase might be implemented and how docking, closing would work
***… except it doesn't need to if people would just buy bigger monitors
* that people end up having multiple diff topcomponents open, even for the same group of files and some re-use might help
* syncing selection between the git(?) topcomponent and diff
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 10 May 2018 5:20 PM, Neil C Smith <ne...@apache.org> wrote:
> On Thu, 10 May 2018 at 14:25 Emilian Bold emilian.bold@protonmail.ch
>
> wrote:
>
> > Not sure why you have to be so adamant about this.
> >
> > I could add some flag per topcomponent that says 'no-individual-tab'.
> >
> > Then, if I have a floating window holding that single topcomponent it won't
> >
> > have the title bar.
>
> Play nice people! ;-)
>
> I actually agree with both of you. I'd be really annoyed if we lost the
>
> current tab behaviour, and yet also would love an option to selectively
>
> open top components in separate windows without any tab support,
>
> particularly within my RCP app rather than IDE.
>
> Is the problem that we conflate two ideas in Float? One is SDI and the
>
> other is MDI across multiple windows. Perhaps we need different options
>
> with Float (or Undock) being single window, and an option more like New
>
> Document Tab Group that opens in a new tab-able window?
>
> But while we only have one option, my vote is on keeping the current
>
> behaviour.
>
> Best wishes,
>
> Neil
>
>
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Neil C Smith
>
> Artist & Technologist
>
> www.neilcsmith.net
>
> Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Neil C Smith <ne...@apache.org>.
On Thu, 10 May 2018 at 14:25 Emilian Bold <em...@protonmail.ch>
wrote:
> Not sure why you have to be so adamant about this.
>
> I could add some flag per topcomponent that says 'no-individual-tab'.
> Then, if I have a floating window holding that single topcomponent it won't
> have the title bar.
>
Play nice people! ;-)
I actually agree with both of you. I'd be really annoyed if we lost the
current tab behaviour, and yet also would love an option to selectively
open top components in separate windows without any tab support,
particularly within my RCP app rather than IDE.
Is the problem that we conflate two ideas in Float? One is SDI and the
other is MDI across multiple windows. Perhaps we need different options
with Float (or Undock) being single window, and an option more like New
Document Tab Group that opens in a new tab-able window?
But while we only have one option, my vote is on keeping the current
behaviour.
Best wishes,
Neil
--
Neil C Smith
Artist & Technologist
www.neilcsmith.net
Praxis LIVE - hybrid visual IDE for creative coding - www.praxislive.org
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Peter Steele <st...@gmail.com>.
If there are configurable options to change it why do you care? You can
just keep the settings how you like it and you will be happy. From what I
read in the chain it sounds like this was a suggestion a while back.
On Thu, 10 May 2018, 15:17 Matthias Bläsing, <mb...@doppel-helix.eu>
wrote:
> Am Donnerstag, den 10.05.2018, 09:25 -0400 schrieb Emilian Bold:
> > Not sure why you have to be so adamant about this.
>
> Because you try to force your use-case down my throat. Yes I choose my
> hardware to get my work done and this worked good with netbeans. All I
> heard till now torpedes this. This is why I'm speaking out against it.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Am Donnerstag, den 10.05.2018, 09:25 -0400 schrieb Emilian Bold:
> Not sure why you have to be so adamant about this.
Because you try to force your use-case down my throat. Yes I choose my
hardware to get my work done and this worked good with netbeans. All I
heard till now torpedes this. This is why I'm speaking out against it.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
Not sure why you have to be so adamant about this.
I could add some flag per topcomponent that says 'no-individual-tab'. Then, if I have a floating window holding that single topcomponent it won't have the title bar.
For people that need or are used to the old style we could have a checkbox in options to 'always show a tab title'.
Depending on that flag, the closing behaviour would also change.
So, it's not something that disruptive.
>You plan to optimize for the peep-hole case and I argue, that it is the
> personal decision of the user to suffer from small screen real-estate.
:-)
I guess we also have to update the hardware system requirements of NetBeans and mention large screen real-estates.
> In any-case this should be:
>
> a) well planned and
> b) configurable
I kinda disagree with both.
The Window system API is not a gift from the gods. It's a glorified multi-split-pane which has some primitive drag and drop support.
So, I don't believe things have to be so well planned and I believe users would gladly enable and *enjoy* experimental features.
Also, design is about decisions too. We don't have to provide a configuration for everything under the Sun. We could just drop some old behaviour. People seem to use Gnome without that tab, they will use NetBeans just as well.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 10 May 2018 3:49 PM, Matthias Bläsing <mb...@doppel-helix.eu> wrote:
> Am Mittwoch, den 09.05.2018, 18:59 -0400 schrieb Emilian Bold:
>
> > > That would be nice--but how would one dock the TopComponent again
> > >
> > > if there is no tab to right-click or drag?
> >
> > Closing the frame would dock the contained TopComponent "back".
>
> This breaks current behaviour where closing the window closes all
>
> contained TopComponents. (This would reduce usability for me).
>
> You will also loose the ability to group multiple floating windows
>
> together, as you are loosing the drag-handle for the TC. (again for me
>
> usability will suffer).
>
> > > Personally I don't see a reason to change the way undocked top
> > >
> > > compoents are displayed. I work with netbeans and so I'm either on a
> > >
> > > large enough laptop screen (15,4 inch) or a dual head setup. In both
> > >
> > > cases, the overhead for the tab is neglectable.
> >
> > This might be a tricky thing to implement.
> >
> > Still -- the whole purpose of this thread is to get rid of all these
> >
> > negligible components that keep eating vertical space and leave our
> >
> > users see 10 lines for diffs. The classical 80x25 terminal has better
> >
> > ergonomics...
> >
> > Tangentially, I also speculate users generally have a single undocked
> >
> > topcomponent floating which means that title tab is redundant.
>
> I gave the counter example and the tab serves as a drag-handle and
>
> drop-zone for grouping. Gnome Terminal shows the problems - it shows
>
> the "tabs" only when at least two tabs are present. If you want to
>
> merge two windows into one window with two tabs. So the "optimization"
>
> to hide tabs "when not needed" breaks another use-case. Sorry this
>
> "usabily of 80x25 terminal is better" reference does not cut it.
>
> You plan to optimize for the peep-hole case and I argue, that it is the
>
> personal decision of the user to suffer from small screen real-estate.
>
> In any-case this should be:
>
> a) well planned and
>
> b) configurable
>
> Greetings
>
> Matthias
>
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Am Mittwoch, den 09.05.2018, 18:59 -0400 schrieb Emilian Bold:
> > That would be nice--but how would one dock the TopComponent again
> > if there is no tab to right-click or drag?
>
> Closing the frame would dock the contained TopComponent "back".
This breaks current behaviour where closing the window closes all
contained TopComponents. (This would reduce usability for me).
You will also loose the ability to group multiple floating windows
together, as you are loosing the drag-handle for the TC. (again for me
usability will suffer).
>
> > Personally I don't see a reason to change the way undocked top
> > compoents are displayed. I work with netbeans and so I'm either on a
> > large enough laptop screen (15,4 inch) or a dual head setup. In both
> > cases, the overhead for the tab is neglectable.
>
> This might be a tricky thing to implement.
>
> Still -- the whole purpose of this thread is to get rid of all these
> negligible components that keep eating vertical space and leave our
> users see 10 lines for diffs. The classical 80x25 terminal has better
> ergonomics...
>
> Tangentially, I also speculate users generally have a single undocked
> topcomponent floating which means that title tab is redundant.
>
I gave the counter example and the tab serves as a drag-handle and
drop-zone for grouping. Gnome Terminal shows the problems - it shows
the "tabs" only when at least two tabs are present. If you want to
merge two windows into one window with two tabs. So the "optimization"
to hide tabs "when not needed" breaks another use-case. Sorry this
"usabily of 80x25 terminal is better" reference does not cut it.
You plan to optimize for the peep-hole case and I argue, that it is the
personal decision of the user to suffer from small screen real-estate.
In any-case this should be:
a) well planned and
b) configurable
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
> That would be nice--but how would one dock the TopComponent again if there is no tab to right-click or drag?
Closing the frame would dock the contained TopComponent "back".
> Personally I don't see a reason to change the way undocked top
> compoents are displayed. I work with netbeans and so I'm either on a
> large enough laptop screen (15,4 inch) or a dual head setup. In both
> cases, the overhead for the tab is neglectable.
This might be a tricky thing to implement.
Still -- the whole purpose of this thread is to get rid of all these negligible components that keep eating vertical space and leave our users see 10 lines for diffs. The classical 80x25 terminal has better ergonomics...
Tangentially, I also speculate users generally have a single undocked topcomponent floating which means that title tab is redundant.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 5 May 2018 12:42 AM, Eirik Bakke <eb...@ultorg.com> wrote:
> That would be nice--but how would one dock the TopComponent again if there is no tab to right-click or drag?
>
> On MacOS, there's a "Window.style" client property that can be set to "small", like this:
>
> rootPane.putClientProperty("Window.style", "small");
>
> (See https://developer.apple.com/library/content/technotes/tn2007/tn2196.html#WINDOWS )
>
> This makes the title bar take up much less space, and omits the window title, while still allowing the window to be dragged by its frame, maximized, and such. I use it in my own NetBeans app, for a "filter" widget, seen here: https://pasteboard.co/HjFRlqT.png
>
> Unfortunately, no equivalent exists on Windows. It would have to be emulated with a custom-painted undecorated window (which would also have to implement drag-to-resize logic).
>
> -- Eirik
>
> On 5/4/18, 1:34 PM, "Emilian Bold" <em...@protonmail.ch> wrote:
>
> I think Chris is mentioning that a floating (editor-) topcomponent still has a tab with the topcomponent title, even if it's the single topcomponent. So, what Chris wants is that if you make the Diff topcomponent floating, only the operating system frame has the title / icon and there's no other tab from the Windows System API.
>
> I'm actually wondering myself why there is no Windows System flag for this thing... it seems an obvious need for some topcomponens eg. floating palette window.
>
> --emi
>
> ------- Original Message -------
>
> On 4 May 2018 6:39 PM, Matthias Bläsing <mb...@doppel-helix.eu> wrote:
>
> Hi,
>
> Am Freitag, den 04.05.2018, 14:42 +0000 schrieb Eirik Bakke:
>
> > On the other hand, I think the Diff panel should remain a regular
> >
> > TopComponent--those can be undocked, full-screened, moved to different
> >
> > monitors, and so on. Making it into a Dialog is a step backwards, in my
> >
> > opinion. But the internal layout of the diff panel could certainly be
> >
> > rearranged to save some space.
>
> I aggree with this assessment. Modifying the diff view to be a dialog
>
> would be a step backwards.
>
> Greetings
>
> Matthias
>
>
> --------------------------------------------------------------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.orgmailto:dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.orgmailto:dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.orgmailto:dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.orgmailto:dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
Am Freitag, den 04.05.2018, 21:42 +0000 schrieb Eirik Bakke:
> That would be nice--but how would one dock the TopComponent again if
> there is no tab to right-click or drag?
at this time I'm pretty happy with the way netbeans handles docking.
There are already customizations possible for floating windows. These
can be found in the options dialog:
Appearance -> Windows
Personally I don't see a reason to change the way undocked top
compoents are displayed. I work with netbeans and so I'm either on a
large enough laptop screen (15,4 inch) or a dual head setup. In both
cases, the overhead for the tab is neglectable.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Eirik Bakke <eb...@ultorg.com>.
That would be nice--but how would one dock the TopComponent again if there is no tab to right-click or drag?
On MacOS, there's a "Window.style" client property that can be set to "small", like this:
rootPane.putClientProperty("Window.style", "small");
(See https://developer.apple.com/library/content/technotes/tn2007/tn2196.html#WINDOWS )
This makes the title bar take up much less space, and omits the window title, while still allowing the window to be dragged by its frame, maximized, and such. I use it in my own NetBeans app, for a "filter" widget, seen here: https://pasteboard.co/HjFRlqT.png
Unfortunately, no equivalent exists on Windows. It would have to be emulated with a custom-painted undecorated window (which would also have to implement drag-to-resize logic).
-- Eirik
On 5/4/18, 1:34 PM, "Emilian Bold" <em...@protonmail.ch>> wrote:
I think Chris is mentioning that a floating (editor-) topcomponent still has a tab with the topcomponent title, even if it's the single topcomponent. So, what Chris wants is that if you make the Diff topcomponent floating, only the operating system frame has the title / icon and there's no other tab from the Windows System API.
I'm actually wondering myself why there is no Windows System flag for this thing... it seems an obvious need for some topcomponens eg. floating palette window.
--emi
------- Original Message -------
On 4 May 2018 6:39 PM, Matthias Bläsing <mb...@doppel-helix.eu>> wrote:
Hi,
Am Freitag, den 04.05.2018, 14:42 +0000 schrieb Eirik Bakke:
> On the other hand, I think the Diff panel should remain a regular
>
> TopComponent--those can be undocked, full-screened, moved to different
>
> monitors, and so on. Making it into a Dialog is a step backwards, in my
>
> opinion. But the internal layout of the diff panel could certainly be
>
> rearranged to save some space.
I aggree with this assessment. Modifying the diff view to be a dialog
would be a step backwards.
Greetings
Matthias
--------------------------------------------------------------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org<ma...@netbeans.incubator.apache.org>
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org<ma...@netbeans.incubator.apache.org>
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org<ma...@netbeans.incubator.apache.org>
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org<ma...@netbeans.incubator.apache.org>
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
I think Chris is mentioning that a floating (editor-) topcomponent still has a tab with the topcomponent title, even if it's the single topcomponent. So, what Chris wants is that if you make the Diff topcomponent floating, only the operating system frame has the title / icon and there's no other tab from the Windows System API.
I'm actually wondering myself why there is no Windows System flag for this thing... it seems an obvious need for some topcomponens eg. floating palette window.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 4 May 2018 6:39 PM, Matthias Bläsing <mb...@doppel-helix.eu> wrote:
> Hi,
>
> Am Freitag, den 04.05.2018, 14:42 +0000 schrieb Eirik Bakke:
>
> > On the other hand, I think the Diff panel should remain a regular
> >
> > TopComponent--those can be undocked, full-screened, moved to different
> >
> > monitors, and so on. Making it into a Dialog is a step backwards, in my
> >
> > opinion. But the internal layout of the diff panel could certainly be
> >
> > rearranged to save some space.
>
> I aggree with this assessment. Modifying the diff view to be a dialog
>
> would be a step backwards.
>
> Greetings
>
> Matthias
>
>
> --------------------------------------------------------------------------------------------------------------------------
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
AW: AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
Then it can be as it is 😃. The thing is we can save even more space, if it will be not handled as a tab, as you can see it in my screenshot. Now it has a tab, which is odd and the left and Right Icon and the full screen or not. This is not needed.
Von: Matthias Bläsing
Gesendet: Freitag, 4. Mai 2018 17:39
An: dev@netbeans.incubator.apache.org
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
Hi,
Am Freitag, den 04.05.2018, 14:42 +0000 schrieb Eirik Bakke:
> On the other hand, I think the Diff panel should remain a regular
> TopComponent--those can be undocked, full-screened, moved to different
> monitors, and so on. Making it into a Dialog is a step backwards, in my
> opinion. But the internal layout of the diff panel could certainly be
> rearranged to save some space.
I aggree with this assessment. Modifying the diff view to be a dialog
would be a step backwards.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
Am Freitag, den 04.05.2018, 14:42 +0000 schrieb Eirik Bakke:
> On the other hand, I think the Diff panel should remain a regular
> TopComponent--those can be undocked, full-screened, moved to different
> monitors, and so on. Making it into a Dialog is a step backwards, in my
> opinion. But the internal layout of the diff panel could certainly be
> rearranged to save some space.
I aggree with this assessment. Modifying the diff view to be a dialog
would be a step backwards.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Eirik Bakke <eb...@ultorg.com>.
I agree with Emi to avoid adding options for everything.
On the other hand, I think the Diff panel should remain a regular
TopComponent--those can be undocked, full-screened, moved to different
monitors, and so on. Making it into a Dialog is a step backwards, in my
opinion. But the internal layout of the diff panel could certainly be
rearranged to save some space.
-- Eirik
On 5/4/18, 6:18 AM, "Emilian Bold" <em...@protonmail.ch> wrote:
>> +1 separate window
>> I'd like to also suggest having the separate window track selection
>>events
>in the windows that generated it so that you only have one window up.
>
>Interesting idea. This would only really be handy for a multi-monitor
>setup imho.
>
>> As we see some discussion like, we want a separate Dialog and some
>>doesn¹t
>> want it, we Need an Option for changing this. Because I¹m also for using
>> the separated window. So Default should be as it is, as a tab Maybe and
>> with anoption, we can switch to a more lightweight (w/o the tab stuff
>> inside etc.). So please don¹t decide to do it only in one way. We have
>> multiple situations for that. To fix the most for all, use an Option to
>>let
>> the user decide how to use it.
>
>At some point a decision has to be made. We cannot just add options for
>everything because each case has to be supported and this increases the
>complexity.
>
>--emi
>
>------- Original Message -------
>
>On 4 May 2018 11:11 AM, Peter Steele <st...@gmail.com> wrote:
>
>> +1 separate window
>>
>> I'd like to also suggest having the separate window track selection
>>events
>>
>> in the windows that generated it so that you only have one window up. An
>>
>> example of this would be the commit window, clicking of different files
>>
>> would load the diff for that file and changing the selection would
>>
>> automatically update the same window with the diff from the new file.
>>
>> On Fri, 4 May 2018, 09:05 Christian Lenz, christian.lenz@gmx.net wrote:
>>
>> > As we see some discussion like, we want a separate Dialog and some
>>doesn¹t
>> >
>> > want it, we Need an Option for changing this. Because I¹m also for
>>using
>> >
>> > the separated window. So Default should be as it is, as a tab Maybe
>>and
>> >
>> > with anoption, we can switch to a more lightweight (w/o the tab stuff
>> >
>> > inside etc.). So please don¹t decide to do it only in one way. We have
>> >
>> > multiple situations for that. To fix the most for all, use an Option
>>to let
>> >
>> > the user decide how to use it.
>> >
>> > Cheers
>> >
>> > Chris
>> >
>> > Von: cowwoc
>> >
>> > Gesendet: Donnerstag, 3. Mai 2018 17:53
>> >
>> > An: dev@netbeans.incubator.apache.org
>> >
>> > Betreff: Re: AW: (Git) Diff Window horizontal space rescue
>> >
>> > I'd be okay with "reuse diff topcomponent for identical diff". It
>>seems
>> >
>> > like a reasonable default seeing as opening the same source file in
>>the
>> >
>> > editor reuses the same tab. It would be consistent.
>> >
>> > Gili
>> >
>> > On 2018-05-03 6:07 AM, Sven Reimers wrote:
>> >
>> > > Hi,
>> > >
>> > > idea for solving this via configuration:
>> > >
>> > > - reuse diff topcomponent
>> > > - reuse diff topcomponent for identical diff
>> > >
>> > > I like the simple navigation between topcomponents, but having the
>>same
>> > >
>> > > diff open multiple times is annoying.
>> > >
>> > > Sven
>> > >
>> > > John McDonnell mcdonnell.john@gmail.com schrieb am Do., 3. Mai 2018,
>> > >
>> > > 08:18:
>> > >
>> > > > I'd be the same as you Emilian, I often end up with multiple
>> > > >
>> > > > editor windows of the same diff, which is annoying. Maybe a
>>separate
>> > > >
>> > > > dialog makes
>> > > >
>> > > > sense?
>> > > >
>> > > > Could this be a preference thing? I.e. allow this as an editor
>> > > >
>> > > > component
>> > >
>> > > > or as a separate dialog? or is that a lot of effort?
>> > > >
>> > > > John
>> > > >
>> > > > On 3 May 2018 at 03:14, cowwoc cowwoc@bbs.darktech.org wrote:
>> > > >
>> > > > > Multiple diffs, probably not. But I don't like IDEA-style
>>separate
>> > > > >
>> > > > > dialog.
>> > > > >
>> > > > > I like being able to treat the diff as just another editor tab
>>so I can
>> > > > >
>> > > > > casually move back and forth between it and the code.
>> > > > >
>> > > > > Gili
>> > > > >
>> > > > > On 2018-05-02 9:25 PM, Emilian Bold wrote:
>> > > > >
>> > > > > > Now that you mention it, there is something odd about the
>>diff window
>> > > > > >
>> > > > > > being another editor-like topcomponent.
>> > > > > >
>> > > > > > I sometimes find myself having the same diff open multiple
>>times
>> > > > > >
>> > > > > > (generally after I've excluded some file manually in the Git
>>bottom
>> > > > > >
>> > > > > > topcomponent).
>> > > > > >
>> > > > > > So, do people really need multiple diffs open at once?
>>Because it's
>> > > > > >
>> > > > > > starting to make sense having this as a separate dialog.
>> > > > > >
>> > > > > > --emi
>> > > > > >
>> > > > > > ------- Original Message -------
>> > > > > >
>> > > > > > On 2 May 2018 2:39 PM, Christian Lenz christian.lenz@gmx.net
>>wrote:
>> > > > > >
>> > > > > > As I compared it with intelliJ e.g. (only to see how intelliJ
>>does it)
>> > > > > >
>> > > > > > > they open the diff window as a standalone window to remove
>>everything
>> > > > > > >
>> > > > > > > which
>> > > > >
>> > > > > > > is not needed. NetBeans only opens that diff for a file as
>>a new tab.
>> > > > > > >
>> > > > > > > Sure
>> > > > >
>> > > > > > > you can make it floatable by your own but it is not a file,
>>so it
>> > > > > > >
>> > > > > > > could be
>> > > > >
>> > > > > > > treated as a separate window which can be floatable via
>>Option (not
>> > > > > > >
>> > > > > > > as
>> > >
>> > > > > > > Default, because it could be disturbing some other users).
>>So I like
>> > > > > > >
>> > > > > > > the
>> > > > >
>> > > > > > > Approach to get more space. Maybe the drop downs can be
>>placed close
>> > > > > > >
>> > > > > > > to the
>> > > > >
>> > > > > > > Icons, in the same line. If this make sense. See my
>>screenshot how
>> > > > > > >
>> > > > > > > WebStorm
>> > > > >
>> > > > > > > handles this: https://ibb.co/jV9YW7 Only as an idea.
>> > > > > > >
>> > > > > > > It doesn¹t Need the tab section and the other Icons. I
>>added a secion
>> > > > > > >
>> > > > > > > screenshot: https://ibb.co/bsLe4S Here you can see, what I
>>mean. The
>> > > > > > >
>> > > > > > > red section is not needed in my opinion. So we can remove
>>it w/o
>> > > > > > >
>> > > > > > > having an
>> > > > >
>> > > > > > > Option for this. And the blue section should be optional and
>> > > > > > >
>> > > > > > > redesigned as
>> > > > >
>> > > > > > > Emilian said (textual/visual via DropDown e.g.)
>> > > > > > >
>> > > > > > > Cheers
>> > > > > > >
>> > > > > > > Chris
>> > > > > > >
>> > > > > > > Von: Emilian Bold
>> > > > > > >
>> > > > > > > Gesendet: Mittwoch, 2. Mai 2018 07:35
>> > > > > > >
>> > > > > > > An: dev@netbeans.incubator.apache.org
>> > > > > > >
>> > > > > > > Betreff: Re: (Git) Diff Window horizontal space rescue
>> > > > > > >
>> > > > > > > I wonder if it would be a good intermediate solution to just
>> > > > > > >
>> > > > > > > introduce
>> > >
>> > > > a
>> > > >
>> > > > > > > > System property that disables the enhanced flag in
>> > > > > > > >
>> > > > > > > > DefaultDiffControllerProvider. Then users can just gain
>>some more
>> > > > > > > >
>> > > > > > > > pixels by
>> > > > >
>> > > > > > > > editing the .conf file.
>> > > > > > >
>> > > > > > > Createdhttps://github.com/apache/incubator-netbeans/pull/531
>> > > > > > >
>> > > > > > > With both PRs I get to see 32 lines of code for the diff vs
>>28 lines
>> > > > > > >
>> > > > > > > of
>> > >
>> > > > > > > code previously.
>> > > > > > >
>> > > > > > > This becomes even more important when I have the Output
>>window open:
>> > > > > > >
>> > > > > > > I
>> > >
>> > > > > > > get to see 18 vs 14 lines of code!
>> > > > > > >
>> > > > > > > --emi
>> > > > > > >
>> > > > > > > ------- Original Message -------
>> > > > > > >
>> > > > > > > On 2 May 2018 7:46 AM, Emilian Bold
>>emilian.bold@protonmail.ch
>> > > > > > >
>> > > > > > > wrote:
>> > >
>> > > > > > > - there is a table with all the files being diff-ed (even
>>if it's a
>> > > > > > >
>> > > > > > > > > single file!) and there is no way to reduce that space
>>to zero, you
>> > > > > > > > >
>> > > > > > > > > always
>> > > > >
>> > > > > > > > > see some part of that split pane and the split pane
>>divider itself.
>> > > > > > > > >
>> > > > > > > > > I want
>> > > > >
>> > > > > > > > > to add another action button in the toolbar (next to
>>'Display
>> > > > > > > > >
>> > > > > > > > > results as a
>> > > > >
>> > > > > > > > > tree') that hides that whole chunk.
>> > > > > > > >
>> > > > > > > > This seems to be rather tricky because there is a lot of
>>state to
>> > > > > > > >
>> > > > > > > > manage in MultiDiffPanel.
>> > > > > > > >
>> > > > > > > > See the current patch https://github.com/emilianbold
>> > > > > > > >
>> > > > > > > >
>>/incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158
>> > > > > > > >
>> > > > > > > > which does not have functioning next/prev actions when
>>the file list
>> > > > > > > >
>> > > > > > > > is
>> > > > >
>> > > > > > > > hidden. I'm also calling refreshNodes because the UI was
>>off when
>> > > > > > > >
>> > > > > > > > re-adding
>> > > > >
>> > > > > > > > the split pane (probably something with the selected node
>>in the
>> > > > > > > >
>> > > > > > > > file
>> > >
>> > > > list
>> > > >
>> > > > > > > > too...)
>> > > > > > > >
>> > > > > > > > - there is a tabbed pane which shows Graphical /
>>Textual diffs and
>> > > > > > > >
>> > > > > > > > > the tab buttons take considerable space too. Generally,
>>I just want
>> > > > > > > > >
>> > > > > > > > > to see
>> > > > >
>> > > > > > > > > the graphical diff so I believe it would be nice to
>>replace this
>> > > > > > > > >
>> > > > > > > > > with a
>> > > > >
>> > > > > > > > > combobox sitting in the toolbar too.
>> > > > > > > >
>> > > > > > > > This is caused by the EditableDiffView.enhancedView flag.
>> > > > > > > >
>> > > > > > > > I find the whole API of
>> > > > > > > >
>> > > > > > > > DiffControllerProvider.createEnhancedDiffController
>> > > > >
>> > > > > > > > vs createDiffController odd. Generally we use services
>>and location
>> > > > > > > >
>> > > > > > > > to
>> > >
>> > > > > > > > replace a weaker service with an enhanced one.
>> > > > > > > >
>> > > > > > > > It's also unclear to me why EditableDiffView needs to be
>>'enhanced'
>> > > > > > > >
>> > > > > > > > and
>> > > > >
>> > > > > > > > show two tabs. When we could have 2 separate providers
>>(one for the
>> > > > > > > >
>> > > > > > > > graphical and one for the textual diff) and create the
>>tabbed pane
>> > > > > > > >
>> > > > > > > > ourselves. Then, we could even allow the user to disable
>>one of
>> > > > > > > >
>> > > > > > > > these
>> > >
>> > > > > > > > services (eg, the textual one) and then show no tabbed
>>pane if there
>> > > > > > > >
>> > > > > > > > is a
>> > > > >
>> > > > > > > > single service.
>> > > > > > > >
>> > > > > > > > Also interesting that we have DiffView.getToolbar() which
>>might be a
>> > > > > > > >
>> > > > > > > > way to provide a combobox with Graphical/Textual from
>> > > > > > > >
>> > > > > > > > EditableDiffView but
>> > > > >
>> > > > > > > > this method doesn't seem to be used by the Git module.
>>(Note how the
>> > > > > > > >
>> > > > > > > > whole
>> > > > >
>> > > > > > > > idea of an enhanced view that only has a toolbar seems
>>redundant.)
>> > > > > > > >
>> > > > > > > > I wonder if it would be a good intermediate solution to
>>just
>> > > > > > > >
>> > > > > > > > introduce
>> > >
>> > > > > > > > a System property that disables the enhanced flag in
>> > > > > > > >
>> > > > > > > > DefaultDiffControllerProvider. Then users can just gain
>>some more
>> > > > > > > >
>> > > > > > > > pixels by
>> > > > >
>> > > > > > > > editing the .conf file.
>> > > > > > > >
>> > > > > > > > --emi
>> > > > > > > >
>> > > > > > > > ------- Original Message -------
>> > > > > > > >
>> > > > > > > > On 1 May 2018 10:23 AM, Emilian Bold
>>emilian.bold@protonmail.ch
>> > > > > > > >
>> > > > > > > > wrote:
>> > > > >
>> > > > > > > > Hello,
>> > > > > > > >
>> > > > > > > > > It seems to me that a lot of horizontal space is wasted
>>by the
>> > > > > > > > >
>> > > > > > > > > current
>> > > > >
>> > > > > > > > > Git Diff window which means I get to see fewer and
>>fewer line of
>> > > > > > > > >
>> > > > > > > > > source
>> > > > >
>> > > > > > > > > code. And what I really want to see in the diff window
>>is my source
>> > > > > > > > >
>> > > > > > > > > code --
>> > > > >
>> > > > > > > > > I almost never touch any other button other than
>>'Commit Changes'.
>> > > > > > > > >
>> > > > > > > > > I've already made this PR https://github.com/apache/incu
>> > > > > > > > >
>> > > > > > > > > bator-netbeans/pull/529 which moves the so-called 'tree
>>selection
>> > > > > > > > >
>> > > > > > > > > panel' from its own horizontal component into the
>>toolbar.
>> > > > > > > > >
>> > > > > > > > > This saves about 70 pixels on my machine and I get to
>>see 2 extra
>> > > > > > > > >
>> > > > > > > > > lines of source code in the Diff window.
>> > > > > > > > >
>> > > > > > > > > There are two other areas wasting pixels in this window
>>I would
>> > > > > > > > >
>> > > > > > > > > like
>> > >
>> > > > > > > > > to approach:
>> > > > > > > > >
>> > > > > > > > > - there is a table with all the files being diff-ed
>>(even if
>> > > > > > > > >
>> > > > > > > > > it's a
>> > > > > > > > >
>> > >
>> > > > > > > > > single file!) and there is no way to reduce that space
>>to zero, you
>> > > > > > > > >
>> > > > > > > > > always
>> > > > >
>> > > > > > > > > see some part of that split pane and the split pane
>>divider itself.
>> > > > > > > > >
>> > > > > > > > > I want
>> > > > >
>> > > > > > > > > to add another action button in the toolbar (next to
>>'Display
>> > > > > > > > >
>> > > > > > > > > results as a
>> > > > >
>> > > > > > > > > tree') that hides that whole chunk.
>> > > > > > > > >
>> > > > > > > > > - there is a tabbed pane which shows Graphical / Textual
>> > > > > > > > >
>> > > > > > > > > diffs
>> > >
>> > > > > > > > > and the tab buttons take considerable space too.
>>Generally, I just
>> > > > > > > > >
>> > > > > > > > > want to
>> > > > >
>> > > > > > > > > see the graphical diff so I believe it would be nice to
>>replace
>> > > > > > > > >
>> > > > > > > > > this
>> > >
>> > > > with a
>> > > >
>> > > > > > > > > combobox sitting in the toolbar too.
>> > > > > > > > >
>> > > > > > > > > Of secondary concern I note that:
>> > > > > > > > >
>> > > > > > > > > - at the bottom of the diff component there is a huge
>> > > > > > > > >
>> > > > > > > > > border
>> > >
>> > > > of
>> > > >
>> > > > > > > > > about 20 pixels that could almost show another line.
>>It's unclear
>> > > > > > > > >
>> > > > > > > > > to
>> > >
>> > > > me why
>> > > >
>> > > > > > > > > that is there or if it's LnF specific (I'm on macOS).
>> > > > > > > > >
>> > > > > > > > > - the Graphical diff component has a header showing you
>> > > > > > > > >
>> > > > > > > > > what
>> > >
>> > > > > > > > > you are comparing (HEAD / Modified in working tree).
>>This seems
>> > > > > > > > >
>> > > > > > > > > almost
>> > > > >
>> > > > > > > > > redundant given we have the comboboxes in the 'tree
>>selection
>> > > > > > > > >
>> > > > > > > > > panel'
>> > >
>> > > > > > > > > showing you what you are comparing (although the order
>>is
>> > > > > > > > >
>> > > > > > > > > different!). It
>> > > > >
>> > > > > > > > > could also be replaced by something smarter, I'm
>>thinking of a
>> > > > > > > > >
>> > > > > > > > > floating,
>> > > > >
>> > > > > > > > > semi-transparent label. Not sure where to put the label
>>showing you
>> > > > > > > > >
>> > > > > > > > > the
>> > > > >
>> > > > > > > > > current chunk number (1/10, 2/10, etc).
>> > > > > > > > >
>> > > > > > > > > Let me know your thought. If anybody wants to help, join
>> > > > > > > > >
>> > > > > > > > > me!
>> > > > >
>> > > > > > > > > --emi
>> > > > > > > > >
>> > > > > > > > >
>> > > > > > > > > To unsubscribe, e-mail:
>> > > > > > > > >
>> > > > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
>> > > > >
>> > > > > > > > > For additional commands, e-mail:
>>dev-help@netbeans.incubator.ap
>> > > > > > > > >
>> > > > > > > > > ache.org
>> > > > > > > > >
>> > > > > > > > > For further information about the NetBeans mailing
>>lists, visit:
>> > > > > > > > >
>> > > > > > > > >
>>https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>> > > > > > > >
>> > > > > > > > --
>> > > > > > > >
>> > > > > > > > To unsubscribe, e-mail:
>> > > > > > > >
>> > > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
>> > >
>> > > > > > > > For additional commands, e-mail:
>> > > > > > > >
>> > > > > > > > dev-help@netbeans.incubator.apache.org
>> > > > >
>> > > > > > > > For further information about the NetBeans mailing lists,
>>visit:
>> > > > > > > >
>> > > > > > > >
>>https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>> > > > > > >
>> > > > > > > --
>> > > > > > >
>> > > > > > > To unsubscribe, e-mail:
>> > > > > > >
>> > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
>> > >
>> > > > > > > For additional commands, e-mail:
>> > > > > > >
>> > > > > > > dev-help@netbeans.incubator.apache.org
>> > > > >
>> > > > > > > For further information about the NetBeans mailing lists,
>>visit:
>> > > > > > >
>> > > > > > >
>>https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>> > > > > >
>> > > > > > To unsubscribe, e-mail:
>>dev-unsubscribe@netbeans.incubator.apache.org
>> > > > > >
>> > > > > > For additional commands, e-mail:
>> > > > > >
>> > > > > > dev-help@netbeans.incubator.apache.org
>> > >
>> > > > > > For further information about the NetBeans mailing lists,
>>visit:
>> > > > > >
>> > > > > >
>>https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>> > > > >
>> > > > > To unsubscribe, e-mail:
>>dev-unsubscribe@netbeans.incubator.apache.org
>> > > > >
>> > > > > For additional commands, e-mail:
>> > > > >
>> > > > > dev-help@netbeans.incubator.apache.org
>> > >
>> > > > > For further information about the NetBeans mailing lists, visit:
>> > > > >
>> > > > >
>>https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>> >
>> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>> >
>> > For additional commands, e-mail:
>>dev-help@netbeans.incubator.apache.org
>> >
>> > For further information about the NetBeans mailing lists, visit:
>> >
>> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
>For further information about the NetBeans mailing lists, visit:
>https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
AW: AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
Not each case, only 1 or two, the biggest ones. If not, someone will create a new ticket and say hey please add the diff Dialog as a new tab and not separate. You can create Defaults to everything. Options are really usefull for a lot of cases. NetBeans has only a few Options. VS Code, VS or JetBrain IDEs have a lot of Options to customize what ever the user want. So you think so, me think so and an other think so. So atm we have separate the window or not. Please don’t make it Default. Make an Option to make it separate or not. That is the Outcome atm.
Cheers
Chris
Von: Emilian Bold
Gesendet: Freitag, 4. Mai 2018 12:18
An: dev@netbeans.incubator.apache.org
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
> +1 separate window
> I'd like to also suggest having the separate window track selection events
in the windows that generated it so that you only have one window up.
Interesting idea. This would only really be handy for a multi-monitor setup imho.
> As we see some discussion like, we want a separate Dialog and some doesn’t
> want it, we Need an Option for changing this. Because I’m also for using
> the separated window. So Default should be as it is, as a tab Maybe and
> with anoption, we can switch to a more lightweight (w/o the tab stuff
> inside etc.). So please don’t decide to do it only in one way. We have
> multiple situations for that. To fix the most for all, use an Option to let
> the user decide how to use it.
At some point a decision has to be made. We cannot just add options for everything because each case has to be supported and this increases the complexity.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 4 May 2018 11:11 AM, Peter Steele <st...@gmail.com> wrote:
> +1 separate window
>
> I'd like to also suggest having the separate window track selection events
>
> in the windows that generated it so that you only have one window up. An
>
> example of this would be the commit window, clicking of different files
>
> would load the diff for that file and changing the selection would
>
> automatically update the same window with the diff from the new file.
>
> On Fri, 4 May 2018, 09:05 Christian Lenz, christian.lenz@gmx.net wrote:
>
> > As we see some discussion like, we want a separate Dialog and some doesn’t
> >
> > want it, we Need an Option for changing this. Because I’m also for using
> >
> > the separated window. So Default should be as it is, as a tab Maybe and
> >
> > with anoption, we can switch to a more lightweight (w/o the tab stuff
> >
> > inside etc.). So please don’t decide to do it only in one way. We have
> >
> > multiple situations for that. To fix the most for all, use an Option to let
> >
> > the user decide how to use it.
> >
> > Cheers
> >
> > Chris
> >
> > Von: cowwoc
> >
> > Gesendet: Donnerstag, 3. Mai 2018 17:53
> >
> > An: dev@netbeans.incubator.apache.org
> >
> > Betreff: Re: AW: (Git) Diff Window horizontal space rescue
> >
> > I'd be okay with "reuse diff topcomponent for identical diff". It seems
> >
> > like a reasonable default seeing as opening the same source file in the
> >
> > editor reuses the same tab. It would be consistent.
> >
> > Gili
> >
> > On 2018-05-03 6:07 AM, Sven Reimers wrote:
> >
> > > Hi,
> > >
> > > idea for solving this via configuration:
> > >
> > > - reuse diff topcomponent
> > > - reuse diff topcomponent for identical diff
> > >
> > > I like the simple navigation between topcomponents, but having the same
> > >
> > > diff open multiple times is annoying.
> > >
> > > Sven
> > >
> > > John McDonnell mcdonnell.john@gmail.com schrieb am Do., 3. Mai 2018,
> > >
> > > 08:18:
> > >
> > > > I'd be the same as you Emilian, I often end up with multiple
> > > >
> > > > editor windows of the same diff, which is annoying. Maybe a separate
> > > >
> > > > dialog makes
> > > >
> > > > sense?
> > > >
> > > > Could this be a preference thing? I.e. allow this as an editor
> > > >
> > > > component
> > >
> > > > or as a separate dialog? or is that a lot of effort?
> > > >
> > > > John
> > > >
> > > > On 3 May 2018 at 03:14, cowwoc cowwoc@bbs.darktech.org wrote:
> > > >
> > > > > Multiple diffs, probably not. But I don't like IDEA-style separate
> > > > >
> > > > > dialog.
> > > > >
> > > > > I like being able to treat the diff as just another editor tab so I can
> > > > >
> > > > > casually move back and forth between it and the code.
> > > > >
> > > > > Gili
> > > > >
> > > > > On 2018-05-02 9:25 PM, Emilian Bold wrote:
> > > > >
> > > > > > Now that you mention it, there is something odd about the diff window
> > > > > >
> > > > > > being another editor-like topcomponent.
> > > > > >
> > > > > > I sometimes find myself having the same diff open multiple times
> > > > > >
> > > > > > (generally after I've excluded some file manually in the Git bottom
> > > > > >
> > > > > > topcomponent).
> > > > > >
> > > > > > So, do people really need multiple diffs open at once? Because it's
> > > > > >
> > > > > > starting to make sense having this as a separate dialog.
> > > > > >
> > > > > > --emi
> > > > > >
> > > > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > > > >
> > > > > > On 2 May 2018 2:39 PM, Christian Lenz christian.lenz@gmx.net wrote:
> > > > > >
> > > > > > As I compared it with intelliJ e.g. (only to see how intelliJ does it)
> > > > > >
> > > > > > > they open the diff window as a standalone window to remove everything
> > > > > > >
> > > > > > > which
> > > > >
> > > > > > > is not needed. NetBeans only opens that diff for a file as a new tab.
> > > > > > >
> > > > > > > Sure
> > > > >
> > > > > > > you can make it floatable by your own but it is not a file, so it
> > > > > > >
> > > > > > > could be
> > > > >
> > > > > > > treated as a separate window which can be floatable via Option (not
> > > > > > >
> > > > > > > as
> > >
> > > > > > > Default, because it could be disturbing some other users). So I like
> > > > > > >
> > > > > > > the
> > > > >
> > > > > > > Approach to get more space. Maybe the drop downs can be placed close
> > > > > > >
> > > > > > > to the
> > > > >
> > > > > > > Icons, in the same line. If this make sense. See my screenshot how
> > > > > > >
> > > > > > > WebStorm
> > > > >
> > > > > > > handles this: https://ibb.co/jV9YW7 Only as an idea.
> > > > > > >
> > > > > > > It doesn’t Need the tab section and the other Icons. I added a secion
> > > > > > >
> > > > > > > screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The
> > > > > > >
> > > > > > > red section is not needed in my opinion. So we can remove it w/o
> > > > > > >
> > > > > > > having an
> > > > >
> > > > > > > Option for this. And the blue section should be optional and
> > > > > > >
> > > > > > > redesigned as
> > > > >
> > > > > > > Emilian said (textual/visual via DropDown e.g.)
> > > > > > >
> > > > > > > Cheers
> > > > > > >
> > > > > > > Chris
> > > > > > >
> > > > > > > Von: Emilian Bold
> > > > > > >
> > > > > > > Gesendet: Mittwoch, 2. Mai 2018 07:35
> > > > > > >
> > > > > > > An: dev@netbeans.incubator.apache.org
> > > > > > >
> > > > > > > Betreff: Re: (Git) Diff Window horizontal space rescue
> > > > > > >
> > > > > > > I wonder if it would be a good intermediate solution to just
> > > > > > >
> > > > > > > introduce
> > >
> > > > a
> > > >
> > > > > > > > System property that disables the enhanced flag in
> > > > > > > >
> > > > > > > > DefaultDiffControllerProvider. Then users can just gain some more
> > > > > > > >
> > > > > > > > pixels by
> > > > >
> > > > > > > > editing the .conf file.
> > > > > > >
> > > > > > > Createdhttps://github.com/apache/incubator-netbeans/pull/531
> > > > > > >
> > > > > > > With both PRs I get to see 32 lines of code for the diff vs 28 lines
> > > > > > >
> > > > > > > of
> > >
> > > > > > > code previously.
> > > > > > >
> > > > > > > This becomes even more important when I have the Output window open:
> > > > > > >
> > > > > > > I
> > >
> > > > > > > get to see 18 vs 14 lines of code!
> > > > > > >
> > > > > > > --emi
> > > > > > >
> > > > > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > > > > >
> > > > > > > On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch
> > > > > > >
> > > > > > > wrote:
> > >
> > > > > > > - there is a table with all the files being diff-ed (even if it's a
> > > > > > >
> > > > > > > > > single file!) and there is no way to reduce that space to zero, you
> > > > > > > > >
> > > > > > > > > always
> > > > >
> > > > > > > > > see some part of that split pane and the split pane divider itself.
> > > > > > > > >
> > > > > > > > > I want
> > > > >
> > > > > > > > > to add another action button in the toolbar (next to 'Display
> > > > > > > > >
> > > > > > > > > results as a
> > > > >
> > > > > > > > > tree') that hides that whole chunk.
> > > > > > > >
> > > > > > > > This seems to be rather tricky because there is a lot of state to
> > > > > > > >
> > > > > > > > manage in MultiDiffPanel.
> > > > > > > >
> > > > > > > > See the current patch https://github.com/emilianbold
> > > > > > > >
> > > > > > > > /incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158
> > > > > > > >
> > > > > > > > which does not have functioning next/prev actions when the file list
> > > > > > > >
> > > > > > > > is
> > > > >
> > > > > > > > hidden. I'm also calling refreshNodes because the UI was off when
> > > > > > > >
> > > > > > > > re-adding
> > > > >
> > > > > > > > the split pane (probably something with the selected node in the
> > > > > > > >
> > > > > > > > file
> > >
> > > > list
> > > >
> > > > > > > > too...)
> > > > > > > >
> > > > > > > > - there is a tabbed pane which shows Graphical / Textual diffs and
> > > > > > > >
> > > > > > > > > the tab buttons take considerable space too. Generally, I just want
> > > > > > > > >
> > > > > > > > > to see
> > > > >
> > > > > > > > > the graphical diff so I believe it would be nice to replace this
> > > > > > > > >
> > > > > > > > > with a
> > > > >
> > > > > > > > > combobox sitting in the toolbar too.
> > > > > > > >
> > > > > > > > This is caused by the EditableDiffView.enhancedView flag.
> > > > > > > >
> > > > > > > > I find the whole API of
> > > > > > > >
> > > > > > > > DiffControllerProvider.createEnhancedDiffController
> > > > >
> > > > > > > > vs createDiffController odd. Generally we use services and location
> > > > > > > >
> > > > > > > > to
> > >
> > > > > > > > replace a weaker service with an enhanced one.
> > > > > > > >
> > > > > > > > It's also unclear to me why EditableDiffView needs to be 'enhanced'
> > > > > > > >
> > > > > > > > and
> > > > >
> > > > > > > > show two tabs. When we could have 2 separate providers (one for the
> > > > > > > >
> > > > > > > > graphical and one for the textual diff) and create the tabbed pane
> > > > > > > >
> > > > > > > > ourselves. Then, we could even allow the user to disable one of
> > > > > > > >
> > > > > > > > these
> > >
> > > > > > > > services (eg, the textual one) and then show no tabbed pane if there
> > > > > > > >
> > > > > > > > is a
> > > > >
> > > > > > > > single service.
> > > > > > > >
> > > > > > > > Also interesting that we have DiffView.getToolbar() which might be a
> > > > > > > >
> > > > > > > > way to provide a combobox with Graphical/Textual from
> > > > > > > >
> > > > > > > > EditableDiffView but
> > > > >
> > > > > > > > this method doesn't seem to be used by the Git module. (Note how the
> > > > > > > >
> > > > > > > > whole
> > > > >
> > > > > > > > idea of an enhanced view that only has a toolbar seems redundant.)
> > > > > > > >
> > > > > > > > I wonder if it would be a good intermediate solution to just
> > > > > > > >
> > > > > > > > introduce
> > >
> > > > > > > > a System property that disables the enhanced flag in
> > > > > > > >
> > > > > > > > DefaultDiffControllerProvider. Then users can just gain some more
> > > > > > > >
> > > > > > > > pixels by
> > > > >
> > > > > > > > editing the .conf file.
> > > > > > > >
> > > > > > > > --emi
> > > > > > > >
> > > > > > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > > > > > >
> > > > > > > > On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch
> > > > > > > >
> > > > > > > > wrote:
> > > > >
> > > > > > > > Hello,
> > > > > > > >
> > > > > > > > > It seems to me that a lot of horizontal space is wasted by the
> > > > > > > > >
> > > > > > > > > current
> > > > >
> > > > > > > > > Git Diff window which means I get to see fewer and fewer line of
> > > > > > > > >
> > > > > > > > > source
> > > > >
> > > > > > > > > code. And what I really want to see in the diff window is my source
> > > > > > > > >
> > > > > > > > > code --
> > > > >
> > > > > > > > > I almost never touch any other button other than 'Commit Changes'.
> > > > > > > > >
> > > > > > > > > I've already made this PR https://github.com/apache/incu
> > > > > > > > >
> > > > > > > > > bator-netbeans/pull/529 which moves the so-called 'tree selection
> > > > > > > > >
> > > > > > > > > panel' from its own horizontal component into the toolbar.
> > > > > > > > >
> > > > > > > > > This saves about 70 pixels on my machine and I get to see 2 extra
> > > > > > > > >
> > > > > > > > > lines of source code in the Diff window.
> > > > > > > > >
> > > > > > > > > There are two other areas wasting pixels in this window I would
> > > > > > > > >
> > > > > > > > > like
> > >
> > > > > > > > > to approach:
> > > > > > > > >
> > > > > > > > > - there is a table with all the files being diff-ed (even if
> > > > > > > > >
> > > > > > > > > it's a
> > > > > > > > >
> > >
> > > > > > > > > single file!) and there is no way to reduce that space to zero, you
> > > > > > > > >
> > > > > > > > > always
> > > > >
> > > > > > > > > see some part of that split pane and the split pane divider itself.
> > > > > > > > >
> > > > > > > > > I want
> > > > >
> > > > > > > > > to add another action button in the toolbar (next to 'Display
> > > > > > > > >
> > > > > > > > > results as a
> > > > >
> > > > > > > > > tree') that hides that whole chunk.
> > > > > > > > >
> > > > > > > > > - there is a tabbed pane which shows Graphical / Textual
> > > > > > > > >
> > > > > > > > > diffs
> > >
> > > > > > > > > and the tab buttons take considerable space too. Generally, I just
> > > > > > > > >
> > > > > > > > > want to
> > > > >
> > > > > > > > > see the graphical diff so I believe it would be nice to replace
> > > > > > > > >
> > > > > > > > > this
> > >
> > > > with a
> > > >
> > > > > > > > > combobox sitting in the toolbar too.
> > > > > > > > >
> > > > > > > > > Of secondary concern I note that:
> > > > > > > > >
> > > > > > > > > - at the bottom of the diff component there is a huge
> > > > > > > > >
> > > > > > > > > border
> > >
> > > > of
> > > >
> > > > > > > > > about 20 pixels that could almost show another line. It's unclear
> > > > > > > > >
> > > > > > > > > to
> > >
> > > > me why
> > > >
> > > > > > > > > that is there or if it's LnF specific (I'm on macOS).
> > > > > > > > >
> > > > > > > > > - the Graphical diff component has a header showing you
> > > > > > > > >
> > > > > > > > > what
> > >
> > > > > > > > > you are comparing (HEAD / Modified in working tree). This seems
> > > > > > > > >
> > > > > > > > > almost
> > > > >
> > > > > > > > > redundant given we have the comboboxes in the 'tree selection
> > > > > > > > >
> > > > > > > > > panel'
> > >
> > > > > > > > > showing you what you are comparing (although the order is
> > > > > > > > >
> > > > > > > > > different!). It
> > > > >
> > > > > > > > > could also be replaced by something smarter, I'm thinking of a
> > > > > > > > >
> > > > > > > > > floating,
> > > > >
> > > > > > > > > semi-transparent label. Not sure where to put the label showing you
> > > > > > > > >
> > > > > > > > > the
> > > > >
> > > > > > > > > current chunk number (1/10, 2/10, etc).
> > > > > > > > >
> > > > > > > > > Let me know your thought. If anybody wants to help, join
> > > > > > > > >
> > > > > > > > > me!
> > > > >
> > > > > > > > > --emi
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > To unsubscribe, e-mail:
> > > > > > > > >
> > > > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
> > > > >
> > > > > > > > > For additional commands, e-mail: dev-help@netbeans.incubator.ap
> > > > > > > > >
> > > > > > > > > ache.org
> > > > > > > > >
> > > > > > > > > For further information about the NetBeans mailing lists, visit:
> > > > > > > > >
> > > > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > > > > > >
> > > > > > > > --
> > > > > > > >
> > > > > > > > To unsubscribe, e-mail:
> > > > > > > >
> > > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
> > >
> > > > > > > > For additional commands, e-mail:
> > > > > > > >
> > > > > > > > dev-help@netbeans.incubator.apache.org
> > > > >
> > > > > > > > For further information about the NetBeans mailing lists, visit:
> > > > > > > >
> > > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > > > > >
> > > > > > > --
> > > > > > >
> > > > > > > To unsubscribe, e-mail:
> > > > > > >
> > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
> > >
> > > > > > > For additional commands, e-mail:
> > > > > > >
> > > > > > > dev-help@netbeans.incubator.apache.org
> > > > >
> > > > > > > For further information about the NetBeans mailing lists, visit:
> > > > > > >
> > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > > > >
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > > > > >
> > > > > > For additional commands, e-mail:
> > > > > >
> > > > > > dev-help@netbeans.incubator.apache.org
> > >
> > > > > > For further information about the NetBeans mailing lists, visit:
> > > > > >
> > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > > >
> > > > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > > > >
> > > > > For additional commands, e-mail:
> > > > >
> > > > > dev-help@netbeans.incubator.apache.org
> > >
> > > > > For further information about the NetBeans mailing lists, visit:
> > > > >
> > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
> +1 separate window
> I'd like to also suggest having the separate window track selection events
in the windows that generated it so that you only have one window up.
Interesting idea. This would only really be handy for a multi-monitor setup imho.
> As we see some discussion like, we want a separate Dialog and some doesn’t
> want it, we Need an Option for changing this. Because I’m also for using
> the separated window. So Default should be as it is, as a tab Maybe and
> with anoption, we can switch to a more lightweight (w/o the tab stuff
> inside etc.). So please don’t decide to do it only in one way. We have
> multiple situations for that. To fix the most for all, use an Option to let
> the user decide how to use it.
At some point a decision has to be made. We cannot just add options for everything because each case has to be supported and this increases the complexity.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 4 May 2018 11:11 AM, Peter Steele <st...@gmail.com> wrote:
> +1 separate window
>
> I'd like to also suggest having the separate window track selection events
>
> in the windows that generated it so that you only have one window up. An
>
> example of this would be the commit window, clicking of different files
>
> would load the diff for that file and changing the selection would
>
> automatically update the same window with the diff from the new file.
>
> On Fri, 4 May 2018, 09:05 Christian Lenz, christian.lenz@gmx.net wrote:
>
> > As we see some discussion like, we want a separate Dialog and some doesn’t
> >
> > want it, we Need an Option for changing this. Because I’m also for using
> >
> > the separated window. So Default should be as it is, as a tab Maybe and
> >
> > with anoption, we can switch to a more lightweight (w/o the tab stuff
> >
> > inside etc.). So please don’t decide to do it only in one way. We have
> >
> > multiple situations for that. To fix the most for all, use an Option to let
> >
> > the user decide how to use it.
> >
> > Cheers
> >
> > Chris
> >
> > Von: cowwoc
> >
> > Gesendet: Donnerstag, 3. Mai 2018 17:53
> >
> > An: dev@netbeans.incubator.apache.org
> >
> > Betreff: Re: AW: (Git) Diff Window horizontal space rescue
> >
> > I'd be okay with "reuse diff topcomponent for identical diff". It seems
> >
> > like a reasonable default seeing as opening the same source file in the
> >
> > editor reuses the same tab. It would be consistent.
> >
> > Gili
> >
> > On 2018-05-03 6:07 AM, Sven Reimers wrote:
> >
> > > Hi,
> > >
> > > idea for solving this via configuration:
> > >
> > > - reuse diff topcomponent
> > > - reuse diff topcomponent for identical diff
> > >
> > > I like the simple navigation between topcomponents, but having the same
> > >
> > > diff open multiple times is annoying.
> > >
> > > Sven
> > >
> > > John McDonnell mcdonnell.john@gmail.com schrieb am Do., 3. Mai 2018,
> > >
> > > 08:18:
> > >
> > > > I'd be the same as you Emilian, I often end up with multiple
> > > >
> > > > editor windows of the same diff, which is annoying. Maybe a separate
> > > >
> > > > dialog makes
> > > >
> > > > sense?
> > > >
> > > > Could this be a preference thing? I.e. allow this as an editor
> > > >
> > > > component
> > >
> > > > or as a separate dialog? or is that a lot of effort?
> > > >
> > > > John
> > > >
> > > > On 3 May 2018 at 03:14, cowwoc cowwoc@bbs.darktech.org wrote:
> > > >
> > > > > Multiple diffs, probably not. But I don't like IDEA-style separate
> > > > >
> > > > > dialog.
> > > > >
> > > > > I like being able to treat the diff as just another editor tab so I can
> > > > >
> > > > > casually move back and forth between it and the code.
> > > > >
> > > > > Gili
> > > > >
> > > > > On 2018-05-02 9:25 PM, Emilian Bold wrote:
> > > > >
> > > > > > Now that you mention it, there is something odd about the diff window
> > > > > >
> > > > > > being another editor-like topcomponent.
> > > > > >
> > > > > > I sometimes find myself having the same diff open multiple times
> > > > > >
> > > > > > (generally after I've excluded some file manually in the Git bottom
> > > > > >
> > > > > > topcomponent).
> > > > > >
> > > > > > So, do people really need multiple diffs open at once? Because it's
> > > > > >
> > > > > > starting to make sense having this as a separate dialog.
> > > > > >
> > > > > > --emi
> > > > > >
> > > > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > > > >
> > > > > > On 2 May 2018 2:39 PM, Christian Lenz christian.lenz@gmx.net wrote:
> > > > > >
> > > > > > As I compared it with intelliJ e.g. (only to see how intelliJ does it)
> > > > > >
> > > > > > > they open the diff window as a standalone window to remove everything
> > > > > > >
> > > > > > > which
> > > > >
> > > > > > > is not needed. NetBeans only opens that diff for a file as a new tab.
> > > > > > >
> > > > > > > Sure
> > > > >
> > > > > > > you can make it floatable by your own but it is not a file, so it
> > > > > > >
> > > > > > > could be
> > > > >
> > > > > > > treated as a separate window which can be floatable via Option (not
> > > > > > >
> > > > > > > as
> > >
> > > > > > > Default, because it could be disturbing some other users). So I like
> > > > > > >
> > > > > > > the
> > > > >
> > > > > > > Approach to get more space. Maybe the drop downs can be placed close
> > > > > > >
> > > > > > > to the
> > > > >
> > > > > > > Icons, in the same line. If this make sense. See my screenshot how
> > > > > > >
> > > > > > > WebStorm
> > > > >
> > > > > > > handles this: https://ibb.co/jV9YW7 Only as an idea.
> > > > > > >
> > > > > > > It doesn’t Need the tab section and the other Icons. I added a secion
> > > > > > >
> > > > > > > screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The
> > > > > > >
> > > > > > > red section is not needed in my opinion. So we can remove it w/o
> > > > > > >
> > > > > > > having an
> > > > >
> > > > > > > Option for this. And the blue section should be optional and
> > > > > > >
> > > > > > > redesigned as
> > > > >
> > > > > > > Emilian said (textual/visual via DropDown e.g.)
> > > > > > >
> > > > > > > Cheers
> > > > > > >
> > > > > > > Chris
> > > > > > >
> > > > > > > Von: Emilian Bold
> > > > > > >
> > > > > > > Gesendet: Mittwoch, 2. Mai 2018 07:35
> > > > > > >
> > > > > > > An: dev@netbeans.incubator.apache.org
> > > > > > >
> > > > > > > Betreff: Re: (Git) Diff Window horizontal space rescue
> > > > > > >
> > > > > > > I wonder if it would be a good intermediate solution to just
> > > > > > >
> > > > > > > introduce
> > >
> > > > a
> > > >
> > > > > > > > System property that disables the enhanced flag in
> > > > > > > >
> > > > > > > > DefaultDiffControllerProvider. Then users can just gain some more
> > > > > > > >
> > > > > > > > pixels by
> > > > >
> > > > > > > > editing the .conf file.
> > > > > > >
> > > > > > > Createdhttps://github.com/apache/incubator-netbeans/pull/531
> > > > > > >
> > > > > > > With both PRs I get to see 32 lines of code for the diff vs 28 lines
> > > > > > >
> > > > > > > of
> > >
> > > > > > > code previously.
> > > > > > >
> > > > > > > This becomes even more important when I have the Output window open:
> > > > > > >
> > > > > > > I
> > >
> > > > > > > get to see 18 vs 14 lines of code!
> > > > > > >
> > > > > > > --emi
> > > > > > >
> > > > > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > > > > >
> > > > > > > On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch
> > > > > > >
> > > > > > > wrote:
> > >
> > > > > > > - there is a table with all the files being diff-ed (even if it's a
> > > > > > >
> > > > > > > > > single file!) and there is no way to reduce that space to zero, you
> > > > > > > > >
> > > > > > > > > always
> > > > >
> > > > > > > > > see some part of that split pane and the split pane divider itself.
> > > > > > > > >
> > > > > > > > > I want
> > > > >
> > > > > > > > > to add another action button in the toolbar (next to 'Display
> > > > > > > > >
> > > > > > > > > results as a
> > > > >
> > > > > > > > > tree') that hides that whole chunk.
> > > > > > > >
> > > > > > > > This seems to be rather tricky because there is a lot of state to
> > > > > > > >
> > > > > > > > manage in MultiDiffPanel.
> > > > > > > >
> > > > > > > > See the current patch https://github.com/emilianbold
> > > > > > > >
> > > > > > > > /incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158
> > > > > > > >
> > > > > > > > which does not have functioning next/prev actions when the file list
> > > > > > > >
> > > > > > > > is
> > > > >
> > > > > > > > hidden. I'm also calling refreshNodes because the UI was off when
> > > > > > > >
> > > > > > > > re-adding
> > > > >
> > > > > > > > the split pane (probably something with the selected node in the
> > > > > > > >
> > > > > > > > file
> > >
> > > > list
> > > >
> > > > > > > > too...)
> > > > > > > >
> > > > > > > > - there is a tabbed pane which shows Graphical / Textual diffs and
> > > > > > > >
> > > > > > > > > the tab buttons take considerable space too. Generally, I just want
> > > > > > > > >
> > > > > > > > > to see
> > > > >
> > > > > > > > > the graphical diff so I believe it would be nice to replace this
> > > > > > > > >
> > > > > > > > > with a
> > > > >
> > > > > > > > > combobox sitting in the toolbar too.
> > > > > > > >
> > > > > > > > This is caused by the EditableDiffView.enhancedView flag.
> > > > > > > >
> > > > > > > > I find the whole API of
> > > > > > > >
> > > > > > > > DiffControllerProvider.createEnhancedDiffController
> > > > >
> > > > > > > > vs createDiffController odd. Generally we use services and location
> > > > > > > >
> > > > > > > > to
> > >
> > > > > > > > replace a weaker service with an enhanced one.
> > > > > > > >
> > > > > > > > It's also unclear to me why EditableDiffView needs to be 'enhanced'
> > > > > > > >
> > > > > > > > and
> > > > >
> > > > > > > > show two tabs. When we could have 2 separate providers (one for the
> > > > > > > >
> > > > > > > > graphical and one for the textual diff) and create the tabbed pane
> > > > > > > >
> > > > > > > > ourselves. Then, we could even allow the user to disable one of
> > > > > > > >
> > > > > > > > these
> > >
> > > > > > > > services (eg, the textual one) and then show no tabbed pane if there
> > > > > > > >
> > > > > > > > is a
> > > > >
> > > > > > > > single service.
> > > > > > > >
> > > > > > > > Also interesting that we have DiffView.getToolbar() which might be a
> > > > > > > >
> > > > > > > > way to provide a combobox with Graphical/Textual from
> > > > > > > >
> > > > > > > > EditableDiffView but
> > > > >
> > > > > > > > this method doesn't seem to be used by the Git module. (Note how the
> > > > > > > >
> > > > > > > > whole
> > > > >
> > > > > > > > idea of an enhanced view that only has a toolbar seems redundant.)
> > > > > > > >
> > > > > > > > I wonder if it would be a good intermediate solution to just
> > > > > > > >
> > > > > > > > introduce
> > >
> > > > > > > > a System property that disables the enhanced flag in
> > > > > > > >
> > > > > > > > DefaultDiffControllerProvider. Then users can just gain some more
> > > > > > > >
> > > > > > > > pixels by
> > > > >
> > > > > > > > editing the .conf file.
> > > > > > > >
> > > > > > > > --emi
> > > > > > > >
> > > > > > > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > > > > > > >
> > > > > > > > On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch
> > > > > > > >
> > > > > > > > wrote:
> > > > >
> > > > > > > > Hello,
> > > > > > > >
> > > > > > > > > It seems to me that a lot of horizontal space is wasted by the
> > > > > > > > >
> > > > > > > > > current
> > > > >
> > > > > > > > > Git Diff window which means I get to see fewer and fewer line of
> > > > > > > > >
> > > > > > > > > source
> > > > >
> > > > > > > > > code. And what I really want to see in the diff window is my source
> > > > > > > > >
> > > > > > > > > code --
> > > > >
> > > > > > > > > I almost never touch any other button other than 'Commit Changes'.
> > > > > > > > >
> > > > > > > > > I've already made this PR https://github.com/apache/incu
> > > > > > > > >
> > > > > > > > > bator-netbeans/pull/529 which moves the so-called 'tree selection
> > > > > > > > >
> > > > > > > > > panel' from its own horizontal component into the toolbar.
> > > > > > > > >
> > > > > > > > > This saves about 70 pixels on my machine and I get to see 2 extra
> > > > > > > > >
> > > > > > > > > lines of source code in the Diff window.
> > > > > > > > >
> > > > > > > > > There are two other areas wasting pixels in this window I would
> > > > > > > > >
> > > > > > > > > like
> > >
> > > > > > > > > to approach:
> > > > > > > > >
> > > > > > > > > - there is a table with all the files being diff-ed (even if
> > > > > > > > >
> > > > > > > > > it's a
> > > > > > > > >
> > >
> > > > > > > > > single file!) and there is no way to reduce that space to zero, you
> > > > > > > > >
> > > > > > > > > always
> > > > >
> > > > > > > > > see some part of that split pane and the split pane divider itself.
> > > > > > > > >
> > > > > > > > > I want
> > > > >
> > > > > > > > > to add another action button in the toolbar (next to 'Display
> > > > > > > > >
> > > > > > > > > results as a
> > > > >
> > > > > > > > > tree') that hides that whole chunk.
> > > > > > > > >
> > > > > > > > > - there is a tabbed pane which shows Graphical / Textual
> > > > > > > > >
> > > > > > > > > diffs
> > >
> > > > > > > > > and the tab buttons take considerable space too. Generally, I just
> > > > > > > > >
> > > > > > > > > want to
> > > > >
> > > > > > > > > see the graphical diff so I believe it would be nice to replace
> > > > > > > > >
> > > > > > > > > this
> > >
> > > > with a
> > > >
> > > > > > > > > combobox sitting in the toolbar too.
> > > > > > > > >
> > > > > > > > > Of secondary concern I note that:
> > > > > > > > >
> > > > > > > > > - at the bottom of the diff component there is a huge
> > > > > > > > >
> > > > > > > > > border
> > >
> > > > of
> > > >
> > > > > > > > > about 20 pixels that could almost show another line. It's unclear
> > > > > > > > >
> > > > > > > > > to
> > >
> > > > me why
> > > >
> > > > > > > > > that is there or if it's LnF specific (I'm on macOS).
> > > > > > > > >
> > > > > > > > > - the Graphical diff component has a header showing you
> > > > > > > > >
> > > > > > > > > what
> > >
> > > > > > > > > you are comparing (HEAD / Modified in working tree). This seems
> > > > > > > > >
> > > > > > > > > almost
> > > > >
> > > > > > > > > redundant given we have the comboboxes in the 'tree selection
> > > > > > > > >
> > > > > > > > > panel'
> > >
> > > > > > > > > showing you what you are comparing (although the order is
> > > > > > > > >
> > > > > > > > > different!). It
> > > > >
> > > > > > > > > could also be replaced by something smarter, I'm thinking of a
> > > > > > > > >
> > > > > > > > > floating,
> > > > >
> > > > > > > > > semi-transparent label. Not sure where to put the label showing you
> > > > > > > > >
> > > > > > > > > the
> > > > >
> > > > > > > > > current chunk number (1/10, 2/10, etc).
> > > > > > > > >
> > > > > > > > > Let me know your thought. If anybody wants to help, join
> > > > > > > > >
> > > > > > > > > me!
> > > > >
> > > > > > > > > --emi
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > To unsubscribe, e-mail:
> > > > > > > > >
> > > > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
> > > > >
> > > > > > > > > For additional commands, e-mail: dev-help@netbeans.incubator.ap
> > > > > > > > >
> > > > > > > > > ache.org
> > > > > > > > >
> > > > > > > > > For further information about the NetBeans mailing lists, visit:
> > > > > > > > >
> > > > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > > > > > >
> > > > > > > > --
> > > > > > > >
> > > > > > > > To unsubscribe, e-mail:
> > > > > > > >
> > > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
> > >
> > > > > > > > For additional commands, e-mail:
> > > > > > > >
> > > > > > > > dev-help@netbeans.incubator.apache.org
> > > > >
> > > > > > > > For further information about the NetBeans mailing lists, visit:
> > > > > > > >
> > > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > > > > >
> > > > > > > --
> > > > > > >
> > > > > > > To unsubscribe, e-mail:
> > > > > > >
> > > > > > > dev-unsubscribe@netbeans.incubator.apache.org
> > >
> > > > > > > For additional commands, e-mail:
> > > > > > >
> > > > > > > dev-help@netbeans.incubator.apache.org
> > > > >
> > > > > > > For further information about the NetBeans mailing lists, visit:
> > > > > > >
> > > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > > > >
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > > > > >
> > > > > > For additional commands, e-mail:
> > > > > >
> > > > > > dev-help@netbeans.incubator.apache.org
> > >
> > > > > > For further information about the NetBeans mailing lists, visit:
> > > > > >
> > > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> > > > >
> > > > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > > > >
> > > > > For additional commands, e-mail:
> > > > >
> > > > > dev-help@netbeans.incubator.apache.org
> > >
> > > > > For further information about the NetBeans mailing lists, visit:
> > > > >
> > > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Peter Steele <st...@gmail.com>.
+1 separate window
I'd like to also suggest having the separate window track selection events
in the windows that generated it so that you only have one window up. An
example of this would be the commit window, clicking of different files
would load the diff for that file and changing the selection would
automatically update the same window with the diff from the new file.
On Fri, 4 May 2018, 09:05 Christian Lenz, <ch...@gmx.net> wrote:
> As we see some discussion like, we want a separate Dialog and some doesn’t
> want it, we Need an Option for changing this. Because I’m also for using
> the separated window. So Default should be as it is, as a tab Maybe and
> with anoption, we can switch to a more lightweight (w/o the tab stuff
> inside etc.). So please don’t decide to do it only in one way. We have
> multiple situations for that. To fix the most for all, use an Option to let
> the user decide how to use it.
>
>
> Cheers
>
> Chris
>
> Von: cowwoc
> Gesendet: Donnerstag, 3. Mai 2018 17:53
> An: dev@netbeans.incubator.apache.org
> Betreff: Re: AW: (Git) Diff Window horizontal space rescue
>
> I'd be okay with "reuse diff topcomponent for identical diff". It seems
> like a reasonable default seeing as opening the same source file in the
> editor reuses the same tab. It would be consistent.
>
> Gili
>
> On 2018-05-03 6:07 AM, Sven Reimers wrote:
> > Hi,
> >
> > idea for solving this via configuration:
> > - reuse diff topcomponent
> > - reuse diff topcomponent for identical diff
> >
> > I like the simple navigation between topcomponents, but having the same
> > diff open multiple times is annoying.
> >
> > Sven
> >
> > John McDonnell <mc...@gmail.com> schrieb am Do., 3. Mai 2018,
> > 08:18:
> >
> >> I'd be the same as you Emilian, I often end up with multiple
> >> editor windows of the same diff, which is annoying. Maybe a separate
> >> dialog makes
> >> sense?
> >>
> >>
> >>
> >> Could this be a preference thing? I.e. allow this as an editor
> component
> >> or as a separate dialog? or is that a lot of effort?
> >>
> >> John
> >>
> >>
> >>
> >> On 3 May 2018 at 03:14, cowwoc <co...@bbs.darktech.org> wrote:
> >>
> >>> Multiple diffs, probably not. But I don't like IDEA-style separate
> >> dialog.
> >>> I like being able to treat the diff as just another editor tab so I can
> >>> casually move back and forth between it and the code.
> >>>
> >>> Gili
> >>>
> >>>
> >>> On 2018-05-02 9:25 PM, Emilian Bold wrote:
> >>>
> >>>> Now that you mention it, there is something odd about the diff window
> >>>> being another editor-like topcomponent.
> >>>>
> >>>> I sometimes find myself having the same diff open multiple times
> >>>> (generally after I've excluded some file manually in the Git bottom
> >>>> topcomponent).
> >>>>
> >>>> So, do people really need multiple diffs open at once? Because it's
> >>>> starting to make sense having this as a separate dialog.
> >>>>
> >>>> --emi
> >>>>
> >>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >>>>
> >>>> On 2 May 2018 2:39 PM, Christian Lenz <ch...@gmx.net> wrote:
> >>>>
> >>>> As I compared it with intelliJ e.g. (only to see how intelliJ does it)
> >>>>> they open the diff window as a standalone window to remove everything
> >> which
> >>>>> is not needed. NetBeans only opens that diff for a file as a new tab.
> >> Sure
> >>>>> you can make it floatable by your own but it is not a file, so it
> >> could be
> >>>>> treated as a separate window which can be floatable via Option (not
> as
> >>>>> Default, because it could be disturbing some other users). So I like
> >> the
> >>>>> Approach to get more space. Maybe the drop downs can be placed close
> >> to the
> >>>>> Icons, in the same line. If this make sense. See my screenshot how
> >> WebStorm
> >>>>> handles this: https://ibb.co/jV9YW7 Only as an idea.
> >>>>>
> >>>>> It doesn’t Need the tab section and the other Icons. I added a secion
> >>>>> screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The
> >>>>> red section is not needed in my opinion. So we can remove it w/o
> >> having an
> >>>>> Option for this. And the blue section should be optional and
> >> redesigned as
> >>>>> Emilian said (textual/visual via DropDown e.g.)
> >>>>>
> >>>>> Cheers
> >>>>>
> >>>>> Chris
> >>>>>
> >>>>> Von: Emilian Bold
> >>>>>
> >>>>> Gesendet: Mittwoch, 2. Mai 2018 07:35
> >>>>>
> >>>>> An: dev@netbeans.incubator.apache.org
> >>>>>
> >>>>> Betreff: Re: (Git) Diff Window horizontal space rescue
> >>>>>
> >>>>> I wonder if it would be a good intermediate solution to just
> introduce
> >> a
> >>>>>> System property that disables the enhanced flag in
> >>>>>> DefaultDiffControllerProvider. Then users can just gain some more
> >> pixels by
> >>>>>> editing the .conf file.
> >>>>>>
> >>>>> Createdhttps://github.com/apache/incubator-netbeans/pull/531
> >>>>>
> >>>>> With both PRs I get to see 32 lines of code for the diff vs 28 lines
> of
> >>>>> code previously.
> >>>>>
> >>>>> This becomes even more important when I have the Output window open:
> I
> >>>>> get to see 18 vs 14 lines of code!
> >>>>>
> >>>>> --emi
> >>>>>
> >>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >>>>>
> >>>>> On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch
> wrote:
> >>>>>
> >>>>> - there is a table with all the files being diff-ed (even if it's a
> >>>>>>> single file!) and there is no way to reduce that space to zero, you
> >> always
> >>>>>>> see some part of that split pane and the split pane divider itself.
> >> I want
> >>>>>>> to add another action button in the toolbar (next to 'Display
> >> results as a
> >>>>>>> tree') that hides that whole chunk.
> >>>>>>>
> >>>>>> This seems to be rather tricky because there is a lot of state to
> >>>>>> manage in MultiDiffPanel.
> >>>>>>
> >>>>>> See the current patch https://github.com/emilianbold
> >>>>>> /incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158
> >>>>>> which does not have functioning next/prev actions when the file list
> >> is
> >>>>>> hidden. I'm also calling refreshNodes because the UI was off when
> >> re-adding
> >>>>>> the split pane (probably something with the selected node in the
> file
> >> list
> >>>>>> too...)
> >>>>>>
> >>>>>> - there is a tabbed pane which shows Graphical / Textual diffs and
> >>>>>>> the tab buttons take considerable space too. Generally, I just want
> >> to see
> >>>>>>> the graphical diff so I believe it would be nice to replace this
> >> with a
> >>>>>>> combobox sitting in the toolbar too.
> >>>>>>>
> >>>>>> This is caused by the EditableDiffView.enhancedView flag.
> >>>>>>
> >>>>>> I find the whole API of
> >> DiffControllerProvider.createEnhancedDiffController
> >>>>>> vs createDiffController odd. Generally we use services and location
> to
> >>>>>> replace a weaker service with an enhanced one.
> >>>>>>
> >>>>>> It's also unclear to me why EditableDiffView needs to be 'enhanced'
> >> and
> >>>>>> show two tabs. When we could have 2 separate providers (one for the
> >>>>>> graphical and one for the textual diff) and create the tabbed pane
> >>>>>> ourselves. Then, we could even allow the user to disable one of
> these
> >>>>>> services (eg, the textual one) and then show no tabbed pane if there
> >> is a
> >>>>>> single service.
> >>>>>>
> >>>>>> Also interesting that we have DiffView.getToolbar() which might be a
> >>>>>> way to provide a combobox with Graphical/Textual from
> >> EditableDiffView but
> >>>>>> this method doesn't seem to be used by the Git module. (Note how the
> >> whole
> >>>>>> idea of an enhanced view that only has a toolbar seems redundant.)
> >>>>>>
> >>>>>> I wonder if it would be a good intermediate solution to just
> introduce
> >>>>>> a System property that disables the enhanced flag in
> >>>>>> DefaultDiffControllerProvider. Then users can just gain some more
> >> pixels by
> >>>>>> editing the .conf file.
> >>>>>>
> >>>>>> --emi
> >>>>>>
> >>>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >>>>>>
> >>>>>> On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch
> >> wrote:
> >>>>>> Hello,
> >>>>>>> It seems to me that a lot of horizontal space is wasted by the
> >> current
> >>>>>>> Git Diff window which means I get to see fewer and fewer line of
> >> source
> >>>>>>> code. And what I really want to see in the diff window is my source
> >> code --
> >>>>>>> I almost never touch any other button other than 'Commit Changes'.
> >>>>>>>
> >>>>>>> I've already made this PR https://github.com/apache/incu
> >>>>>>> bator-netbeans/pull/529 which moves the so-called 'tree selection
> >>>>>>> panel' from its own horizontal component into the toolbar.
> >>>>>>>
> >>>>>>> This saves about 70 pixels on my machine and I get to see 2 extra
> >>>>>>> lines of source code in the Diff window.
> >>>>>>>
> >>>>>>> There are two other areas wasting pixels in this window I would
> like
> >>>>>>> to approach:
> >>>>>>>
> >>>>>>> - there is a table with all the files being diff-ed (even if
> it's a
> >>>>>>> single file!) and there is no way to reduce that space to zero, you
> >> always
> >>>>>>> see some part of that split pane and the split pane divider itself.
> >> I want
> >>>>>>> to add another action button in the toolbar (next to 'Display
> >> results as a
> >>>>>>> tree') that hides that whole chunk.
> >>>>>>> - there is a tabbed pane which shows Graphical / Textual
> diffs
> >>>>>>> and the tab buttons take considerable space too. Generally, I just
> >> want to
> >>>>>>> see the graphical diff so I believe it would be nice to replace
> this
> >> with a
> >>>>>>> combobox sitting in the toolbar too.
> >>>>>>> Of secondary concern I note that:
> >>>>>>> - at the bottom of the diff component there is a huge
> border
> >> of
> >>>>>>> about 20 pixels that could almost show another line. It's unclear
> to
> >> me why
> >>>>>>> that is there or if it's LnF specific (I'm on macOS).
> >>>>>>> - the Graphical diff component has a header showing you
> what
> >>>>>>> you are comparing (HEAD / Modified in working tree). This seems
> >> almost
> >>>>>>> redundant given we have the comboboxes in the 'tree selection
> panel'
> >>>>>>> showing you what you are comparing (although the order is
> >> different!). It
> >>>>>>> could also be replaced by something smarter, I'm thinking of a
> >> floating,
> >>>>>>> semi-transparent label. Not sure where to put the label showing you
> >> the
> >>>>>>> current chunk number (1/10, 2/10, etc).
> >>>>>>> Let me know your thought. If anybody wants to help, join
> >> me!
> >>>>>>> --emi
> >>>>>>>
> >>>>>>> To unsubscribe, e-mail:
> >> dev-unsubscribe@netbeans.incubator.apache.org
> >>>>>>> For additional commands, e-mail: dev-help@netbeans.incubator.ap
> >>>>>>> ache.org
> >>>>>>>
> >>>>>>> For further information about the NetBeans mailing lists, visit:
> >>>>>>>
> >>>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>>>>>>
> >>>>>> --
> >>>>>>
> >>>>>> To unsubscribe, e-mail:
> dev-unsubscribe@netbeans.incubator.apache.org
> >>>>>>
> >>>>>> For additional commands, e-mail:
> >> dev-help@netbeans.incubator.apache.org
> >>>>>> For further information about the NetBeans mailing lists, visit:
> >>>>>>
> >>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>>>>>
> >>>>> --
> >>>>>
> >>>>> To unsubscribe, e-mail:
> dev-unsubscribe@netbeans.incubator.apache.org
> >>>>>
> >>>>> For additional commands, e-mail:
> >> dev-help@netbeans.incubator.apache.org
> >>>>> For further information about the NetBeans mailing lists, visit:
> >>>>>
> >>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >>>> For additional commands, e-mail:
> dev-help@netbeans.incubator.apache.org
> >>>>
> >>>> For further information about the NetBeans mailing lists, visit:
> >>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>>>
> >>>>
> >>>>
> >>>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >>> For additional commands, e-mail:
> dev-help@netbeans.incubator.apache.org
> >>>
> >>> For further information about the NetBeans mailing lists, visit:
> >>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>>
> >>>
> >>>
> >>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
>
AW: AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
As we see some discussion like, we want a separate Dialog and some doesn’t want it, we Need an Option for changing this. Because I’m also for using the separated window. So Default should be as it is, as a tab Maybe and with anoption, we can switch to a more lightweight (w/o the tab stuff inside etc.). So please don’t decide to do it only in one way. We have multiple situations for that. To fix the most for all, use an Option to let the user decide how to use it.
Cheers
Chris
Von: cowwoc
Gesendet: Donnerstag, 3. Mai 2018 17:53
An: dev@netbeans.incubator.apache.org
Betreff: Re: AW: (Git) Diff Window horizontal space rescue
I'd be okay with "reuse diff topcomponent for identical diff". It seems
like a reasonable default seeing as opening the same source file in the
editor reuses the same tab. It would be consistent.
Gili
On 2018-05-03 6:07 AM, Sven Reimers wrote:
> Hi,
>
> idea for solving this via configuration:
> - reuse diff topcomponent
> - reuse diff topcomponent for identical diff
>
> I like the simple navigation between topcomponents, but having the same
> diff open multiple times is annoying.
>
> Sven
>
> John McDonnell <mc...@gmail.com> schrieb am Do., 3. Mai 2018,
> 08:18:
>
>> I'd be the same as you Emilian, I often end up with multiple
>> editor windows of the same diff, which is annoying. Maybe a separate
>> dialog makes
>> sense?
>>
>>
>>
>> Could this be a preference thing? I.e. allow this as an editor component
>> or as a separate dialog? or is that a lot of effort?
>>
>> John
>>
>>
>>
>> On 3 May 2018 at 03:14, cowwoc <co...@bbs.darktech.org> wrote:
>>
>>> Multiple diffs, probably not. But I don't like IDEA-style separate
>> dialog.
>>> I like being able to treat the diff as just another editor tab so I can
>>> casually move back and forth between it and the code.
>>>
>>> Gili
>>>
>>>
>>> On 2018-05-02 9:25 PM, Emilian Bold wrote:
>>>
>>>> Now that you mention it, there is something odd about the diff window
>>>> being another editor-like topcomponent.
>>>>
>>>> I sometimes find myself having the same diff open multiple times
>>>> (generally after I've excluded some file manually in the Git bottom
>>>> topcomponent).
>>>>
>>>> So, do people really need multiple diffs open at once? Because it's
>>>> starting to make sense having this as a separate dialog.
>>>>
>>>> --emi
>>>>
>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>
>>>> On 2 May 2018 2:39 PM, Christian Lenz <ch...@gmx.net> wrote:
>>>>
>>>> As I compared it with intelliJ e.g. (only to see how intelliJ does it)
>>>>> they open the diff window as a standalone window to remove everything
>> which
>>>>> is not needed. NetBeans only opens that diff for a file as a new tab.
>> Sure
>>>>> you can make it floatable by your own but it is not a file, so it
>> could be
>>>>> treated as a separate window which can be floatable via Option (not as
>>>>> Default, because it could be disturbing some other users). So I like
>> the
>>>>> Approach to get more space. Maybe the drop downs can be placed close
>> to the
>>>>> Icons, in the same line. If this make sense. See my screenshot how
>> WebStorm
>>>>> handles this: https://ibb.co/jV9YW7 Only as an idea.
>>>>>
>>>>> It doesn’t Need the tab section and the other Icons. I added a secion
>>>>> screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The
>>>>> red section is not needed in my opinion. So we can remove it w/o
>> having an
>>>>> Option for this. And the blue section should be optional and
>> redesigned as
>>>>> Emilian said (textual/visual via DropDown e.g.)
>>>>>
>>>>> Cheers
>>>>>
>>>>> Chris
>>>>>
>>>>> Von: Emilian Bold
>>>>>
>>>>> Gesendet: Mittwoch, 2. Mai 2018 07:35
>>>>>
>>>>> An: dev@netbeans.incubator.apache.org
>>>>>
>>>>> Betreff: Re: (Git) Diff Window horizontal space rescue
>>>>>
>>>>> I wonder if it would be a good intermediate solution to just introduce
>> a
>>>>>> System property that disables the enhanced flag in
>>>>>> DefaultDiffControllerProvider. Then users can just gain some more
>> pixels by
>>>>>> editing the .conf file.
>>>>>>
>>>>> Createdhttps://github.com/apache/incubator-netbeans/pull/531
>>>>>
>>>>> With both PRs I get to see 32 lines of code for the diff vs 28 lines of
>>>>> code previously.
>>>>>
>>>>> This becomes even more important when I have the Output window open: I
>>>>> get to see 18 vs 14 lines of code!
>>>>>
>>>>> --emi
>>>>>
>>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>>
>>>>> On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>>>>>
>>>>> - there is a table with all the files being diff-ed (even if it's a
>>>>>>> single file!) and there is no way to reduce that space to zero, you
>> always
>>>>>>> see some part of that split pane and the split pane divider itself.
>> I want
>>>>>>> to add another action button in the toolbar (next to 'Display
>> results as a
>>>>>>> tree') that hides that whole chunk.
>>>>>>>
>>>>>> This seems to be rather tricky because there is a lot of state to
>>>>>> manage in MultiDiffPanel.
>>>>>>
>>>>>> See the current patch https://github.com/emilianbold
>>>>>> /incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158
>>>>>> which does not have functioning next/prev actions when the file list
>> is
>>>>>> hidden. I'm also calling refreshNodes because the UI was off when
>> re-adding
>>>>>> the split pane (probably something with the selected node in the file
>> list
>>>>>> too...)
>>>>>>
>>>>>> - there is a tabbed pane which shows Graphical / Textual diffs and
>>>>>>> the tab buttons take considerable space too. Generally, I just want
>> to see
>>>>>>> the graphical diff so I believe it would be nice to replace this
>> with a
>>>>>>> combobox sitting in the toolbar too.
>>>>>>>
>>>>>> This is caused by the EditableDiffView.enhancedView flag.
>>>>>>
>>>>>> I find the whole API of
>> DiffControllerProvider.createEnhancedDiffController
>>>>>> vs createDiffController odd. Generally we use services and location to
>>>>>> replace a weaker service with an enhanced one.
>>>>>>
>>>>>> It's also unclear to me why EditableDiffView needs to be 'enhanced'
>> and
>>>>>> show two tabs. When we could have 2 separate providers (one for the
>>>>>> graphical and one for the textual diff) and create the tabbed pane
>>>>>> ourselves. Then, we could even allow the user to disable one of these
>>>>>> services (eg, the textual one) and then show no tabbed pane if there
>> is a
>>>>>> single service.
>>>>>>
>>>>>> Also interesting that we have DiffView.getToolbar() which might be a
>>>>>> way to provide a combobox with Graphical/Textual from
>> EditableDiffView but
>>>>>> this method doesn't seem to be used by the Git module. (Note how the
>> whole
>>>>>> idea of an enhanced view that only has a toolbar seems redundant.)
>>>>>>
>>>>>> I wonder if it would be a good intermediate solution to just introduce
>>>>>> a System property that disables the enhanced flag in
>>>>>> DefaultDiffControllerProvider. Then users can just gain some more
>> pixels by
>>>>>> editing the .conf file.
>>>>>>
>>>>>> --emi
>>>>>>
>>>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>>>
>>>>>> On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch
>> wrote:
>>>>>> Hello,
>>>>>>> It seems to me that a lot of horizontal space is wasted by the
>> current
>>>>>>> Git Diff window which means I get to see fewer and fewer line of
>> source
>>>>>>> code. And what I really want to see in the diff window is my source
>> code --
>>>>>>> I almost never touch any other button other than 'Commit Changes'.
>>>>>>>
>>>>>>> I've already made this PR https://github.com/apache/incu
>>>>>>> bator-netbeans/pull/529 which moves the so-called 'tree selection
>>>>>>> panel' from its own horizontal component into the toolbar.
>>>>>>>
>>>>>>> This saves about 70 pixels on my machine and I get to see 2 extra
>>>>>>> lines of source code in the Diff window.
>>>>>>>
>>>>>>> There are two other areas wasting pixels in this window I would like
>>>>>>> to approach:
>>>>>>>
>>>>>>> - there is a table with all the files being diff-ed (even if it's a
>>>>>>> single file!) and there is no way to reduce that space to zero, you
>> always
>>>>>>> see some part of that split pane and the split pane divider itself.
>> I want
>>>>>>> to add another action button in the toolbar (next to 'Display
>> results as a
>>>>>>> tree') that hides that whole chunk.
>>>>>>> - there is a tabbed pane which shows Graphical / Textual diffs
>>>>>>> and the tab buttons take considerable space too. Generally, I just
>> want to
>>>>>>> see the graphical diff so I believe it would be nice to replace this
>> with a
>>>>>>> combobox sitting in the toolbar too.
>>>>>>> Of secondary concern I note that:
>>>>>>> - at the bottom of the diff component there is a huge border
>> of
>>>>>>> about 20 pixels that could almost show another line. It's unclear to
>> me why
>>>>>>> that is there or if it's LnF specific (I'm on macOS).
>>>>>>> - the Graphical diff component has a header showing you what
>>>>>>> you are comparing (HEAD / Modified in working tree). This seems
>> almost
>>>>>>> redundant given we have the comboboxes in the 'tree selection panel'
>>>>>>> showing you what you are comparing (although the order is
>> different!). It
>>>>>>> could also be replaced by something smarter, I'm thinking of a
>> floating,
>>>>>>> semi-transparent label. Not sure where to put the label showing you
>> the
>>>>>>> current chunk number (1/10, 2/10, etc).
>>>>>>> Let me know your thought. If anybody wants to help, join
>> me!
>>>>>>> --emi
>>>>>>>
>>>>>>> To unsubscribe, e-mail:
>> dev-unsubscribe@netbeans.incubator.apache.org
>>>>>>> For additional commands, e-mail: dev-help@netbeans.incubator.ap
>>>>>>> ache.org
>>>>>>>
>>>>>>> For further information about the NetBeans mailing lists, visit:
>>>>>>>
>>>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>>>>
>>>>>> --
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>>>>
>>>>>> For additional commands, e-mail:
>> dev-help@netbeans.incubator.apache.org
>>>>>> For further information about the NetBeans mailing lists, visit:
>>>>>>
>>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>>>
>>>>> --
>>>>>
>>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>>>
>>>>> For additional commands, e-mail:
>> dev-help@netbeans.incubator.apache.org
>>>>> For further information about the NetBeans mailing lists, visit:
>>>>>
>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>>>
>>>> For further information about the NetBeans mailing lists, visit:
>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>>
>>> For further information about the NetBeans mailing lists, visit:
>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>
>>>
>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by cowwoc <co...@bbs.darktech.org>.
I'd be okay with "reuse diff topcomponent for identical diff". It seems
like a reasonable default seeing as opening the same source file in the
editor reuses the same tab. It would be consistent.
Gili
On 2018-05-03 6:07 AM, Sven Reimers wrote:
> Hi,
>
> idea for solving this via configuration:
> - reuse diff topcomponent
> - reuse diff topcomponent for identical diff
>
> I like the simple navigation between topcomponents, but having the same
> diff open multiple times is annoying.
>
> Sven
>
> John McDonnell <mc...@gmail.com> schrieb am Do., 3. Mai 2018,
> 08:18:
>
>> I'd be the same as you Emilian, I often end up with multiple
>> editor windows of the same diff, which is annoying. Maybe a separate
>> dialog makes
>> sense?
>>
>>
>>
>> Could this be a preference thing? I.e. allow this as an editor component
>> or as a separate dialog? or is that a lot of effort?
>>
>> John
>>
>>
>>
>> On 3 May 2018 at 03:14, cowwoc <co...@bbs.darktech.org> wrote:
>>
>>> Multiple diffs, probably not. But I don't like IDEA-style separate
>> dialog.
>>> I like being able to treat the diff as just another editor tab so I can
>>> casually move back and forth between it and the code.
>>>
>>> Gili
>>>
>>>
>>> On 2018-05-02 9:25 PM, Emilian Bold wrote:
>>>
>>>> Now that you mention it, there is something odd about the diff window
>>>> being another editor-like topcomponent.
>>>>
>>>> I sometimes find myself having the same diff open multiple times
>>>> (generally after I've excluded some file manually in the Git bottom
>>>> topcomponent).
>>>>
>>>> So, do people really need multiple diffs open at once? Because it's
>>>> starting to make sense having this as a separate dialog.
>>>>
>>>> --emi
>>>>
>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>
>>>> On 2 May 2018 2:39 PM, Christian Lenz <ch...@gmx.net> wrote:
>>>>
>>>> As I compared it with intelliJ e.g. (only to see how intelliJ does it)
>>>>> they open the diff window as a standalone window to remove everything
>> which
>>>>> is not needed. NetBeans only opens that diff for a file as a new tab.
>> Sure
>>>>> you can make it floatable by your own but it is not a file, so it
>> could be
>>>>> treated as a separate window which can be floatable via Option (not as
>>>>> Default, because it could be disturbing some other users). So I like
>> the
>>>>> Approach to get more space. Maybe the drop downs can be placed close
>> to the
>>>>> Icons, in the same line. If this make sense. See my screenshot how
>> WebStorm
>>>>> handles this: https://ibb.co/jV9YW7 Only as an idea.
>>>>>
>>>>> It doesn’t Need the tab section and the other Icons. I added a secion
>>>>> screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The
>>>>> red section is not needed in my opinion. So we can remove it w/o
>> having an
>>>>> Option for this. And the blue section should be optional and
>> redesigned as
>>>>> Emilian said (textual/visual via DropDown e.g.)
>>>>>
>>>>> Cheers
>>>>>
>>>>> Chris
>>>>>
>>>>> Von: Emilian Bold
>>>>>
>>>>> Gesendet: Mittwoch, 2. Mai 2018 07:35
>>>>>
>>>>> An: dev@netbeans.incubator.apache.org
>>>>>
>>>>> Betreff: Re: (Git) Diff Window horizontal space rescue
>>>>>
>>>>> I wonder if it would be a good intermediate solution to just introduce
>> a
>>>>>> System property that disables the enhanced flag in
>>>>>> DefaultDiffControllerProvider. Then users can just gain some more
>> pixels by
>>>>>> editing the .conf file.
>>>>>>
>>>>> Createdhttps://github.com/apache/incubator-netbeans/pull/531
>>>>>
>>>>> With both PRs I get to see 32 lines of code for the diff vs 28 lines of
>>>>> code previously.
>>>>>
>>>>> This becomes even more important when I have the Output window open: I
>>>>> get to see 18 vs 14 lines of code!
>>>>>
>>>>> --emi
>>>>>
>>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>>
>>>>> On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>>>>>
>>>>> - there is a table with all the files being diff-ed (even if it's a
>>>>>>> single file!) and there is no way to reduce that space to zero, you
>> always
>>>>>>> see some part of that split pane and the split pane divider itself.
>> I want
>>>>>>> to add another action button in the toolbar (next to 'Display
>> results as a
>>>>>>> tree') that hides that whole chunk.
>>>>>>>
>>>>>> This seems to be rather tricky because there is a lot of state to
>>>>>> manage in MultiDiffPanel.
>>>>>>
>>>>>> See the current patch https://github.com/emilianbold
>>>>>> /incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158
>>>>>> which does not have functioning next/prev actions when the file list
>> is
>>>>>> hidden. I'm also calling refreshNodes because the UI was off when
>> re-adding
>>>>>> the split pane (probably something with the selected node in the file
>> list
>>>>>> too...)
>>>>>>
>>>>>> - there is a tabbed pane which shows Graphical / Textual diffs and
>>>>>>> the tab buttons take considerable space too. Generally, I just want
>> to see
>>>>>>> the graphical diff so I believe it would be nice to replace this
>> with a
>>>>>>> combobox sitting in the toolbar too.
>>>>>>>
>>>>>> This is caused by the EditableDiffView.enhancedView flag.
>>>>>>
>>>>>> I find the whole API of
>> DiffControllerProvider.createEnhancedDiffController
>>>>>> vs createDiffController odd. Generally we use services and location to
>>>>>> replace a weaker service with an enhanced one.
>>>>>>
>>>>>> It's also unclear to me why EditableDiffView needs to be 'enhanced'
>> and
>>>>>> show two tabs. When we could have 2 separate providers (one for the
>>>>>> graphical and one for the textual diff) and create the tabbed pane
>>>>>> ourselves. Then, we could even allow the user to disable one of these
>>>>>> services (eg, the textual one) and then show no tabbed pane if there
>> is a
>>>>>> single service.
>>>>>>
>>>>>> Also interesting that we have DiffView.getToolbar() which might be a
>>>>>> way to provide a combobox with Graphical/Textual from
>> EditableDiffView but
>>>>>> this method doesn't seem to be used by the Git module. (Note how the
>> whole
>>>>>> idea of an enhanced view that only has a toolbar seems redundant.)
>>>>>>
>>>>>> I wonder if it would be a good intermediate solution to just introduce
>>>>>> a System property that disables the enhanced flag in
>>>>>> DefaultDiffControllerProvider. Then users can just gain some more
>> pixels by
>>>>>> editing the .conf file.
>>>>>>
>>>>>> --emi
>>>>>>
>>>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>>>
>>>>>> On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch
>> wrote:
>>>>>> Hello,
>>>>>>> It seems to me that a lot of horizontal space is wasted by the
>> current
>>>>>>> Git Diff window which means I get to see fewer and fewer line of
>> source
>>>>>>> code. And what I really want to see in the diff window is my source
>> code --
>>>>>>> I almost never touch any other button other than 'Commit Changes'.
>>>>>>>
>>>>>>> I've already made this PR https://github.com/apache/incu
>>>>>>> bator-netbeans/pull/529 which moves the so-called 'tree selection
>>>>>>> panel' from its own horizontal component into the toolbar.
>>>>>>>
>>>>>>> This saves about 70 pixels on my machine and I get to see 2 extra
>>>>>>> lines of source code in the Diff window.
>>>>>>>
>>>>>>> There are two other areas wasting pixels in this window I would like
>>>>>>> to approach:
>>>>>>>
>>>>>>> - there is a table with all the files being diff-ed (even if it's a
>>>>>>> single file!) and there is no way to reduce that space to zero, you
>> always
>>>>>>> see some part of that split pane and the split pane divider itself.
>> I want
>>>>>>> to add another action button in the toolbar (next to 'Display
>> results as a
>>>>>>> tree') that hides that whole chunk.
>>>>>>> - there is a tabbed pane which shows Graphical / Textual diffs
>>>>>>> and the tab buttons take considerable space too. Generally, I just
>> want to
>>>>>>> see the graphical diff so I believe it would be nice to replace this
>> with a
>>>>>>> combobox sitting in the toolbar too.
>>>>>>> Of secondary concern I note that:
>>>>>>> - at the bottom of the diff component there is a huge border
>> of
>>>>>>> about 20 pixels that could almost show another line. It's unclear to
>> me why
>>>>>>> that is there or if it's LnF specific (I'm on macOS).
>>>>>>> - the Graphical diff component has a header showing you what
>>>>>>> you are comparing (HEAD / Modified in working tree). This seems
>> almost
>>>>>>> redundant given we have the comboboxes in the 'tree selection panel'
>>>>>>> showing you what you are comparing (although the order is
>> different!). It
>>>>>>> could also be replaced by something smarter, I'm thinking of a
>> floating,
>>>>>>> semi-transparent label. Not sure where to put the label showing you
>> the
>>>>>>> current chunk number (1/10, 2/10, etc).
>>>>>>> Let me know your thought. If anybody wants to help, join
>> me!
>>>>>>> --emi
>>>>>>>
>>>>>>> To unsubscribe, e-mail:
>> dev-unsubscribe@netbeans.incubator.apache.org
>>>>>>> For additional commands, e-mail: dev-help@netbeans.incubator.ap
>>>>>>> ache.org
>>>>>>>
>>>>>>> For further information about the NetBeans mailing lists, visit:
>>>>>>>
>>>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>>>>
>>>>>> --
>>>>>>
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>>>>
>>>>>> For additional commands, e-mail:
>> dev-help@netbeans.incubator.apache.org
>>>>>> For further information about the NetBeans mailing lists, visit:
>>>>>>
>>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>>>
>>>>> --
>>>>>
>>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>>>
>>>>> For additional commands, e-mail:
>> dev-help@netbeans.incubator.apache.org
>>>>> For further information about the NetBeans mailing lists, visit:
>>>>>
>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>>>
>>>> For further information about the NetBeans mailing lists, visit:
>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>>
>>> For further information about the NetBeans mailing lists, visit:
>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>
>>>
>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Sven Reimers <sv...@gmail.com>.
Hi,
idea for solving this via configuration:
- reuse diff topcomponent
- reuse diff topcomponent for identical diff
I like the simple navigation between topcomponents, but having the same
diff open multiple times is annoying.
Sven
John McDonnell <mc...@gmail.com> schrieb am Do., 3. Mai 2018,
08:18:
> I'd be the same as you Emilian, I often end up with multiple
> editor windows of the same diff, which is annoying. Maybe a separate
> dialog makes
> sense?
>
>
>
> Could this be a preference thing? I.e. allow this as an editor component
> or as a separate dialog? or is that a lot of effort?
>
> John
>
>
>
> On 3 May 2018 at 03:14, cowwoc <co...@bbs.darktech.org> wrote:
>
> > Multiple diffs, probably not. But I don't like IDEA-style separate
> dialog.
> > I like being able to treat the diff as just another editor tab so I can
> > casually move back and forth between it and the code.
> >
> > Gili
> >
> >
> > On 2018-05-02 9:25 PM, Emilian Bold wrote:
> >
> >> Now that you mention it, there is something odd about the diff window
> >> being another editor-like topcomponent.
> >>
> >> I sometimes find myself having the same diff open multiple times
> >> (generally after I've excluded some file manually in the Git bottom
> >> topcomponent).
> >>
> >> So, do people really need multiple diffs open at once? Because it's
> >> starting to make sense having this as a separate dialog.
> >>
> >> --emi
> >>
> >> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >>
> >> On 2 May 2018 2:39 PM, Christian Lenz <ch...@gmx.net> wrote:
> >>
> >> As I compared it with intelliJ e.g. (only to see how intelliJ does it)
> >>> they open the diff window as a standalone window to remove everything
> which
> >>> is not needed. NetBeans only opens that diff for a file as a new tab.
> Sure
> >>> you can make it floatable by your own but it is not a file, so it
> could be
> >>> treated as a separate window which can be floatable via Option (not as
> >>> Default, because it could be disturbing some other users). So I like
> the
> >>> Approach to get more space. Maybe the drop downs can be placed close
> to the
> >>> Icons, in the same line. If this make sense. See my screenshot how
> WebStorm
> >>> handles this: https://ibb.co/jV9YW7 Only as an idea.
> >>>
> >>> It doesn’t Need the tab section and the other Icons. I added a secion
> >>> screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The
> >>> red section is not needed in my opinion. So we can remove it w/o
> having an
> >>> Option for this. And the blue section should be optional and
> redesigned as
> >>> Emilian said (textual/visual via DropDown e.g.)
> >>>
> >>> Cheers
> >>>
> >>> Chris
> >>>
> >>> Von: Emilian Bold
> >>>
> >>> Gesendet: Mittwoch, 2. Mai 2018 07:35
> >>>
> >>> An: dev@netbeans.incubator.apache.org
> >>>
> >>> Betreff: Re: (Git) Diff Window horizontal space rescue
> >>>
> >>> I wonder if it would be a good intermediate solution to just introduce
> a
> >>>> System property that disables the enhanced flag in
> >>>> DefaultDiffControllerProvider. Then users can just gain some more
> pixels by
> >>>> editing the .conf file.
> >>>>
> >>> Createdhttps://github.com/apache/incubator-netbeans/pull/531
> >>>
> >>> With both PRs I get to see 32 lines of code for the diff vs 28 lines of
> >>> code previously.
> >>>
> >>> This becomes even more important when I have the Output window open: I
> >>> get to see 18 vs 14 lines of code!
> >>>
> >>> --emi
> >>>
> >>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >>>
> >>> On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
> >>>
> >>> - there is a table with all the files being diff-ed (even if it's a
> >>>>> single file!) and there is no way to reduce that space to zero, you
> always
> >>>>> see some part of that split pane and the split pane divider itself.
> I want
> >>>>> to add another action button in the toolbar (next to 'Display
> results as a
> >>>>> tree') that hides that whole chunk.
> >>>>>
> >>>> This seems to be rather tricky because there is a lot of state to
> >>>> manage in MultiDiffPanel.
> >>>>
> >>>> See the current patch https://github.com/emilianbold
> >>>> /incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158
> >>>> which does not have functioning next/prev actions when the file list
> is
> >>>> hidden. I'm also calling refreshNodes because the UI was off when
> re-adding
> >>>> the split pane (probably something with the selected node in the file
> list
> >>>> too...)
> >>>>
> >>>> - there is a tabbed pane which shows Graphical / Textual diffs and
> >>>>> the tab buttons take considerable space too. Generally, I just want
> to see
> >>>>> the graphical diff so I believe it would be nice to replace this
> with a
> >>>>> combobox sitting in the toolbar too.
> >>>>>
> >>>> This is caused by the EditableDiffView.enhancedView flag.
> >>>>
> >>>> I find the whole API of
> DiffControllerProvider.createEnhancedDiffController
> >>>> vs createDiffController odd. Generally we use services and location to
> >>>> replace a weaker service with an enhanced one.
> >>>>
> >>>> It's also unclear to me why EditableDiffView needs to be 'enhanced'
> and
> >>>> show two tabs. When we could have 2 separate providers (one for the
> >>>> graphical and one for the textual diff) and create the tabbed pane
> >>>> ourselves. Then, we could even allow the user to disable one of these
> >>>> services (eg, the textual one) and then show no tabbed pane if there
> is a
> >>>> single service.
> >>>>
> >>>> Also interesting that we have DiffView.getToolbar() which might be a
> >>>> way to provide a combobox with Graphical/Textual from
> EditableDiffView but
> >>>> this method doesn't seem to be used by the Git module. (Note how the
> whole
> >>>> idea of an enhanced view that only has a toolbar seems redundant.)
> >>>>
> >>>> I wonder if it would be a good intermediate solution to just introduce
> >>>> a System property that disables the enhanced flag in
> >>>> DefaultDiffControllerProvider. Then users can just gain some more
> pixels by
> >>>> editing the .conf file.
> >>>>
> >>>> --emi
> >>>>
> >>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >>>>
> >>>> On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch
> wrote:
> >>>>
> >>>> Hello,
> >>>>>
> >>>>> It seems to me that a lot of horizontal space is wasted by the
> current
> >>>>> Git Diff window which means I get to see fewer and fewer line of
> source
> >>>>> code. And what I really want to see in the diff window is my source
> code --
> >>>>> I almost never touch any other button other than 'Commit Changes'.
> >>>>>
> >>>>> I've already made this PR https://github.com/apache/incu
> >>>>> bator-netbeans/pull/529 which moves the so-called 'tree selection
> >>>>> panel' from its own horizontal component into the toolbar.
> >>>>>
> >>>>> This saves about 70 pixels on my machine and I get to see 2 extra
> >>>>> lines of source code in the Diff window.
> >>>>>
> >>>>> There are two other areas wasting pixels in this window I would like
> >>>>> to approach:
> >>>>>
> >>>>> - there is a table with all the files being diff-ed (even if it's a
> >>>>> single file!) and there is no way to reduce that space to zero, you
> always
> >>>>> see some part of that split pane and the split pane divider itself.
> I want
> >>>>> to add another action button in the toolbar (next to 'Display
> results as a
> >>>>> tree') that hides that whole chunk.
> >>>>> - there is a tabbed pane which shows Graphical / Textual diffs
> >>>>> and the tab buttons take considerable space too. Generally, I just
> want to
> >>>>> see the graphical diff so I believe it would be nice to replace this
> with a
> >>>>> combobox sitting in the toolbar too.
> >>>>> Of secondary concern I note that:
> >>>>> - at the bottom of the diff component there is a huge border
> of
> >>>>> about 20 pixels that could almost show another line. It's unclear to
> me why
> >>>>> that is there or if it's LnF specific (I'm on macOS).
> >>>>> - the Graphical diff component has a header showing you what
> >>>>> you are comparing (HEAD / Modified in working tree). This seems
> almost
> >>>>> redundant given we have the comboboxes in the 'tree selection panel'
> >>>>> showing you what you are comparing (although the order is
> different!). It
> >>>>> could also be replaced by something smarter, I'm thinking of a
> floating,
> >>>>> semi-transparent label. Not sure where to put the label showing you
> the
> >>>>> current chunk number (1/10, 2/10, etc).
> >>>>> Let me know your thought. If anybody wants to help, join
> me!
> >>>>> --emi
> >>>>>
> >>>>> To unsubscribe, e-mail:
> dev-unsubscribe@netbeans.incubator.apache.org
> >>>>>
> >>>>> For additional commands, e-mail: dev-help@netbeans.incubator.ap
> >>>>> ache.org
> >>>>>
> >>>>> For further information about the NetBeans mailing lists, visit:
> >>>>>
> >>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>>>>
> >>>> --
> >>>>
> >>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >>>>
> >>>> For additional commands, e-mail:
> dev-help@netbeans.incubator.apache.org
> >>>>
> >>>> For further information about the NetBeans mailing lists, visit:
> >>>>
> >>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>>>
> >>> --
> >>>
> >>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >>>
> >>> For additional commands, e-mail:
> dev-help@netbeans.incubator.apache.org
> >>>
> >>> For further information about the NetBeans mailing lists, visit:
> >>>
> >>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >>
> >> For further information about the NetBeans mailing lists, visit:
> >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >>
> >>
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> >
> >
> >
>
Re: AW: (Git) Diff Window horizontal space rescue
Posted by John McDonnell <mc...@gmail.com>.
I'd be the same as you Emilian, I often end up with multiple
editor windows of the same diff, which is annoying. Maybe a separate
dialog makes
sense?
Could this be a preference thing? I.e. allow this as an editor component
or as a separate dialog? or is that a lot of effort?
John
On 3 May 2018 at 03:14, cowwoc <co...@bbs.darktech.org> wrote:
> Multiple diffs, probably not. But I don't like IDEA-style separate dialog.
> I like being able to treat the diff as just another editor tab so I can
> casually move back and forth between it and the code.
>
> Gili
>
>
> On 2018-05-02 9:25 PM, Emilian Bold wrote:
>
>> Now that you mention it, there is something odd about the diff window
>> being another editor-like topcomponent.
>>
>> I sometimes find myself having the same diff open multiple times
>> (generally after I've excluded some file manually in the Git bottom
>> topcomponent).
>>
>> So, do people really need multiple diffs open at once? Because it's
>> starting to make sense having this as a separate dialog.
>>
>> --emi
>>
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>
>> On 2 May 2018 2:39 PM, Christian Lenz <ch...@gmx.net> wrote:
>>
>> As I compared it with intelliJ e.g. (only to see how intelliJ does it)
>>> they open the diff window as a standalone window to remove everything which
>>> is not needed. NetBeans only opens that diff for a file as a new tab. Sure
>>> you can make it floatable by your own but it is not a file, so it could be
>>> treated as a separate window which can be floatable via Option (not as
>>> Default, because it could be disturbing some other users). So I like the
>>> Approach to get more space. Maybe the drop downs can be placed close to the
>>> Icons, in the same line. If this make sense. See my screenshot how WebStorm
>>> handles this: https://ibb.co/jV9YW7 Only as an idea.
>>>
>>> It doesn’t Need the tab section and the other Icons. I added a secion
>>> screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The
>>> red section is not needed in my opinion. So we can remove it w/o having an
>>> Option for this. And the blue section should be optional and redesigned as
>>> Emilian said (textual/visual via DropDown e.g.)
>>>
>>> Cheers
>>>
>>> Chris
>>>
>>> Von: Emilian Bold
>>>
>>> Gesendet: Mittwoch, 2. Mai 2018 07:35
>>>
>>> An: dev@netbeans.incubator.apache.org
>>>
>>> Betreff: Re: (Git) Diff Window horizontal space rescue
>>>
>>> I wonder if it would be a good intermediate solution to just introduce a
>>>> System property that disables the enhanced flag in
>>>> DefaultDiffControllerProvider. Then users can just gain some more pixels by
>>>> editing the .conf file.
>>>>
>>> Createdhttps://github.com/apache/incubator-netbeans/pull/531
>>>
>>> With both PRs I get to see 32 lines of code for the diff vs 28 lines of
>>> code previously.
>>>
>>> This becomes even more important when I have the Output window open: I
>>> get to see 18 vs 14 lines of code!
>>>
>>> --emi
>>>
>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>
>>> On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>>>
>>> - there is a table with all the files being diff-ed (even if it's a
>>>>> single file!) and there is no way to reduce that space to zero, you always
>>>>> see some part of that split pane and the split pane divider itself. I want
>>>>> to add another action button in the toolbar (next to 'Display results as a
>>>>> tree') that hides that whole chunk.
>>>>>
>>>> This seems to be rather tricky because there is a lot of state to
>>>> manage in MultiDiffPanel.
>>>>
>>>> See the current patch https://github.com/emilianbold
>>>> /incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158
>>>> which does not have functioning next/prev actions when the file list is
>>>> hidden. I'm also calling refreshNodes because the UI was off when re-adding
>>>> the split pane (probably something with the selected node in the file list
>>>> too...)
>>>>
>>>> - there is a tabbed pane which shows Graphical / Textual diffs and
>>>>> the tab buttons take considerable space too. Generally, I just want to see
>>>>> the graphical diff so I believe it would be nice to replace this with a
>>>>> combobox sitting in the toolbar too.
>>>>>
>>>> This is caused by the EditableDiffView.enhancedView flag.
>>>>
>>>> I find the whole API of DiffControllerProvider.createEnhancedDiffController
>>>> vs createDiffController odd. Generally we use services and location to
>>>> replace a weaker service with an enhanced one.
>>>>
>>>> It's also unclear to me why EditableDiffView needs to be 'enhanced' and
>>>> show two tabs. When we could have 2 separate providers (one for the
>>>> graphical and one for the textual diff) and create the tabbed pane
>>>> ourselves. Then, we could even allow the user to disable one of these
>>>> services (eg, the textual one) and then show no tabbed pane if there is a
>>>> single service.
>>>>
>>>> Also interesting that we have DiffView.getToolbar() which might be a
>>>> way to provide a combobox with Graphical/Textual from EditableDiffView but
>>>> this method doesn't seem to be used by the Git module. (Note how the whole
>>>> idea of an enhanced view that only has a toolbar seems redundant.)
>>>>
>>>> I wonder if it would be a good intermediate solution to just introduce
>>>> a System property that disables the enhanced flag in
>>>> DefaultDiffControllerProvider. Then users can just gain some more pixels by
>>>> editing the .conf file.
>>>>
>>>> --emi
>>>>
>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>
>>>> On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>>>>
>>>> Hello,
>>>>>
>>>>> It seems to me that a lot of horizontal space is wasted by the current
>>>>> Git Diff window which means I get to see fewer and fewer line of source
>>>>> code. And what I really want to see in the diff window is my source code --
>>>>> I almost never touch any other button other than 'Commit Changes'.
>>>>>
>>>>> I've already made this PR https://github.com/apache/incu
>>>>> bator-netbeans/pull/529 which moves the so-called 'tree selection
>>>>> panel' from its own horizontal component into the toolbar.
>>>>>
>>>>> This saves about 70 pixels on my machine and I get to see 2 extra
>>>>> lines of source code in the Diff window.
>>>>>
>>>>> There are two other areas wasting pixels in this window I would like
>>>>> to approach:
>>>>>
>>>>> - there is a table with all the files being diff-ed (even if it's a
>>>>> single file!) and there is no way to reduce that space to zero, you always
>>>>> see some part of that split pane and the split pane divider itself. I want
>>>>> to add another action button in the toolbar (next to 'Display results as a
>>>>> tree') that hides that whole chunk.
>>>>> - there is a tabbed pane which shows Graphical / Textual diffs
>>>>> and the tab buttons take considerable space too. Generally, I just want to
>>>>> see the graphical diff so I believe it would be nice to replace this with a
>>>>> combobox sitting in the toolbar too.
>>>>> Of secondary concern I note that:
>>>>> - at the bottom of the diff component there is a huge border of
>>>>> about 20 pixels that could almost show another line. It's unclear to me why
>>>>> that is there or if it's LnF specific (I'm on macOS).
>>>>> - the Graphical diff component has a header showing you what
>>>>> you are comparing (HEAD / Modified in working tree). This seems almost
>>>>> redundant given we have the comboboxes in the 'tree selection panel'
>>>>> showing you what you are comparing (although the order is different!). It
>>>>> could also be replaced by something smarter, I'm thinking of a floating,
>>>>> semi-transparent label. Not sure where to put the label showing you the
>>>>> current chunk number (1/10, 2/10, etc).
>>>>> Let me know your thought. If anybody wants to help, join me!
>>>>> --emi
>>>>>
>>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>>>
>>>>> For additional commands, e-mail: dev-help@netbeans.incubator.ap
>>>>> ache.org
>>>>>
>>>>> For further information about the NetBeans mailing lists, visit:
>>>>>
>>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>>
>>>> --
>>>>
>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>>
>>>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>>>
>>>> For further information about the NetBeans mailing lists, visit:
>>>>
>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>>
>>> --
>>>
>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>
>>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>>
>>> For further information about the NetBeans mailing lists, visit:
>>>
>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: AW: (Git) Diff Window horizontal space rescue
Posted by cowwoc <co...@bbs.darktech.org>.
Multiple diffs, probably not. But I don't like IDEA-style separate
dialog. I like being able to treat the diff as just another editor tab
so I can casually move back and forth between it and the code.
Gili
On 2018-05-02 9:25 PM, Emilian Bold wrote:
> Now that you mention it, there is something odd about the diff window being another editor-like topcomponent.
>
> I sometimes find myself having the same diff open multiple times (generally after I've excluded some file manually in the Git bottom topcomponent).
>
> So, do people really need multiple diffs open at once? Because it's starting to make sense having this as a separate dialog.
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 2 May 2018 2:39 PM, Christian Lenz <ch...@gmx.net> wrote:
>
>> As I compared it with intelliJ e.g. (only to see how intelliJ does it) they open the diff window as a standalone window to remove everything which is not needed. NetBeans only opens that diff for a file as a new tab. Sure you can make it floatable by your own but it is not a file, so it could be treated as a separate window which can be floatable via Option (not as Default, because it could be disturbing some other users). So I like the Approach to get more space. Maybe the drop downs can be placed close to the Icons, in the same line. If this make sense. See my screenshot how WebStorm handles this: https://ibb.co/jV9YW7 Only as an idea.
>>
>> It doesn’t Need the tab section and the other Icons. I added a secion screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The red section is not needed in my opinion. So we can remove it w/o having an Option for this. And the blue section should be optional and redesigned as Emilian said (textual/visual via DropDown e.g.)
>>
>> Cheers
>>
>> Chris
>>
>> Von: Emilian Bold
>>
>> Gesendet: Mittwoch, 2. Mai 2018 07:35
>>
>> An: dev@netbeans.incubator.apache.org
>>
>> Betreff: Re: (Git) Diff Window horizontal space rescue
>>
>>> I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
>> Createdhttps://github.com/apache/incubator-netbeans/pull/531
>>
>> With both PRs I get to see 32 lines of code for the diff vs 28 lines of code previously.
>>
>> This becomes even more important when I have the Output window open: I get to see 18 vs 14 lines of code!
>>
>> --emi
>>
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>
>> On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>>
>>>> - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
>>> This seems to be rather tricky because there is a lot of state to manage in MultiDiffPanel.
>>>
>>> See the current patch https://github.com/emilianbold/incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158 which does not have functioning next/prev actions when the file list is hidden. I'm also calling refreshNodes because the UI was off when re-adding the split pane (probably something with the selected node in the file list too...)
>>>
>>>> - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
>>> This is caused by the EditableDiffView.enhancedView flag.
>>>
>>> I find the whole API of DiffControllerProvider.createEnhancedDiffController vs createDiffController odd. Generally we use services and location to replace a weaker service with an enhanced one.
>>>
>>> It's also unclear to me why EditableDiffView needs to be 'enhanced' and show two tabs. When we could have 2 separate providers (one for the graphical and one for the textual diff) and create the tabbed pane ourselves. Then, we could even allow the user to disable one of these services (eg, the textual one) and then show no tabbed pane if there is a single service.
>>>
>>> Also interesting that we have DiffView.getToolbar() which might be a way to provide a combobox with Graphical/Textual from EditableDiffView but this method doesn't seem to be used by the Git module. (Note how the whole idea of an enhanced view that only has a toolbar seems redundant.)
>>>
>>> I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
>>>
>>> --emi
>>>
>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>
>>> On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>>>
>>>> Hello,
>>>>
>>>> It seems to me that a lot of horizontal space is wasted by the current Git Diff window which means I get to see fewer and fewer line of source code. And what I really want to see in the diff window is my source code -- I almost never touch any other button other than 'Commit Changes'.
>>>>
>>>> I've already made this PR https://github.com/apache/incubator-netbeans/pull/529 which moves the so-called 'tree selection panel' from its own horizontal component into the toolbar.
>>>>
>>>> This saves about 70 pixels on my machine and I get to see 2 extra lines of source code in the Diff window.
>>>>
>>>> There are two other areas wasting pixels in this window I would like to approach:
>>>>
>>>> - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
>>>>
>>>> - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
>>>>
>>>> Of secondary concern I note that:
>>>>
>>>> - at the bottom of the diff component there is a huge border of about 20 pixels that could almost show another line. It's unclear to me why that is there or if it's LnF specific (I'm on macOS).
>>>>
>>>> - the Graphical diff component has a header showing you what you are comparing (HEAD / Modified in working tree). This seems almost redundant given we have the comboboxes in the 'tree selection panel' showing you what you are comparing (although the order is different!). It could also be replaced by something smarter, I'm thinking of a floating, semi-transparent label. Not sure where to put the label showing you the current chunk number (1/10, 2/10, etc).
>>>>
>>>> Let me know your thought. If anybody wants to help, join me!
>>>>
>>>> --emi
>>>>
>>>>
>>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>>
>>>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>>>
>>>> For further information about the NetBeans mailing lists, visit:
>>>>
>>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>>> --
>>>
>>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>>
>>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>>
>>> For further information about the NetBeans mailing lists, visit:
>>>
>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>> --
>>
>> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>>
>> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>>
>> For further information about the NetBeans mailing lists, visit:
>>
>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: AW: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
Now that you mention it, there is something odd about the diff window being another editor-like topcomponent.
I sometimes find myself having the same diff open multiple times (generally after I've excluded some file manually in the Git bottom topcomponent).
So, do people really need multiple diffs open at once? Because it's starting to make sense having this as a separate dialog.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 2 May 2018 2:39 PM, Christian Lenz <ch...@gmx.net> wrote:
> As I compared it with intelliJ e.g. (only to see how intelliJ does it) they open the diff window as a standalone window to remove everything which is not needed. NetBeans only opens that diff for a file as a new tab. Sure you can make it floatable by your own but it is not a file, so it could be treated as a separate window which can be floatable via Option (not as Default, because it could be disturbing some other users). So I like the Approach to get more space. Maybe the drop downs can be placed close to the Icons, in the same line. If this make sense. See my screenshot how WebStorm handles this: https://ibb.co/jV9YW7 Only as an idea.
>
> It doesn’t Need the tab section and the other Icons. I added a secion screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The red section is not needed in my opinion. So we can remove it w/o having an Option for this. And the blue section should be optional and redesigned as Emilian said (textual/visual via DropDown e.g.)
>
> Cheers
>
> Chris
>
> Von: Emilian Bold
>
> Gesendet: Mittwoch, 2. Mai 2018 07:35
>
> An: dev@netbeans.incubator.apache.org
>
> Betreff: Re: (Git) Diff Window horizontal space rescue
>
> > I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
>
> Createdhttps://github.com/apache/incubator-netbeans/pull/531
>
> With both PRs I get to see 32 lines of code for the diff vs 28 lines of code previously.
>
> This becomes even more important when I have the Output window open: I get to see 18 vs 14 lines of code!
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 2 May 2018 7:46 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>
> > > - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
> >
> > This seems to be rather tricky because there is a lot of state to manage in MultiDiffPanel.
> >
> > See the current patch https://github.com/emilianbold/incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158 which does not have functioning next/prev actions when the file list is hidden. I'm also calling refreshNodes because the UI was off when re-adding the split pane (probably something with the selected node in the file list too...)
> >
> > > - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
> >
> > This is caused by the EditableDiffView.enhancedView flag.
> >
> > I find the whole API of DiffControllerProvider.createEnhancedDiffController vs createDiffController odd. Generally we use services and location to replace a weaker service with an enhanced one.
> >
> > It's also unclear to me why EditableDiffView needs to be 'enhanced' and show two tabs. When we could have 2 separate providers (one for the graphical and one for the textual diff) and create the tabbed pane ourselves. Then, we could even allow the user to disable one of these services (eg, the textual one) and then show no tabbed pane if there is a single service.
> >
> > Also interesting that we have DiffView.getToolbar() which might be a way to provide a combobox with Graphical/Textual from EditableDiffView but this method doesn't seem to be used by the Git module. (Note how the whole idea of an enhanced view that only has a toolbar seems redundant.)
> >
> > I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
> >
> > --emi
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
> >
> > > Hello,
> > >
> > > It seems to me that a lot of horizontal space is wasted by the current Git Diff window which means I get to see fewer and fewer line of source code. And what I really want to see in the diff window is my source code -- I almost never touch any other button other than 'Commit Changes'.
> > >
> > > I've already made this PR https://github.com/apache/incubator-netbeans/pull/529 which moves the so-called 'tree selection panel' from its own horizontal component into the toolbar.
> > >
> > > This saves about 70 pixels on my machine and I get to see 2 extra lines of source code in the Diff window.
> > >
> > > There are two other areas wasting pixels in this window I would like to approach:
> > >
> > > - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
> > >
> > > - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
> > >
> > > Of secondary concern I note that:
> > >
> > > - at the bottom of the diff component there is a huge border of about 20 pixels that could almost show another line. It's unclear to me why that is there or if it's LnF specific (I'm on macOS).
> > >
> > > - the Graphical diff component has a header showing you what you are comparing (HEAD / Modified in working tree). This seems almost redundant given we have the comboboxes in the 'tree selection panel' showing you what you are comparing (although the order is different!). It could also be replaced by something smarter, I'm thinking of a floating, semi-transparent label. Not sure where to put the label showing you the current chunk number (1/10, 2/10, etc).
> > >
> > > Let me know your thought. If anybody wants to help, join me!
> > >
> > > --emi
> > >
> > >
> > > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> > >
> > > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> > >
> > > For further information about the NetBeans mailing lists, visit:
> > >
> > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
> >
> > --
> >
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
> --
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
AW: (Git) Diff Window horizontal space rescue
Posted by Christian Lenz <ch...@gmx.net>.
As I compared it with intelliJ e.g. (only to see how intelliJ does it) they open the diff window as a standalone window to remove everything which is not needed. NetBeans only opens that diff for a file as a new tab. Sure you can make it floatable by your own but it is not a file, so it could be treated as a separate window which can be floatable via Option (not as Default, because it could be disturbing some other users). So I like the Approach to get more space. Maybe the drop downs can be placed close to the Icons, in the same line. If this make sense. See my screenshot how WebStorm handles this: https://ibb.co/jV9YW7 Only as an idea.
It doesn’t Need the tab section and the other Icons. I added a secion screenshot: https://ibb.co/bsLe4S Here you can see, what I mean. The red section is not needed in my opinion. So we can remove it w/o having an Option for this. And the blue section should be optional and redesigned as Emilian said (textual/visual via DropDown e.g.)
Cheers
Chris
Von: Emilian Bold
Gesendet: Mittwoch, 2. Mai 2018 07:35
An: dev@netbeans.incubator.apache.org
Betreff: Re: (Git) Diff Window horizontal space rescue
> I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
Created https://github.com/apache/incubator-netbeans/pull/531
With both PRs I get to see 32 lines of code for the diff vs 28 lines of code previously.
This becomes even more important when I have the Output window open: I get to see 18 vs 14 lines of code!
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 2 May 2018 7:46 AM, Emilian Bold <em...@protonmail.ch> wrote:
> > - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
>
> This seems to be rather tricky because there is a lot of state to manage in MultiDiffPanel.
>
> See the current patch https://github.com/emilianbold/incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158 which does not have functioning next/prev actions when the file list is hidden. I'm also calling refreshNodes because the UI was off when re-adding the split pane (probably something with the selected node in the file list too...)
>
> > - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
>
> This is caused by the EditableDiffView.enhancedView flag.
>
> I find the whole API of DiffControllerProvider.createEnhancedDiffController vs createDiffController odd. Generally we use services and location to replace a weaker service with an enhanced one.
>
> It's also unclear to me why EditableDiffView needs to be 'enhanced' and show two tabs. When we could have 2 separate providers (one for the graphical and one for the textual diff) and create the tabbed pane ourselves. Then, we could even allow the user to disable one of these services (eg, the textual one) and then show no tabbed pane if there is a single service.
>
> Also interesting that we have DiffView.getToolbar() which might be a way to provide a combobox with Graphical/Textual from EditableDiffView but this method doesn't seem to be used by the Git module. (Note how the whole idea of an enhanced view that only has a toolbar seems redundant.)
>
> I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>
> > Hello,
> >
> > It seems to me that a lot of horizontal space is wasted by the current Git Diff window which means I get to see fewer and fewer line of source code. And what I really want to see in the diff window is my source code -- I almost never touch any other button other than 'Commit Changes'.
> >
> > I've already made this PR https://github.com/apache/incubator-netbeans/pull/529 which moves the so-called 'tree selection panel' from its own horizontal component into the toolbar.
> >
> > This saves about 70 pixels on my machine and I get to see 2 extra lines of source code in the Diff window.
> >
> > There are two other areas wasting pixels in this window I would like to approach:
> >
> > - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
> >
> > - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
> >
> > Of secondary concern I note that:
> >
> > - at the bottom of the diff component there is a huge border of about 20 pixels that could almost show another line. It's unclear to me why that is there or if it's LnF specific (I'm on macOS).
> >
> > - the Graphical diff component has a header showing you what you are comparing (HEAD / Modified in working tree). This seems almost redundant given we have the comboboxes in the 'tree selection panel' showing you what you are comparing (although the order is different!). It could also be replaced by something smarter, I'm thinking of a floating, semi-transparent label. Not sure where to put the label showing you the current chunk number (1/10, 2/10, etc).
> >
> > Let me know your thought. If anybody wants to help, join me!
> >
> > --emi
> >
> >
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
> --
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
> I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
Created https://github.com/apache/incubator-netbeans/pull/531
With both PRs I get to see 32 lines of code for the diff vs 28 lines of code previously.
This becomes even more important when I have the Output window open: I get to see 18 vs 14 lines of code!
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 2 May 2018 7:46 AM, Emilian Bold <em...@protonmail.ch> wrote:
> > - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
>
> This seems to be rather tricky because there is a lot of state to manage in MultiDiffPanel.
>
> See the current patch https://github.com/emilianbold/incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158 which does not have functioning next/prev actions when the file list is hidden. I'm also calling refreshNodes because the UI was off when re-adding the split pane (probably something with the selected node in the file list too...)
>
> > - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
>
> This is caused by the EditableDiffView.enhancedView flag.
>
> I find the whole API of DiffControllerProvider.createEnhancedDiffController vs createDiffController odd. Generally we use services and location to replace a weaker service with an enhanced one.
>
> It's also unclear to me why EditableDiffView needs to be 'enhanced' and show two tabs. When we could have 2 separate providers (one for the graphical and one for the textual diff) and create the tabbed pane ourselves. Then, we could even allow the user to disable one of these services (eg, the textual one) and then show no tabbed pane if there is a single service.
>
> Also interesting that we have DiffView.getToolbar() which might be a way to provide a combobox with Graphical/Textual from EditableDiffView but this method doesn't seem to be used by the Git module. (Note how the whole idea of an enhanced view that only has a toolbar seems redundant.)
>
> I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
>
> --emi
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On 1 May 2018 10:23 AM, Emilian Bold emilian.bold@protonmail.ch wrote:
>
> > Hello,
> >
> > It seems to me that a lot of horizontal space is wasted by the current Git Diff window which means I get to see fewer and fewer line of source code. And what I really want to see in the diff window is my source code -- I almost never touch any other button other than 'Commit Changes'.
> >
> > I've already made this PR https://github.com/apache/incubator-netbeans/pull/529 which moves the so-called 'tree selection panel' from its own horizontal component into the toolbar.
> >
> > This saves about 70 pixels on my machine and I get to see 2 extra lines of source code in the Diff window.
> >
> > There are two other areas wasting pixels in this window I would like to approach:
> >
> > - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
> >
> > - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
> >
> > Of secondary concern I note that:
> >
> > - at the bottom of the diff component there is a huge border of about 20 pixels that could almost show another line. It's unclear to me why that is there or if it's LnF specific (I'm on macOS).
> >
> > - the Graphical diff component has a header showing you what you are comparing (HEAD / Modified in working tree). This seems almost redundant given we have the comboboxes in the 'tree selection panel' showing you what you are comparing (although the order is different!). It could also be replaced by something smarter, I'm thinking of a floating, semi-transparent label. Not sure where to put the label showing you the current chunk number (1/10, 2/10, etc).
> >
> > Let me know your thought. If anybody wants to help, join me!
> >
> > --emi
> >
> >
> > To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
> >
> > For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
> >
> > For further information about the NetBeans mailing lists, visit:
> >
> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
> --
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: (Git) Diff Window horizontal space rescue
Posted by Emilian Bold <em...@protonmail.ch>.
> - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
This seems to be rather tricky because there is a lot of state to manage in MultiDiffPanel.
See the current patch https://github.com/emilianbold/incubator-netbeans/commit/7cbe909649534f136746bc960e314ff697fd4158 which does not have functioning next/prev actions when the file list is hidden. I'm also calling refreshNodes because the UI was off when re-adding the split pane (probably something with the selected node in the file list too...)
> - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
This is caused by the EditableDiffView.enhancedView flag.
I find the whole API of DiffControllerProvider.createEnhancedDiffController vs createDiffController odd. Generally we use services and location to replace a weaker service with an enhanced one.
It's also unclear to me why EditableDiffView needs to be 'enhanced' and show two tabs. When we could have 2 separate providers (one for the graphical and one for the textual diff) and create the tabbed pane ourselves. Then, we could even allow the user to disable one of these services (eg, the textual one) and then show no tabbed pane if there is a single service.
Also interesting that we have DiffView.getToolbar() which might be a way to provide a combobox with Graphical/Textual from EditableDiffView but this method doesn't seem to be used by the Git module. (Note how the whole idea of an enhanced view that only has a toolbar seems redundant.)
I wonder if it would be a good intermediate solution to just introduce a System property that disables the enhanced flag in DefaultDiffControllerProvider. Then users can just gain some more pixels by editing the .conf file.
--emi
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On 1 May 2018 10:23 AM, Emilian Bold <em...@protonmail.ch> wrote:
> Hello,
>
> It seems to me that a lot of horizontal space is wasted by the current Git Diff window which means I get to see fewer and fewer line of source code. And what I really want to see in the diff window is my source code -- I almost never touch any other button other than 'Commit Changes'.
>
> I've already made this PR https://github.com/apache/incubator-netbeans/pull/529 which moves the so-called 'tree selection panel' from its own horizontal component into the toolbar.
>
> This saves about 70 pixels on my machine and I get to see 2 extra lines of source code in the Diff window.
>
> There are two other areas wasting pixels in this window I would like to approach:
>
> - there is a table with all the files being diff-ed (even if it's a single file!) and there is no way to reduce that space to zero, you always see some part of that split pane and the split pane divider itself. I want to add another action button in the toolbar (next to 'Display results as a tree') that hides that whole chunk.
> - there is a tabbed pane which shows Graphical / Textual diffs and the tab buttons take considerable space too. Generally, I just want to see the graphical diff so I believe it would be nice to replace this with a combobox sitting in the toolbar too.
>
> Of secondary concern I note that:
>
> - at the bottom of the diff component there is a huge border of about 20 pixels that could almost show another line. It's unclear to me why that is there or if it's LnF specific (I'm on macOS).
> - the Graphical diff component has a header showing you what you are comparing (HEAD / Modified in working tree). This seems almost redundant given we have the comboboxes in the 'tree selection panel' showing you what you are comparing (although the order is different!). It could also be replaced by something smarter, I'm thinking of a floating, semi-transparent label. Not sure where to put the label showing you the current chunk number (1/10, 2/10, etc).
>
> Let me know your thought. If anybody wants to help, join me!
>
> --emi
>
>
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
>
> For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
>
> For further information about the NetBeans mailing lists, visit:
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.incubator.apache.org
For additional commands, e-mail: dev-help@netbeans.incubator.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists