You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ol...@apache.org on 2011/01/31 21:48:27 UTC
svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Author: olamy
Date: Mon Jan 31 20:48:26 2011
New Revision: 1065772
URL: http://svn.apache.org/viewvc?rev=1065772&view=rev
Log:
[MPOM-1] apache-release does unwanted things in the prepare goal.
move <arguments>-Papache-release</arguments> to maven parent pom.
Modified:
maven/pom/trunk/asf/pom.xml
maven/pom/trunk/maven/pom.xml
Modified: maven/pom/trunk/asf/pom.xml
URL: http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff
==============================================================================
--- maven/pom/trunk/asf/pom.xml (original)
+++ maven/pom/trunk/asf/pom.xml Mon Jan 31 20:48:26 2011
@@ -189,8 +189,7 @@ under the License.
<version>2.1</version>
<configuration>
<useReleaseProfile>false</useReleaseProfile>
- <goals>deploy</goals>
- <arguments>-Papache-release</arguments>
+ <goals>deploy</goals>
</configuration>
</plugin>
<!-- END SNIPPET: release-plugin-configuration -->
Modified: maven/pom/trunk/maven/pom.xml
URL: http://svn.apache.org/viewvc/maven/pom/trunk/maven/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff
==============================================================================
--- maven/pom/trunk/maven/pom.xml (original)
+++ maven/pom/trunk/maven/pom.xml Mon Jan 31 20:48:26 2011
@@ -593,6 +593,20 @@ under the License.
<url>scp://people.apache.org/www/maven.apache.org</url>
</site>
</distributionManagement>
+
+ <build>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-release-plugin</artifactId>
+ <configuration>
+ <arguments>-Papache-release</arguments>
+ </configuration>
+ </plugin>
+ </plugins>
+ </pluginManagement>
+ </build>
<reporting>
<plugins>
Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Posted by Olivier Lamy <ol...@apache.org>.
Hello,
I agree.
But note I have missed something in the ASF pom
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<version>2.1</version>
<configuration>
<useReleaseProfile>false</useReleaseProfile>
<goals>deploy</goals>
<releaseProfiles>apache-release</releaseProfiles>
</configuration>
</plugin>
And I have added in two places a kind of warning for people to test
their settings configuration :
* http://www.apache.org/dev/publishing-maven-artifacts.html (Section
Test you settings )
* http://maven.apache.org/asf-pom/ (Section Settings Configuration)
And sure btw I don't have any issues about moving all doc provided by
Benson to the apache main website.
And revert all stuff.
At the end I just want most of people being happy (sure not an easy task :-) )
2011/2/9 Mark Struberg <st...@yahoo.de>:
> Benson, the signing itself doesn't take that long, even for projects like OpenJPA which needs about 1 hour for the whole build. So I'm with Brian that it's better to spend 1 minute for the code signing in the prepare phase than having to revert tags, branches, rebuild all from scratch again, etc which in case of OpenJPA would cost you almost half a day.
>
> There are a few pro and con arguments here, but 'fail fast' is imo the way to go here.
>
> LieGrue,
> strub
>
> --- On Wed, 2/9/11, Benson Margulies <bi...@gmail.com> wrote:
>
>> From: Benson Margulies <bi...@gmail.com>
>> Subject: Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
>> To: "Maven Developers List" <de...@maven.apache.org>
>> Date: Wednesday, February 9, 2011, 2:13 AM
>> Unfortunately for the coherence of
>> this discussion, it was months and
>> months ago that I filed the original version of this JIRA.
>> The best I
>> can lay my mental fingers on is this: for a large project,
>> signing and
>> such can take a very long time, making it very slow and
>> frustrating to
>> work through a set of problems. I was having a very hard
>> time
>> debugging problems in release:prepare, and the addition of
>> the profile
>> just added to my confusion.
>>
>> That all being written, if my first encounter with the
>> parent had been
>> documentation that explained what it was doing and why, I
>> would never
>> have filed the JIRA in the first place. Which is why I
>> already wrote,
>> and Olivier already committed, the explanatory material
>> that I offered
>> to write to save others from the confusion I encountered
>> when I first
>> used this parent. So if you all revert this change,
>> honestly, no more
>> squeaks from me.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
Olivier Lamy
http://twitter.com/olamy
http://www.linkedin.com/in/olamy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Posted by Benson Margulies <bi...@gmail.com>.
I just have to remember to add it to the infra site.
On Tue, Feb 8, 2011 at 9:16 PM, Brian Fox <br...@infinity.nu> wrote:
> btw, thanks for the documentation on the parent...if nothing else
> comes from this at least we got that ;-)
>
> On Tue, Feb 8, 2011 at 9:13 PM, Benson Margulies <bi...@gmail.com> wrote:
>> Unfortunately for the coherence of this discussion, it was months and
>> months ago that I filed the original version of this JIRA. The best I
>> can lay my mental fingers on is this: for a large project, signing and
>> such can take a very long time, making it very slow and frustrating to
>> work through a set of problems. I was having a very hard time
>> debugging problems in release:prepare, and the addition of the profile
>> just added to my confusion.
>>
>> That all being written, if my first encounter with the parent had been
>> documentation that explained what it was doing and why, I would never
>> have filed the JIRA in the first place. Which is why I already wrote,
>> and Olivier already committed, the explanatory material that I offered
>> to write to save others from the confusion I encountered when I first
>> used this parent. So if you all revert this change, honestly, no more
>> squeaks from me.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Posted by Brian Fox <br...@infinity.nu>.
btw, thanks for the documentation on the parent...if nothing else
comes from this at least we got that ;-)
On Tue, Feb 8, 2011 at 9:13 PM, Benson Margulies <bi...@gmail.com> wrote:
> Unfortunately for the coherence of this discussion, it was months and
> months ago that I filed the original version of this JIRA. The best I
> can lay my mental fingers on is this: for a large project, signing and
> such can take a very long time, making it very slow and frustrating to
> work through a set of problems. I was having a very hard time
> debugging problems in release:prepare, and the addition of the profile
> just added to my confusion.
>
> That all being written, if my first encounter with the parent had been
> documentation that explained what it was doing and why, I would never
> have filed the JIRA in the first place. Which is why I already wrote,
> and Olivier already committed, the explanatory material that I offered
> to write to save others from the confusion I encountered when I first
> used this parent. So if you all revert this change, honestly, no more
> squeaks from me.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Posted by Mark Struberg <st...@yahoo.de>.
Benson, the signing itself doesn't take that long, even for projects like OpenJPA which needs about 1 hour for the whole build. So I'm with Brian that it's better to spend 1 minute for the code signing in the prepare phase than having to revert tags, branches, rebuild all from scratch again, etc which in case of OpenJPA would cost you almost half a day.
There are a few pro and con arguments here, but 'fail fast' is imo the way to go here.
LieGrue,
strub
--- On Wed, 2/9/11, Benson Margulies <bi...@gmail.com> wrote:
> From: Benson Margulies <bi...@gmail.com>
> Subject: Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
> To: "Maven Developers List" <de...@maven.apache.org>
> Date: Wednesday, February 9, 2011, 2:13 AM
> Unfortunately for the coherence of
> this discussion, it was months and
> months ago that I filed the original version of this JIRA.
> The best I
> can lay my mental fingers on is this: for a large project,
> signing and
> such can take a very long time, making it very slow and
> frustrating to
> work through a set of problems. I was having a very hard
> time
> debugging problems in release:prepare, and the addition of
> the profile
> just added to my confusion.
>
> That all being written, if my first encounter with the
> parent had been
> documentation that explained what it was doing and why, I
> would never
> have filed the JIRA in the first place. Which is why I
> already wrote,
> and Olivier already committed, the explanatory material
> that I offered
> to write to save others from the confusion I encountered
> when I first
> used this parent. So if you all revert this change,
> honestly, no more
> squeaks from me.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Posted by Benson Margulies <bi...@gmail.com>.
Unfortunately for the coherence of this discussion, it was months and
months ago that I filed the original version of this JIRA. The best I
can lay my mental fingers on is this: for a large project, signing and
such can take a very long time, making it very slow and frustrating to
work through a set of problems. I was having a very hard time
debugging problems in release:prepare, and the addition of the profile
just added to my confusion.
That all being written, if my first encounter with the parent had been
documentation that explained what it was doing and why, I would never
have filed the JIRA in the first place. Which is why I already wrote,
and Olivier already committed, the explanatory material that I offered
to write to save others from the confusion I encountered when I first
used this parent. So if you all revert this change, honestly, no more
squeaks from me.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Posted by Brian Fox <br...@infinity.nu>.
On Tue, Feb 8, 2011 at 8:40 PM, Benson Margulies <bi...@gmail.com> wrote:
> Brian,
>
> As I recall, the apparent consensus of the prior thread was to, in
> fact, turn it off by default for 'asf' and move it to 'maven'. But I'm
> not the referee of consensus here, you are :-)
>
> My argument was that the global ASF pom should, by default, provide
> the minimum collection of settings for an ASF project that uses Maven.
> It shouldn't surprise projects with this profile.
Signing of releases and production of sources and javadocs is the
minimum for projects using Maven. What you describe is exactly the
intent of the parent.
Especially via
> <arguments> and not via useReleaseProfiles. I hardly have to write on
> this list that someone has to actively move from 8 to 9 to run into
> this change, so it's not as if it arrives as a magic surprise.
>
> I filed the report when I was completely befuddled in setting up maven
> on a new ASF project and getting the profile's behaviors on
> release:prepare, where I did not expect them at all. So, as a person
> who has worked on ASF-wide documentation for using Maven, I'm in favor
> of a one-time inconvenience for existing projects to reduce the
> confusion level for new projects.
I disagree. I've helped dozens of new projects getting setup to deploy
into the repo and picking up the new parent does all the work for them
out of the box. I think it's a matter of perspective where you expect
to see the signing, but simply because you don't want to see signing
during prepare, doesn't mean we need to break default behavior for
everyone.
I still maintain that signing during prepare is important because if
you aren't setup to correctly sign (for example you forgot to install
gpg) then it's better to know _before_ you have to go and revert a
bunch of tags and commits.
>
> If I turn out to lose this argument after all, I'll just write more
> documentation. I would also semi-seriously offer the idea of factoring
> out another layer of parent: asf-settings, that would really just set
> up the repos, and then asf, which would have the profile.
Again, after dozens of projects using this without problems, I fail to
see the complexity you describe. From my point of view, it works as
intended.
>
> If the patch sticks I need to make a patch to the site doc that I
> wrote for the POM, since it describes the presence of the profile :-)
>
> --benson
>
>
>
>
> On Tue, Feb 8, 2011 at 8:25 PM, Brian Fox <br...@infinity.nu> wrote:
>> Olivier, I think this still needs some discussion. What's the problem
>> with the activation of the release profile by default? Many Apache
>> projects depend up on this updated profile and if we just gank it out
>> to the Maven pom, it will break them all. I think perhaps we can make
>> it a property to make it easier for people to override with their own
>> profile, but we need to have this activated by default.
>>
>> On Mon, Jan 31, 2011 at 3:48 PM, <ol...@apache.org> wrote:
>>> Author: olamy
>>> Date: Mon Jan 31 20:48:26 2011
>>> New Revision: 1065772
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1065772&view=rev
>>> Log:
>>> [MPOM-1] apache-release does unwanted things in the prepare goal.
>>> move <arguments>-Papache-release</arguments> to maven parent pom.
>>>
>>> Modified:
>>> maven/pom/trunk/asf/pom.xml
>>> maven/pom/trunk/maven/pom.xml
>>>
>>> Modified: maven/pom/trunk/asf/pom.xml
>>> URL: http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff
>>> ==============================================================================
>>> --- maven/pom/trunk/asf/pom.xml (original)
>>> +++ maven/pom/trunk/asf/pom.xml Mon Jan 31 20:48:26 2011
>>> @@ -189,8 +189,7 @@ under the License.
>>> <version>2.1</version>
>>> <configuration>
>>> <useReleaseProfile>false</useReleaseProfile>
>>> - <goals>deploy</goals>
>>> - <arguments>-Papache-release</arguments>
>>> + <goals>deploy</goals>
>>> </configuration>
>>> </plugin>
>>> <!-- END SNIPPET: release-plugin-configuration -->
>>>
>>> Modified: maven/pom/trunk/maven/pom.xml
>>> URL: http://svn.apache.org/viewvc/maven/pom/trunk/maven/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff
>>> ==============================================================================
>>> --- maven/pom/trunk/maven/pom.xml (original)
>>> +++ maven/pom/trunk/maven/pom.xml Mon Jan 31 20:48:26 2011
>>> @@ -593,6 +593,20 @@ under the License.
>>> <url>scp://people.apache.org/www/maven.apache.org</url>
>>> </site>
>>> </distributionManagement>
>>> +
>>> + <build>
>>> + <pluginManagement>
>>> + <plugins>
>>> + <plugin>
>>> + <groupId>org.apache.maven.plugins</groupId>
>>> + <artifactId>maven-release-plugin</artifactId>
>>> + <configuration>
>>> + <arguments>-Papache-release</arguments>
>>> + </configuration>
>>> + </plugin>
>>> + </plugins>
>>> + </pluginManagement>
>>> + </build>
>>>
>>> <reporting>
>>> <plugins>
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Posted by Benson Margulies <bi...@gmail.com>.
Brian,
As I recall, the apparent consensus of the prior thread was to, in
fact, turn it off by default for 'asf' and move it to 'maven'. But I'm
not the referee of consensus here, you are :-)
My argument was that the global ASF pom should, by default, provide
the minimum collection of settings for an ASF project that uses Maven.
It shouldn't surprise projects with this profile. Especially via
<arguments> and not via useReleaseProfiles. I hardly have to write on
this list that someone has to actively move from 8 to 9 to run into
this change, so it's not as if it arrives as a magic surprise.
I filed the report when I was completely befuddled in setting up maven
on a new ASF project and getting the profile's behaviors on
release:prepare, where I did not expect them at all. So, as a person
who has worked on ASF-wide documentation for using Maven, I'm in favor
of a one-time inconvenience for existing projects to reduce the
confusion level for new projects.
If I turn out to lose this argument after all, I'll just write more
documentation. I would also semi-seriously offer the idea of factoring
out another layer of parent: asf-settings, that would really just set
up the repos, and then asf, which would have the profile.
If the patch sticks I need to make a patch to the site doc that I
wrote for the POM, since it describes the presence of the profile :-)
--benson
On Tue, Feb 8, 2011 at 8:25 PM, Brian Fox <br...@infinity.nu> wrote:
> Olivier, I think this still needs some discussion. What's the problem
> with the activation of the release profile by default? Many Apache
> projects depend up on this updated profile and if we just gank it out
> to the Maven pom, it will break them all. I think perhaps we can make
> it a property to make it easier for people to override with their own
> profile, but we need to have this activated by default.
>
> On Mon, Jan 31, 2011 at 3:48 PM, <ol...@apache.org> wrote:
>> Author: olamy
>> Date: Mon Jan 31 20:48:26 2011
>> New Revision: 1065772
>>
>> URL: http://svn.apache.org/viewvc?rev=1065772&view=rev
>> Log:
>> [MPOM-1] apache-release does unwanted things in the prepare goal.
>> move <arguments>-Papache-release</arguments> to maven parent pom.
>>
>> Modified:
>> maven/pom/trunk/asf/pom.xml
>> maven/pom/trunk/maven/pom.xml
>>
>> Modified: maven/pom/trunk/asf/pom.xml
>> URL: http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff
>> ==============================================================================
>> --- maven/pom/trunk/asf/pom.xml (original)
>> +++ maven/pom/trunk/asf/pom.xml Mon Jan 31 20:48:26 2011
>> @@ -189,8 +189,7 @@ under the License.
>> <version>2.1</version>
>> <configuration>
>> <useReleaseProfile>false</useReleaseProfile>
>> - <goals>deploy</goals>
>> - <arguments>-Papache-release</arguments>
>> + <goals>deploy</goals>
>> </configuration>
>> </plugin>
>> <!-- END SNIPPET: release-plugin-configuration -->
>>
>> Modified: maven/pom/trunk/maven/pom.xml
>> URL: http://svn.apache.org/viewvc/maven/pom/trunk/maven/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff
>> ==============================================================================
>> --- maven/pom/trunk/maven/pom.xml (original)
>> +++ maven/pom/trunk/maven/pom.xml Mon Jan 31 20:48:26 2011
>> @@ -593,6 +593,20 @@ under the License.
>> <url>scp://people.apache.org/www/maven.apache.org</url>
>> </site>
>> </distributionManagement>
>> +
>> + <build>
>> + <pluginManagement>
>> + <plugins>
>> + <plugin>
>> + <groupId>org.apache.maven.plugins</groupId>
>> + <artifactId>maven-release-plugin</artifactId>
>> + <configuration>
>> + <arguments>-Papache-release</arguments>
>> + </configuration>
>> + </plugin>
>> + </plugins>
>> + </pluginManagement>
>> + </build>
>>
>> <reporting>
>> <plugins>
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1065772 - in /maven/pom/trunk: asf/pom.xml maven/pom.xml
Posted by Brian Fox <br...@infinity.nu>.
Olivier, I think this still needs some discussion. What's the problem
with the activation of the release profile by default? Many Apache
projects depend up on this updated profile and if we just gank it out
to the Maven pom, it will break them all. I think perhaps we can make
it a property to make it easier for people to override with their own
profile, but we need to have this activated by default.
On Mon, Jan 31, 2011 at 3:48 PM, <ol...@apache.org> wrote:
> Author: olamy
> Date: Mon Jan 31 20:48:26 2011
> New Revision: 1065772
>
> URL: http://svn.apache.org/viewvc?rev=1065772&view=rev
> Log:
> [MPOM-1] apache-release does unwanted things in the prepare goal.
> move <arguments>-Papache-release</arguments> to maven parent pom.
>
> Modified:
> maven/pom/trunk/asf/pom.xml
> maven/pom/trunk/maven/pom.xml
>
> Modified: maven/pom/trunk/asf/pom.xml
> URL: http://svn.apache.org/viewvc/maven/pom/trunk/asf/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff
> ==============================================================================
> --- maven/pom/trunk/asf/pom.xml (original)
> +++ maven/pom/trunk/asf/pom.xml Mon Jan 31 20:48:26 2011
> @@ -189,8 +189,7 @@ under the License.
> <version>2.1</version>
> <configuration>
> <useReleaseProfile>false</useReleaseProfile>
> - <goals>deploy</goals>
> - <arguments>-Papache-release</arguments>
> + <goals>deploy</goals>
> </configuration>
> </plugin>
> <!-- END SNIPPET: release-plugin-configuration -->
>
> Modified: maven/pom/trunk/maven/pom.xml
> URL: http://svn.apache.org/viewvc/maven/pom/trunk/maven/pom.xml?rev=1065772&r1=1065771&r2=1065772&view=diff
> ==============================================================================
> --- maven/pom/trunk/maven/pom.xml (original)
> +++ maven/pom/trunk/maven/pom.xml Mon Jan 31 20:48:26 2011
> @@ -593,6 +593,20 @@ under the License.
> <url>scp://people.apache.org/www/maven.apache.org</url>
> </site>
> </distributionManagement>
> +
> + <build>
> + <pluginManagement>
> + <plugins>
> + <plugin>
> + <groupId>org.apache.maven.plugins</groupId>
> + <artifactId>maven-release-plugin</artifactId>
> + <configuration>
> + <arguments>-Papache-release</arguments>
> + </configuration>
> + </plugin>
> + </plugins>
> + </pluginManagement>
> + </build>
>
> <reporting>
> <plugins>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org