[GitHub] cjohn001 commented on issue #640: cordova-plugin-browsertab conflict with cordova android@7.1.3 and 7.1.4

[GitBox <gi...@apache.org>]

cjohn001 commented on issue #640: cordova-plugin-browsertab conflict with cordova android@7.1.3 and 7.1.4
URL: https://github.com/apache/cordova-android/issues/640#issuecomment-458114379
 
 
   Hello Brody,
   thanks for the analysis. However, the decision not to fix it, is somehow a pitty. Seems like this plugin is required to enable SSO in Cordova, like described here 
   
   https://www.youtube.com/watch?v=HKulxXDYJSs&feature=youtu.be
   
   I do not have the java background to maintain the plugin. So you say it is a bug in the plugin? The BrowserTab.gradle file which you reference says in the checkin comment, that it was a workaround regarding  a gradle issue with cordova. To me it is not clear what would have to be done to fix the issue here. 
   As far as I understood the discussion in #508, even though it shows not the resulting decision, the min version should be set via config.xml. In that case, would the fix than be simple as removing the BrowserTab.gradle file from the plugin? I assume, this would require, that the fix the file made in the past was previously in the meantime fixed in Cordova. Would be great if you could give me a hint on that, as I am currently stuck with Cordova 7.1.2 due to the issue.
   
   Best regards
    Christoph

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org