[GitHub] spark pull request: [SPARK-14102][CORE] Block `reset` command in S...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11920#discussion_r57231262
  
    --- Diff: repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
    @@ -75,11 +74,9 @@ class SparkILoop(in0: Option[BufferedReader], out: JPrintWriter)
         echo("Type :help for more information.")
       }
     
    -  import LoopCommand.{ cmd, nullary }
    -
    -  private val blockedCommands = Set("implicits", "javap", "power", "type", "kind")
    +  private val blockedCommands = Set("implicits", "javap", "power", "type", "kind", "reset")
    --- End diff --
    
    Oh I see, hm, this is not actually tricky to implement now. Well, it's not a crazy idea, anyone have opinions on blocking `:reset`? People really just shouldn't call it, and should restart the shell.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org