You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/18 14:29:08 UTC

[PR] fix(instance): recover from malformed route encoding [rocketmq-dashboard]

yyqdbngt opened a new pull request, #2357:
URL: https://github.com/apache/rocketmq-dashboard/pull/2357

   ## Summary
   
   - decode instance route segments without throwing on malformed percent encoding
   - treat an undecodable instance id as unknown so the existing instance-list fallback can recover the route
   - add a router-level regression test for a truncated encoded segment
   
   ## Root cause
   
   `useInstanceFilter` decoded the raw path segment during render with an unguarded `decodeURIComponent` call. Invalid input therefore raised a synchronous `URIError` before the hook could load instances and redirect to a valid selection.
   
   Closes #2346
   
   ## Validation
   
   - `npm test -- --run src/hooks/useInstanceFilter.test.tsx` (2 tests passed)
   - `npx eslint src/hooks/useInstanceFilter.ts src/hooks/useInstanceFilter.test.tsx`
   - `npm run build`
   - `git diff --check`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(instance): recover from malformed route encoding [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #2357:
URL: https://github.com/apache/rocketmq-dashboard/pull/2357


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org