[GitHub] [apisix] starsz commented on pull request #8148: feat(openid-connect): expose unauth_action parameter in lua-resty-openidc

[GitBox <gi...@apache.org>]

starsz commented on PR #8148:
URL: https://github.com/apache/apisix/pull/8148#issuecomment-1370423055

   > > > > @tzssangglass do you have the plan to help fix test cases of this PR?
   > > > 
   > > > 
   > > > Not at the moment, I'm not familiar enough with the openid-connect plugin.
   > > 
   > > 
   > > @starsz please take a look.
   > 
   > OK.I can help @jnystad fix the test cases in two weeks.
   
   Hi, @jnystad .
   Can you add permission to the repo that you cloned from Apache APISIX ?
   
   Or you can change as the follow to fix the CI.
   
   ```
   diff --git a/t/plugin/openid-connect2.t b/t/plugin/openid-connect2.t
   index 6b484c5b..40f6cadb 100644
   --- a/t/plugin/openid-connect2.t
   +++ b/t/plugin/openid-connect2.t
   @@ -260,7 +260,7 @@ passed
                local httpc = http.new()
                local uri = "http://127.0.0.1:" .. ngx.var.server_port .. "/hello"
                local res, err = httpc:request_uri(uri, {method = "GET"})
   -            if ngx.status == 200 then
   +            if res.status == 200 then
                    ngx.say(true)
                end
            }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org