You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/25 07:57:41 UTC
[GitHub] [spark] SaurabhChawla100 opened a new pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description utility method
SaurabhChawla100 opened a new pull request #29232:
URL: https://github.com/apache/spark/pull/29232
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
As the part of this PR https://github.com/apache/spark/pull/29045 added the helper method. This PR is the FOLLOWUP PR to update the description of helper method.
### Why are the changes needed?
For better readability and understanding of the code
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Since its only change of updating the description , So ran the Spark shell
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SaurabhChawla100 commented on a change in pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SaurabhChawla100 commented on a change in pull request #29232:
URL: https://github.com/apache/spark/pull/29232#discussion_r460642730
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -207,10 +207,19 @@ object OrcUtils extends Logging {
}
/**
- * @return Returns the result schema string based on the canPruneCols flag.
- * resultSchemaString will be created using resultsSchema in case of
- * canPruneCols is true and for canPruneCols as false value
- * resultSchemaString will be created using the actual dataSchema.
+ * This method returns the result schema as string based on the canPruneCols flag.
+ * resultSchemaString will be created using pruned col in case of
+ * canPruneCols is true and for canPruneCols as false value
+ * resultSchemaString will be created using the actual dataSchema.
+ * Also as the part of this method update the MAPRED_INPUT_SCHEMA
Review comment:
Updated the comment as suggested by @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664186785
**[Test build #126628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126628/testReport)** for PR 29232 at commit [`54bba19`](https://github.com/apache/spark/commit/54bba198772bc9590387bedfecc8539dc270f2d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664161620
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126609/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664116118
**[Test build #126609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126609/testReport)** for PR 29232 at commit [`54bba19`](https://github.com/apache/spark/commit/54bba198772bc9590387bedfecc8539dc270f2d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SaurabhChawla100 commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description utility method
Posted by GitBox <gi...@apache.org>.
SaurabhChawla100 commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663825624
cc @maropu @cloud-fan @dongjoon-hyun @gatorsmile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664161614
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663861344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664184338
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664191953
github action passes, merging to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #29232:
URL: https://github.com/apache/spark/pull/29232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664187337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664161092
**[Test build #126609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126609/testReport)** for PR 29232 at commit [`54bba19`](https://github.com/apache/spark/commit/54bba198772bc9590387bedfecc8539dc270f2d4).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663825900
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664114622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29232:
URL: https://github.com/apache/spark/pull/29232#discussion_r460629686
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -207,10 +207,19 @@ object OrcUtils extends Logging {
}
/**
- * @return Returns the result schema string based on the canPruneCols flag.
- * resultSchemaString will be created using resultsSchema in case of
- * canPruneCols is true and for canPruneCols as false value
- * resultSchemaString will be created using the actual dataSchema.
+ * This method returns the result schema as string based on the canPruneCols flag.
Review comment:
I would just write as:
Returns the result schema to read from ORC file. In addition, It sets the schema string to 'orc.mapred.input.schema' so ORC readers can use later.
and inline the details about parameters into the parameter descriptions below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663826003
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664114622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664161614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #29232:
URL: https://github.com/apache/spark/pull/29232#discussion_r460620360
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -207,10 +207,19 @@ object OrcUtils extends Logging {
}
/**
- * @return Returns the result schema string based on the canPruneCols flag.
- * resultSchemaString will be created using resultsSchema in case of
- * canPruneCols is true and for canPruneCols as false value
- * resultSchemaString will be created using the actual dataSchema.
+ * This method returns the result schema as string based on the canPruneCols flag.
+ * resultSchemaString will be created using pruned col in case of
+ * canPruneCols is true and for canPruneCols as false value
+ * resultSchemaString will be created using the actual dataSchema.
+ * Also as the part of this method update the MAPRED_INPUT_SCHEMA
Review comment:
`update the MAPRED_INPUT_SCHEMA` -> `updates the MAPRED_INPUT_SCHEMA in the given 'conf'`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664187337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663861344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SaurabhChawla100 commented on a change in pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SaurabhChawla100 commented on a change in pull request #29232:
URL: https://github.com/apache/spark/pull/29232#discussion_r460642632
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -207,10 +207,19 @@ object OrcUtils extends Logging {
}
/**
- * @return Returns the result schema string based on the canPruneCols flag.
- * resultSchemaString will be created using resultsSchema in case of
- * canPruneCols is true and for canPruneCols as false value
- * resultSchemaString will be created using the actual dataSchema.
+ * This method returns the result schema as string based on the canPruneCols flag.
Review comment:
that looks fine. Will update as suggested
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663825900
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663861101
**[Test build #126541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126541/testReport)** for PR 29232 at commit [`80ccedd`](https://github.com/apache/spark/commit/80ccedd2e133deefe0715ba99a20a1b50b0ada02).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663836254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663836763
**[Test build #126541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126541/testReport)** for PR 29232 at commit [`80ccedd`](https://github.com/apache/spark/commit/80ccedd2e133deefe0715ba99a20a1b50b0ada02).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663836134
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663836254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663826003
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-664116118
**[Test build #126609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126609/testReport)** for PR 29232 at commit [`54bba19`](https://github.com/apache/spark/commit/54bba198772bc9590387bedfecc8539dc270f2d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29232: [SPARK-32234][FOLLOWUP][SQL]Update the description of utility method
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29232:
URL: https://github.com/apache/spark/pull/29232#issuecomment-663836763
**[Test build #126541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/126541/testReport)** for PR 29232 at commit [`80ccedd`](https://github.com/apache/spark/commit/80ccedd2e133deefe0715ba99a20a1b50b0ada02).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org