You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/30 02:29:31 UTC

[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9712: [Bug] fix bug in time_round function

BiteTheDDDDt commented on code in PR #9712:
URL: https://github.com/apache/incubator-doris/pull/9712#discussion_r884375929


##########
be/src/vec/functions/function_datetime_floor_ceil.cpp:
##########
@@ -158,6 +158,9 @@ struct FloorCeilImpl {
     }
 };
 
+#define FLOOR 0

Review Comment:
   It's better to use `constexpr` to avoid `define`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org