[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3076: Call FSDataOutputStream.setDropBehind for WAL files

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #3076:
URL: https://github.com/apache/accumulo/pull/3076#discussion_r1021878316


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java:
##########
@@ -417,6 +417,13 @@ public synchronized void open(String address) throws IOException {
       else
         logFile = fs.create(logfilePath, true, 0, replication, blockSize);
 
+      // Tell the DataNode that the write ahead log does not need to be cached in the OS page cache
+      try {
+        logFile.setDropBehind(Boolean.TRUE);

Review Comment:
   It's weird that the API parameter is a nullable `Boolean` and not the primitive `boolean`. I see that it is marked `@InterfaceStability.Evolving`, but it has been present since at least 3.0.0, so I think it's probably fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org