[GitHub] [pinot] kkrugler commented on a diff in pull request #8802: Fix metadata push mode in IngestionUtils

[GitBox <gi...@apache.org>]

kkrugler commented on code in PR #8802:
URL: https://github.com/apache/pinot/pull/8802#discussion_r888165227


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/IngestionUtils.java:
##########
@@ -240,7 +240,7 @@ public static void uploadSegment(String tableNameWithType, BatchConfig batchConf
           }
           PinotFS outputFileFS = getOutputPinotFS(batchConfig, outputSegmentDirURI);
           Map<String, String> segmentUriToTarPathMap = SegmentPushUtils.getSegmentUriToTarPathMap(outputSegmentDirURI,
-              segmentUploadSpec.getPushJobSpec(), new String[] { segmentTarURIs.toString() });
+              segmentUploadSpec.getPushJobSpec(), segmentTarURIStrs.toArray(String[]::new));

Review Comment:
   @lksvenoy-r7 - sorry, my bad...I was focused on Richard's review comment, not the actual bug of using `segmentTarURIs.toString()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org