You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/08/31 05:45:31 UTC

[GitHub] [spark] Hisoka-X commented on a diff in pull request #42744: [SPARK-44990][SQL][FOLLOWUP] Add benchmark for write null value to csv

Hisoka-X commented on code in PR #42744:
URL: https://github.com/apache/spark/pull/42744#discussion_r1311120674


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVBenchmark.scala:
##########
@@ -72,7 +72,6 @@ object CSVBenchmark extends SqlBasedBenchmark {
     withTempPath { path =>
       val fields = Seq.tabulate(colsNum)(i => StructField(s"col$i", IntegerType))
       val schema = StructType(fields)
-      val values = (0 until colsNum).map(i => i.toString).mkString(",")

Review Comment:
   This local variable never used, so I removed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org