You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/07/20 14:08:56 UTC

[GitHub] [incubator-apisix] yongboy opened a new pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

yongboy opened a new pull request #1874:
URL: https://github.com/apache/incubator-apisix/pull/1874


   ### What this PR does / why we need it:
   
   We missing the apisix's lua code style guide when writing a plugin, fixing the code bug.
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [x] Is this PR backward compatible?
   
   ### Summary
   
   1. Adding `CODE_STYLE.md` base on `https://github.com/apache/incubator-apisix/blob/v1.2/CODE_STYLE.md`, and change it for meeting APISIX project
   2. Adding `CODE_STYLE_CN.md` base on `https://juejin.im/post/5d71f9bcf265da03b76b437c`, and change it for readable :))
   3. Fixing the `CODE_STYLE_CN.md` invalid path bug within `doc/zh-cn/README.md`
   
   ### Issues resolved
   
   Fix #1846


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1874:
URL: https://github.com/apache/incubator-apisix/pull/1874#issuecomment-663986356


   @yongboy many thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] yongboy commented on pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

Posted by GitBox <gi...@apache.org>.
yongboy commented on pull request #1874:
URL: https://github.com/apache/incubator-apisix/pull/1874#issuecomment-661705825


   Removed line 20's trailing whitespace with the commit: 
   https://github.com/apache/incubator-apisix/pull/1874/commits/a0ae4c1574aa1b7373c85e4794867f808c089eeb
   
   But the CI still tell me the error:
   
   ```bash
     [./CODE_STYLE_CN.md]:
         20: line has trailing whitespace.
   ```
   
   Checking the `CODE_STYLE_CN.md` line 20, you can't find the trailing whitespace now:
   
   ![image](https://user-images.githubusercontent.com/548385/88029280-646d1b80-cb6c-11ea-958f-572a9040af59.png)
   
   What should I do now ?
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1874:
URL: https://github.com/apache/incubator-apisix/pull/1874#issuecomment-661737567


   works fine at my local machine. I will rerun the Github Action.
   
   ```
   Reading configuration file [.travis/ASF-Release.cfg]...
   Scanning files starting at [./]...
   All checks passed.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1874:
URL: https://github.com/apache/incubator-apisix/pull/1874#issuecomment-661599920


   @yongboy 
   ```
   Scan detected 1 error(s) in 1 file(s):
     [./CODE_STYLE_CN.md]:
         20: line has trailing whitespace.
   ```
   please fix the code style, which blocked CI.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming merged pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1874:
URL: https://github.com/apache/incubator-apisix/pull/1874


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org