You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2013/12/08 22:14:22 UTC

[jira] [Comment Edited] (HBASE-10101) testOfflineRegionReAssginedAfterMasterRestart times out sometimes.

    [ https://issues.apache.org/jira/browse/HBASE-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842710#comment-13842710 ] 

Jimmy Xiang edited comment on HBASE-10101 at 12/8/13 9:12 PM:
--------------------------------------------------------------

How about we do it this way? We add some function like setLastRegionServerOfRegion(..) to RegionStates and call it in AM#processRegionsInTransition around line 621 to reset the last region server of the region transitioning on a dead server to the dead server.

Patch v2 is good. It's kind of a safety net to cover all scenarios. That means it may hide some issues we may not know yet, if any. That's why I think it may be better to fix it in AM#processRegionsInTransition which is the place we know we missed something there. What do you think?


was (Author: jxiang):
How about we do it this way? We add some function like setLastRegionServerOfRegion(..) to RegionStates and call it in AM#processRegionsInTransition around line 621 to reset the last region server of the region on a dead server to the dead server.

Patch v2 is good. It's kind of a safety net to cover all scenarios. That means it may hide some issues we may not know yet, if any. That's why I think it may be better to fix it in AM#processRegionsInTransition which is the place we know we missed something there. What do you think?

> testOfflineRegionReAssginedAfterMasterRestart times out sometimes.
> ------------------------------------------------------------------
>
>                 Key: HBASE-10101
>                 URL: https://issues.apache.org/jira/browse/HBASE-10101
>             Project: HBase
>          Issue Type: Test
>            Reporter: Jimmy Xiang
>            Assignee: Jeffrey Zhong
>            Priority: Minor
>         Attachments: hbase-10101-v2.patch, hbase-10101.patch, test.log
>
>
> Sometimes, I got this test timed out. The log is attached. It could be because the new cluster takes a while to process the dead server, or assign meta.



--
This message was sent by Atlassian JIRA
(v6.1#6144)