You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/08/22 02:35:50 UTC
[GitHub] wu-sheng commented on a change in pull request #1571: Support ojdbc8
wu-sheng commented on a change in pull request #1571: Support ojdbc8
URL: https://github.com/apache/incubator-skywalking/pull/1571#discussion_r211814437
##########
File path: apm-sniffer/apm-sdk-plugin/oracle-10.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/oracle/define/ConnectionInstrumentation.java
##########
@@ -111,6 +110,6 @@
}
@Override protected ClassMatch enhanceClass() {
- return NameMatch.byName(ENHANCE_CLASS);
+ return MultiClassNameMatch.byMultiClassMatch(ENHANCE_CLASS, "oracle.jdbc.driver.T4CConnection");
Review comment:
You are using a different coding style. Do you prefer to use a static field or literal string? I am OK with either, but don't use them at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services