You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by GitBox <gi...@apache.org> on 2020/06/13 11:10:43 UTC
[GitHub] [xerces-c] rleigh-codelibre opened a new pull request #21: XERCESC-2208: Use cstdint and standard integer types
rleigh-codelibre opened a new pull request #21:
URL: https://github.com/apache/xerces-c/pull/21
* Unconditionally use `<cstdint>`. Also use `<cstddef>` and `<cwchar>`.
* Remove Autoconf and CMake integer checks
* Move constant type definitions out of `Xerces_autoconf_config.hpp` into `XercesDefs.hpp`
* `UTF16Ch` and `UCS4Ch` are typedefs for `char16_t` and `char32_t`, so are now using the language types specifically intended for the purpose
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] boris-kolpackov commented on pull request #21: XERCESC-2208: Use cstdint and standard integer types
Posted by GitBox <gi...@apache.org>.
boris-kolpackov commented on pull request #21:
URL: https://github.com/apache/xerces-c/pull/21#issuecomment-644041115
I tend to think this (and other similar changes) can only go into 4.0.0. Should we make `master` explicitly 4-series?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre commented on pull request #21: XERCESC-2208: Use cstdint and standard integer types
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on pull request #21:
URL: https://github.com/apache/xerces-c/pull/21#issuecomment-644083383
Hi Boris,
I think that's a good idea, and I think that Scott would also prefer it as well from the current discussion.
Thanks,
Roger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre commented on pull request #21: XERCESC-2208: Use cstdint and standard integer types
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on pull request #21:
URL: https://github.com/apache/xerces-c/pull/21#issuecomment-924647083
Rebased against current master (no source changes). If there are no objections to merging, will merge later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre merged pull request #21: XERCESC-2208: Use cstdint and standard integer types
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre merged pull request #21:
URL: https://github.com/apache/xerces-c/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre commented on pull request #21: XERCESC-2208: Use cstdint and standard integer types
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on pull request #21:
URL: https://github.com/apache/xerces-c/pull/21#issuecomment-643648121
Tested on additional 32-bit platform (Debian 10, GCC 8.3) and it builds without error, and XSValue and all the other tests are passing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] rleigh-codelibre commented on pull request #21: XERCESC-2208: Use cstdint and standard integer types
Posted by GitBox <gi...@apache.org>.
rleigh-codelibre commented on pull request #21:
URL: https://github.com/apache/xerces-c/pull/21#issuecomment-644368941
I've done the version update to 4.0.0 on the master branch. If you're happy to proceed with this change, it should be OK to go in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org
[GitHub] [xerces-c] scantor commented on pull request #21: XERCESC-2208: Use cstdint and standard integer types
Posted by GitBox <gi...@apache.org>.
scantor commented on pull request #21:
URL: https://github.com/apache/xerces-c/pull/21#issuecomment-644088451
I don't have any particular preference, but given that it's unlikely everything you might want to do will be possible without an API change, I'm sure it's simplest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org