You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ephraimbuddy (via GitHub)" <gi...@apache.org> on 2024/07/29 14:27:52 UTC

[PR] Minor updates to the release guides [airflow]

ephraimbuddy opened a new pull request, #41100:
URL: https://github.com/apache/airflow/pull/41100

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #41100:
URL: https://github.com/apache/airflow/pull/41100#discussion_r1696207157


##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -561,10 +564,10 @@ done
 # Remove old release
 cd ..
 svn rm ${PREVIOUS_VERSION}
-svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${RC}"
+svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${VERSION}${VERSION_SUFFIX}"
 ```
 
-Verify that the packages appear in [airflow](https://downloads.apache.org/airflow/clients/python/)
+Verify that the packages appear in [airflow](https://dist.apache.org/repos/dist/release/airflow/clients/python)

Review Comment:
   > The downloads link takes a little bit of time to update
   
   Strange - it should not be (any more). It used to be like that, before ASF Switched to use CDN some 1.5 years ago - since then I never saw a delay. Maybe it's just the matter of Shift-Refresh? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy merged PR #41100:
URL: https://github.com/apache/airflow/pull/41100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #41100:
URL: https://github.com/apache/airflow/pull/41100#discussion_r1695342822


##########
dev/breeze/src/airflow_breeze/commands/minor_release_command.py:
##########
@@ -69,7 +69,7 @@ def commit_changes(version_branch):
         if DRY_RUN:
             console_print("Skipping below command on CI")
         run_command(
-            ["git", "commit", "-m", f"Update default branches for {version_branch}"],
+            ["git", "commit", "-m", f"Update default branches for {version_branch}", "--no-verify"],

Review Comment:
   Allowing this to run `pre-commit` gives room to updating hashes which we can do in a separate commit 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #41100:
URL: https://github.com/apache/airflow/pull/41100#discussion_r1695543004


##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -315,11 +315,11 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
 
 - Create issue in github for testing the release using this subject:
 
-  ```shell script
-  cat <<EOF
-  Status of testing of Apache Airflow {VERSION}
-  EOF
-  ```

Review Comment:
   It wasn't looking good on my IDE. The 'cat' command was not coloured. I will revert this change since it moved out of the indentation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #41100:
URL: https://github.com/apache/airflow/pull/41100#discussion_r1696381139


##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -561,10 +564,10 @@ done
 # Remove old release
 cd ..
 svn rm ${PREVIOUS_VERSION}
-svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${RC}"
+svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${VERSION}${VERSION_SUFFIX}"
 ```
 
-Verify that the packages appear in [airflow](https://downloads.apache.org/airflow/clients/python/)
+Verify that the packages appear in [airflow](https://dist.apache.org/repos/dist/release/airflow/clients/python)

Review Comment:
   During the last Python client release, it took some minutes before reflecting while the dist was available immediately, and that helped in confirming that everything worked fine



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #41100:
URL: https://github.com/apache/airflow/pull/41100#discussion_r1696208126


##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -561,10 +564,10 @@ done
 # Remove old release
 cd ..
 svn rm ${PREVIOUS_VERSION}
-svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${RC}"
+svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${VERSION}${VERSION_SUFFIX}"
 ```
 
-Verify that the packages appear in [airflow](https://downloads.apache.org/airflow/clients/python/)
+Verify that the packages appear in [airflow](https://dist.apache.org/repos/dist/release/airflow/clients/python)

Review Comment:
   But it does not matter. really :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #41100:
URL: https://github.com/apache/airflow/pull/41100#discussion_r1695484216


##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -315,11 +315,11 @@ The Release Candidate artifacts we vote upon should be the exact ones we vote ag
 
 - Create issue in github for testing the release using this subject:
 
-  ```shell script
-  cat <<EOF
-  Status of testing of Apache Airflow {VERSION}
-  EOF
-  ```

Review Comment:
   nit: Any reason for this change?
   
   This change before puts the code-block under the bullets with same indent



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #41100:
URL: https://github.com/apache/airflow/pull/41100#discussion_r1696383757


##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -561,10 +564,10 @@ done
 # Remove old release
 cd ..
 svn rm ${PREVIOUS_VERSION}
-svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${RC}"
+svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${VERSION}${VERSION_SUFFIX}"
 ```
 
-Verify that the packages appear in [airflow](https://downloads.apache.org/airflow/clients/python/)
+Verify that the packages appear in [airflow](https://dist.apache.org/repos/dist/release/airflow/clients/python)

Review Comment:
   I see . Interesting :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor updates to the release guides [airflow]

Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #41100:
URL: https://github.com/apache/airflow/pull/41100#discussion_r1695340371


##########
dev/README_RELEASE_PYTHON_CLIENT.md:
##########
@@ -561,10 +564,10 @@ done
 # Remove old release
 cd ..
 svn rm ${PREVIOUS_VERSION}
-svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${RC}"
+svn commit -m "Release Apache Airflow Python Client ${VERSION} from ${VERSION}${VERSION_SUFFIX}"
 ```
 
-Verify that the packages appear in [airflow](https://downloads.apache.org/airflow/clients/python/)
+Verify that the packages appear in [airflow](https://dist.apache.org/repos/dist/release/airflow/clients/python)

Review Comment:
   The downloads link takes a little bit of time to update



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org