You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/09 04:15:03 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #17698: refactor(monorepo): change coverage of core to 100%
zhaoyongjie opened a new pull request #17698:
URL: https://github.com/apache/superset/pull/17698
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
WIP
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0f198d) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.38%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head e0f198d differs from pull request most recent head 0463ee6. Consider uploading reports for the commit 0463ee6 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.74% -0.39%
==========================================
Files 1653 1602 -51
Lines 66247 64099 -2148
Branches 7107 6772 -335
==========================================
- Hits 45138 43426 -1712
+ Misses 19220 18818 -402
+ Partials 1889 1855 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.82% <100.00%> (-1.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `100.00% <100.00%> (+7.14%)` | :arrow_up: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
| [...ugins/legacy-preset-chart-big-number/src/preset.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL3ByZXNldC50cw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/Line/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0xpbmUvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/ScatterPlot/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ns/preset-chart-xy/src/ScatterPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2xlZ2FjeS9pbmRleC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...hart-big-number/src/BigNumberTotal/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL0JpZ051bWJlclRvdGFsL2NvbnRyb2xQYW5lbC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lugins/preset-chart-xy/src/BoxPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-62.50%)` | :arrow_down: |
| [...gins/preset-chart-xy/src/BoxPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvY3JlYXRlTWV0YWRhdGEudHM=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [.../preset-chart-xy/src/ScatterPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2NyZWF0ZU1ldGFkYXRhLnRz) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...0463ee6](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ed0026) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 68.13% -0.01%
==========================================
Files 1653 1653
Lines 66247 66246 -1
Branches 7107 7107
==========================================
- Hits 45138 45137 -1
Misses 19220 19220
Partials 1889 1889
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `56.29% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `92.59% <100.00%> (-0.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...3ed0026](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #17698:
URL: https://github.com/apache/superset/pull/17698#discussion_r781504170
##########
File path: .codecov.yml
##########
@@ -16,7 +16,7 @@ coverage:
target: auto
threshold: 0%
core-packages-ts:
- target: 95%
+ target: 100%
Review comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ commented on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-993205244
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17698:
URL: https://github.com/apache/superset/pull/17698#discussion_r765503585
##########
File path: superset-frontend/packages/superset-ui-core/src/color/CategoricalColorNamespace.ts
##########
@@ -40,12 +40,7 @@ export default class CategoricalColorNamespace {
getScale(schemeId?: string) {
const id = schemeId ?? getCategoricalSchemeRegistry().getDefaultKey() ?? '';
const scheme = getCategoricalSchemeRegistry().get(id);
- const newScale = new CategoricalColorScale(
- scheme?.colors ?? [],
- this.forcedItems,
- );
-
- return newScale;
+ return new CategoricalColorScale(scheme?.colors ?? [], this.forcedItems);
Review comment:
reformat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17698:
URL: https://github.com/apache/superset/pull/17698#discussion_r767084878
##########
File path: superset-frontend/packages/superset-ui-core/test/utils/logging.test.ts
##########
@@ -21,40 +21,41 @@
describe('logging', () => {
beforeEach(() => {
jest.resetModules();
- // Explicit is better than implicit
- console.warn = console.error = function mockedConsole(message) {
- throw new Error(message);
- };
+ jest.resetAllMocks();
});
+
it('should pipe to `console` methods', () => {
- const { logging } = require('@superset-ui/core/src');
+ const { logging } = require('@superset-ui/core');
+ jest.spyOn(logging, 'debug').mockImplementation();
+ jest.spyOn(logging, 'log').mockImplementation();
+ jest.spyOn(logging, 'info').mockImplementation();
expect(() => {
logging.debug();
logging.log();
logging.info();
}).not.toThrow();
- expect(() => {
- logging.warn('warn');
- }).toThrow('warn');
- expect(() => {
- logging.error('error');
- }).toThrow('error');
Review comment:
mock console output, to make clear test output.
### before
```
(superset) yongjie.zhao@:superset-frontend$ rm -rf coverage && npx jest --clearCache && NODE_ENV=test npx jest packages/superset-ui-core/test/utils/logging.test.ts
Cleared /private/var/folders/10/0l8mvpf52jx6t3p68mndwn7m0000gn/T/jest_dx
PASS packages/superset-ui-core/test/utils/logging.test.ts (9.898 s)
logging
✓ should pipe to `console` methods (4487 ms)
✓ should use noop functions when console unavailable (72 ms)
console.debug
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:33:15
console.log
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:34:15
console.info
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:35:15
Test Suites: 1 passed, 1 total
Tests: 2 passed, 2 total
Snapshots: 0 total
Time: 10.875 s
Ran all test suites matching /packages\/superset-ui-core\/test\/utils\/logging.test.ts/i.
```
### After
```
(superset) yongjie.zhao@:superset-frontend$ rm -rf coverage && npx jest --clearCache && NODE_ENV=test npx jest packages/superset-ui-core/test/utils/logging.test.ts
Cleared /private/var/folders/10/0l8mvpf52jx6t3p68mndwn7m0000gn/T/jest_dx
PASS packages/superset-ui-core/test/utils/logging.test.ts (8.997 s)
logging
✓ should pipe to `console` methods (4409 ms)
✓ should use noop functions when console unavailable (84 ms)
Test Suites: 1 passed, 1 total
Tests: 2 passed, 2 total
Snapshots: 0 total
Time: 9.707 s
Ran all test suites matching /packages\/superset-ui-core\/test\/utils\/logging.test.ts/i.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17698:
URL: https://github.com/apache/superset/pull/17698#discussion_r767928828
##########
File path: superset-frontend/packages/superset-ui-core/src/connection/SupersetClientClass.ts
##########
@@ -33,13 +33,6 @@ import {
} from './types';
import { DEFAULT_FETCH_RETRY_OPTIONS, DEFAULT_BASE_URL } from './constants';
-function redirectUnauthorized() {
Review comment:
The function move into class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de3a153) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.36%`.
> The diff coverage is `69.06%`.
> :exclamation: Current head de3a153 differs from pull request most recent head fda8acf. Consider uploading reports for the commit fda8acf to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.77% -0.37%
==========================================
Files 1653 1602 -51
Lines 66247 64143 -2104
Branches 7107 6772 -335
==========================================
- Hits 45138 43471 -1667
+ Misses 19220 18818 -402
+ Partials 1889 1854 -35
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.84% <60.31%> (-1.46%)` | :arrow_down: |
| mysql | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `36.00% <0.00%> (-2.89%)` | :arrow_down: |
| [...ns/legacy-plugin-chart-heatmap/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhlYXRtYXAvc3JjL2NvbnRyb2xQYW5lbC50cw==) | `66.66% <ø> (-13.34%)` | :arrow_down: |
| [...nd/plugins/plugin-chart-table/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `16.66% <0.00%> (-5.18%)` | :arrow_down: |
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `68.85% <ø> (ø)` | |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `51.16% <0.00%> (+1.16%)` | :arrow_up: |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `46.57% <ø> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `71.87% <ø> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.27% <ø> (-0.10%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `35.79% <36.84%> (+0.45%)` | :arrow_up: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `61.53% <37.50%> (+2.51%)` | :arrow_up: |
| ... and [482 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...fda8acf](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0f198d) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.38%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head e0f198d differs from pull request most recent head 980ea40. Consider uploading reports for the commit 980ea40 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.74% -0.39%
==========================================
Files 1653 1602 -51
Lines 66247 64099 -2148
Branches 7107 6772 -335
==========================================
- Hits 45138 43426 -1712
+ Misses 19220 18818 -402
+ Partials 1889 1855 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.82% <100.00%> (-1.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `100.00% <100.00%> (+7.14%)` | :arrow_up: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
| [...ugins/legacy-preset-chart-big-number/src/preset.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL3ByZXNldC50cw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/Line/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0xpbmUvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/ScatterPlot/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ns/preset-chart-xy/src/ScatterPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2xlZ2FjeS9pbmRleC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...hart-big-number/src/BigNumberTotal/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL0JpZ051bWJlclRvdGFsL2NvbnRyb2xQYW5lbC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lugins/preset-chart-xy/src/BoxPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-62.50%)` | :arrow_down: |
| [...gins/preset-chart-xy/src/BoxPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvY3JlYXRlTWV0YWRhdGEudHM=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [.../preset-chart-xy/src/ScatterPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2NyZWF0ZU1ldGFkYXRhLnRz) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...980ea40](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf94383) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 68.09% -0.04%
==========================================
Files 1653 1653
Lines 66247 66326 +79
Branches 7107 7120 +13
==========================================
+ Hits 45138 45167 +29
- Misses 19220 19262 +42
- Partials 1889 1897 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `56.25% <100.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `92.59% <100.00%> (-0.27%)` | :arrow_down: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `76.92% <0.00%> (-0.75%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `73.07% <0.00%> (-0.61%)` | :arrow_down: |
| [...nd/plugins/plugin-chart-table/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `21.34% <0.00%> (-0.50%)` | :arrow_down: |
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `38.53% <0.00%> (-0.36%)` | :arrow_down: |
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LnRzeA==) | `67.15% <0.00%> (-0.26%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `86.33% <0.00%> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `71.87% <0.00%> (ø)` | |
| [...et-frontend/src/components/CertifiedIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2VydGlmaWVkSWNvbi9pbmRleC50c3g=) | | |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...bf94383](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ed0026) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 3ed0026 differs from pull request most recent head af2695c. Consider uploading reports for the commit af2695c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 68.13% -0.01%
==========================================
Files 1653 1653
Lines 66247 66246 -1
Branches 7107 7107
==========================================
- Hits 45138 45137 -1
Misses 19220 19220
Partials 1889 1889
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `56.29% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `92.59% <100.00%> (-0.27%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...af2695c](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af2695c) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
=======================================
Coverage 68.13% 68.13%
=======================================
Files 1653 1653
Lines 66247 66244 -3
Branches 7107 7106 -1
=======================================
- Hits 45138 45136 -2
+ Misses 19220 19219 -1
Partials 1889 1889
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `56.29% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `92.59% <100.00%> (-0.27%)` | :arrow_down: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...af2695c](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af2695c) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head af2695c differs from pull request most recent head 8fb761c. Consider uploading reports for the commit 8fb761c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
=======================================
Coverage 68.13% 68.13%
=======================================
Files 1653 1653
Lines 66247 66244 -3
Branches 7107 7106 -1
=======================================
- Hits 45138 45136 -2
+ Misses 19220 19219 -1
Partials 1889 1889
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `56.29% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `92.59% <100.00%> (-0.27%)` | :arrow_down: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...8fb761c](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0f198d) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.38%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.74% -0.39%
==========================================
Files 1653 1602 -51
Lines 66247 64099 -2148
Branches 7107 6772 -335
==========================================
- Hits 45138 43426 -1712
+ Misses 19220 18818 -402
+ Partials 1889 1855 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.82% <100.00%> (-1.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `100.00% <100.00%> (+7.14%)` | :arrow_up: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
| [...ugins/legacy-preset-chart-big-number/src/preset.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL3ByZXNldC50cw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/Line/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0xpbmUvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/ScatterPlot/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ns/preset-chart-xy/src/ScatterPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2xlZ2FjeS9pbmRleC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...hart-big-number/src/BigNumberTotal/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL0JpZ051bWJlclRvdGFsL2NvbnRyb2xQYW5lbC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lugins/preset-chart-xy/src/BoxPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-62.50%)` | :arrow_down: |
| [...gins/preset-chart-xy/src/BoxPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvY3JlYXRlTWV0YWRhdGEudHM=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [.../preset-chart-xy/src/ScatterPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2NyZWF0ZU1ldGFkYXRhLnRz) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...e0f198d](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #17698:
URL: https://github.com/apache/superset/pull/17698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fb761c) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.38%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.74% -0.39%
==========================================
Files 1653 1602 -51
Lines 66247 64098 -2149
Branches 7107 6771 -336
==========================================
- Hits 45138 43425 -1713
+ Misses 19220 18818 -402
+ Partials 1889 1855 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.82% <100.00%> (-1.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `100.00% <100.00%> (+7.14%)` | :arrow_up: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
| [...ugins/legacy-preset-chart-big-number/src/preset.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL3ByZXNldC50cw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/Line/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0xpbmUvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/ScatterPlot/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ns/preset-chart-xy/src/ScatterPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2xlZ2FjeS9pbmRleC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...hart-big-number/src/BigNumberTotal/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL0JpZ051bWJlclRvdGFsL2NvbnRyb2xQYW5lbC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lugins/preset-chart-xy/src/BoxPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-62.50%)` | :arrow_down: |
| [...gins/preset-chart-xy/src/BoxPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvY3JlYXRlTWV0YWRhdGEudHM=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [.../preset-chart-xy/src/ScatterPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2NyZWF0ZU1ldGFkYXRhLnRz) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [450 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...8fb761c](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17698:
URL: https://github.com/apache/superset/pull/17698#discussion_r767079713
##########
File path: superset-frontend/packages/superset-ui-core/src/utils/random.ts
##########
@@ -16,15 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
-import seedrandom from 'seedrandom';
-
-let random = seedrandom('superset-ui');
+import _seedrandom from 'seedrandom';
export function seed(seed: string) {
- random = seedrandom(seed);
- return random;
+ return _seedrandom(seed);
}
export function seedRandom() {
- return random();
+ return _seedrandom('superset-ui')();
Review comment:
minor refactor, to avoid duplicate names(seedrandom).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #17698:
URL: https://github.com/apache/superset/pull/17698#discussion_r767079713
##########
File path: superset-frontend/packages/superset-ui-core/src/utils/random.ts
##########
@@ -16,15 +16,12 @@
* specific language governing permissions and limitations
* under the License.
*/
-import seedrandom from 'seedrandom';
-
-let random = seedrandom('superset-ui');
+import _seedrandom from 'seedrandom';
export function seed(seed: string) {
- random = seedrandom(seed);
- return random;
+ return _seedrandom(seed);
}
export function seedRandom() {
- return random();
+ return _seedrandom('superset-ui')();
Review comment:
minor refactor, to avoid duplicate names(seedrandom).
##########
File path: superset-frontend/packages/superset-ui-core/test/utils/logging.test.ts
##########
@@ -21,40 +21,41 @@
describe('logging', () => {
beforeEach(() => {
jest.resetModules();
- // Explicit is better than implicit
- console.warn = console.error = function mockedConsole(message) {
- throw new Error(message);
- };
+ jest.resetAllMocks();
});
+
it('should pipe to `console` methods', () => {
- const { logging } = require('@superset-ui/core/src');
+ const { logging } = require('@superset-ui/core');
+ jest.spyOn(logging, 'debug').mockImplementation();
+ jest.spyOn(logging, 'log').mockImplementation();
+ jest.spyOn(logging, 'info').mockImplementation();
expect(() => {
logging.debug();
logging.log();
logging.info();
}).not.toThrow();
- expect(() => {
- logging.warn('warn');
- }).toThrow('warn');
- expect(() => {
- logging.error('error');
- }).toThrow('error');
Review comment:
mock console output, to make clear test output.
### before
```
(superset) yongjie.zhao@:superset-frontend$ rm -rf coverage && npx jest --clearCache && NODE_ENV=test npx jest packages/superset-ui-core/test/utils/logging.test.ts
Cleared /private/var/folders/10/0l8mvpf52jx6t3p68mndwn7m0000gn/T/jest_dx
PASS packages/superset-ui-core/test/utils/logging.test.ts (9.898 s)
logging
✓ should pipe to `console` methods (4487 ms)
✓ should use noop functions when console unavailable (72 ms)
console.debug
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:33:15
console.log
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:34:15
console.info
undefined
at packages/superset-ui-core/test/utils/logging.test.ts:35:15
Test Suites: 1 passed, 1 total
Tests: 2 passed, 2 total
Snapshots: 0 total
Time: 10.875 s
Ran all test suites matching /packages\/superset-ui-core\/test\/utils\/logging.test.ts/i.
```
### After
```
(superset) yongjie.zhao@:superset-frontend$ rm -rf coverage && npx jest --clearCache && NODE_ENV=test npx jest packages/superset-ui-core/test/utils/logging.test.ts
Cleared /private/var/folders/10/0l8mvpf52jx6t3p68mndwn7m0000gn/T/jest_dx
PASS packages/superset-ui-core/test/utils/logging.test.ts (8.997 s)
logging
✓ should pipe to `console` methods (4409 ms)
✓ should use noop functions when console unavailable (84 ms)
Test Suites: 1 passed, 1 total
Tests: 2 passed, 2 total
Snapshots: 0 total
Time: 9.707 s
Ran all test suites matching /packages\/superset-ui-core\/test\/utils\/logging.test.ts/i.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de3a153) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.36%`.
> The diff coverage is `69.06%`.
> :exclamation: Current head de3a153 differs from pull request most recent head fda8acf. Consider uploading reports for the commit fda8acf to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.77% -0.37%
==========================================
Files 1653 1602 -51
Lines 66247 64143 -2104
Branches 7107 6772 -335
==========================================
- Hits 45138 43471 -1667
+ Misses 19220 18818 -402
+ Partials 1889 1854 -35
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.84% <60.31%> (-1.46%)` | :arrow_down: |
| mysql | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `36.00% <0.00%> (-2.89%)` | :arrow_down: |
| [...ns/legacy-plugin-chart-heatmap/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhlYXRtYXAvc3JjL2NvbnRyb2xQYW5lbC50cw==) | `66.66% <ø> (-13.34%)` | :arrow_down: |
| [...nd/plugins/plugin-chart-table/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `16.66% <0.00%> (-5.18%)` | :arrow_down: |
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `68.85% <ø> (ø)` | |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `51.16% <0.00%> (+1.16%)` | :arrow_up: |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `46.57% <ø> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `71.87% <ø> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.27% <ø> (-0.10%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `35.79% <36.84%> (+0.45%)` | :arrow_up: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `61.53% <37.50%> (+2.51%)` | :arrow_up: |
| ... and [482 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...fda8acf](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie closed pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
zhaoyongjie closed pull request #17698:
URL: https://github.com/apache/superset/pull/17698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf94383) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head bf94383 differs from pull request most recent head e0f198d. Consider uploading reports for the commit e0f198d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 68.09% -0.04%
==========================================
Files 1653 1653
Lines 66247 66326 +79
Branches 7107 7120 +13
==========================================
+ Hits 45138 45167 +29
- Misses 19220 19262 +42
- Partials 1889 1897 +8
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `56.25% <100.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `92.59% <100.00%> (-0.27%)` | :arrow_down: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `76.92% <0.00%> (-0.75%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `73.07% <0.00%> (-0.61%)` | :arrow_down: |
| [...nd/plugins/plugin-chart-table/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `21.34% <0.00%> (-0.50%)` | :arrow_down: |
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `38.53% <0.00%> (-0.36%)` | :arrow_down: |
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LnRzeA==) | `67.15% <0.00%> (-0.26%)` | :arrow_down: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `86.33% <0.00%> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `71.87% <0.00%> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | | |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...e0f198d](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fb761c) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.38%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 8fb761c differs from pull request most recent head bf94383. Consider uploading reports for the commit bf94383 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.74% -0.39%
==========================================
Files 1653 1602 -51
Lines 66247 64098 -2149
Branches 7107 6771 -336
==========================================
- Hits 45138 43425 -1713
+ Misses 19220 18818 -402
+ Partials 1889 1855 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.82% <100.00%> (-1.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `100.00% <100.00%> (+7.14%)` | :arrow_up: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
| [...ugins/legacy-preset-chart-big-number/src/preset.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL3ByZXNldC50cw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/Line/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0xpbmUvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/ScatterPlot/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ns/preset-chart-xy/src/ScatterPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2xlZ2FjeS9pbmRleC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...hart-big-number/src/BigNumberTotal/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL0JpZ051bWJlclRvdGFsL2NvbnRyb2xQYW5lbC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lugins/preset-chart-xy/src/BoxPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-62.50%)` | :arrow_down: |
| [...gins/preset-chart-xy/src/BoxPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvY3JlYXRlTWV0YWRhdGEudHM=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [.../preset-chart-xy/src/ScatterPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2NyZWF0ZU1ldGFkYXRhLnRz) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [450 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...bf94383](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de3a153) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.36%`.
> The diff coverage is `69.06%`.
> :exclamation: Current head de3a153 differs from pull request most recent head 0463ee6. Consider uploading reports for the commit 0463ee6 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.77% -0.37%
==========================================
Files 1653 1602 -51
Lines 66247 64143 -2104
Branches 7107 6772 -335
==========================================
- Hits 45138 43471 -1667
+ Misses 19220 18818 -402
+ Partials 1889 1854 -35
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.84% <60.31%> (-1.46%)` | :arrow_down: |
| mysql | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...et-ui-chart-controls/src/shared-controls/index.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3NoYXJlZC1jb250cm9scy9pbmRleC50c3g=) | `36.00% <0.00%> (-2.89%)` | :arrow_down: |
| [...ns/legacy-plugin-chart-heatmap/src/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhlYXRtYXAvc3JjL2NvbnRyb2xQYW5lbC50cw==) | `66.66% <ø> (-13.34%)` | :arrow_down: |
| [...nd/plugins/plugin-chart-table/src/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL2NvbnRyb2xQYW5lbC50c3g=) | `16.66% <0.00%> (-5.18%)` | :arrow_down: |
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `68.85% <ø> (ø)` | |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `51.16% <0.00%> (+1.16%)` | :arrow_up: |
| [...rc/explore/components/ExploreChartHeader/index.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRIZWFkZXIvaW5kZXguanN4) | `46.57% <ø> (ø)` | |
| [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz) | `71.87% <ø> (ø)` | |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.27% <ø> (-0.10%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `35.79% <36.84%> (+0.45%)` | :arrow_up: |
| [...frontend/src/dashboard/components/Header/index.jsx](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci9pbmRleC5qc3g=) | `61.53% <37.50%> (+2.51%)` | :arrow_up: |
| ... and [482 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...0463ee6](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17698: refactor(monorepo): change coverage of core to 100%
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17698:
URL: https://github.com/apache/superset/pull/17698#issuecomment-989524560
# [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17698](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fda8acf) into [master](https://codecov.io/gh/apache/superset/commit/04e3cfa6077faa84b07948fc6071e94d82a4a000?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04e3cfa) will **decrease** coverage by `0.38%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17698 +/- ##
==========================================
- Coverage 68.13% 67.75% -0.39%
==========================================
Files 1653 1602 -51
Lines 66247 64098 -2149
Branches 7107 6772 -335
==========================================
- Hits 45138 43430 -1708
+ Misses 19220 18815 -405
+ Partials 1889 1853 -36
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.84% <100.00%> (-1.46%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set-ui-core/src/color/CategoricalColorNamespace.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvQ2F0ZWdvcmljYWxDb2xvck5hbWVzcGFjZS50cw==) | `100.00% <100.00%> (+7.14%)` | :arrow_up: |
| [...rset-ui-core/src/connection/SupersetClientClass.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29ubmVjdGlvbi9TdXBlcnNldENsaWVudENsYXNzLnRz) | `100.00% <100.00%> (+9.23%)` | :arrow_up: |
| [...tend/packages/superset-ui-core/src/utils/random.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvcmFuZG9tLnRz) | `100.00% <100.00%> (+16.66%)` | :arrow_up: |
| [...ugins/legacy-preset-chart-big-number/src/preset.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL3ByZXNldC50cw==) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/Line/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0xpbmUvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...d/plugins/preset-chart-xy/src/ScatterPlot/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2luZGV4LnRz) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ns/preset-chart-xy/src/ScatterPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL1NjYXR0ZXJQbG90L2xlZ2FjeS9pbmRleC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...hart-big-number/src/BigNumberTotal/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWJpZy1udW1iZXIvc3JjL0JpZ051bWJlclRvdGFsL2NvbnRyb2xQYW5lbC50cw==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...lugins/preset-chart-xy/src/BoxPlot/legacy/index.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvbGVnYWN5L2luZGV4LnRz) | `0.00% <0.00%> (-62.50%)` | :arrow_down: |
| [...gins/preset-chart-xy/src/BoxPlot/createMetadata.ts](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wcmVzZXQtY2hhcnQteHkvc3JjL0JveFBsb3QvY3JlYXRlTWV0YWRhdGEudHM=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [454 more](https://codecov.io/gh/apache/superset/pull/17698/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [04e3cfa...fda8acf](https://codecov.io/gh/apache/superset/pull/17698?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org