You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/10/20 12:52:35 UTC
[GitHub] [incubator-streampark] MonsterChenzhuo opened a new pull request, #1877: [bug]Resolve the problem that the flink jobid stored in the trackid i…
MonsterChenzhuo opened a new pull request, #1877:
URL: https://github.com/apache/incubator-streampark/pull/1877
…s empty
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #1841 #1423
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] MonsterChenzhuo commented on pull request #1877: [bug]Resolve the problem that the flink jobid stored in the trackid i…
Posted by GitBox <gi...@apache.org>.
MonsterChenzhuo commented on PR #1877:
URL: https://github.com/apache/incubator-streampark/pull/1877#issuecomment-1287797174
@wolfboys Thanks for the huge review work, I have revised all your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on pull request #1877: [bug]Resolve the problem that the flink jobid stored in the trackid i…
Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1877:
URL: https://github.com/apache/incubator-streampark/pull/1877#issuecomment-1286481906
> hi @wolfboys ，I have made the update and can continue with the code review
thanks for your contribution, I'll review it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] MonsterChenzhuo commented on pull request #1877: [bug]Resolve the problem that the flink jobid stored in the trackid i…
Posted by GitBox <gi...@apache.org>.
MonsterChenzhuo commented on PR #1877:
URL: https://github.com/apache/incubator-streampark/pull/1877#issuecomment-1286479982
hi @wolfboys ，I have made the update and can continue with the code review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #1877: [bug]Resolve the problem that the flink jobid stored in the trackid i…
Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #1877:
URL: https://github.com/apache/incubator-streampark/pull/1877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1877: [bug]Resolve the problem that the flink jobid stored in the trackid i…
Posted by GitBox <gi...@apache.org>.
wolfboys commented on code in PR #1877:
URL: https://github.com/apache/incubator-streampark/pull/1877#discussion_r1002295897
##########
streampark-common/src/main/scala/org/apache/streampark/common/conf/ConfigConst.scala:
##########
@@ -48,6 +48,8 @@ object ConfigConst {
val KEY_JOB_ID = "jobId"
+ val KEY_FLINK_JOB_ID = "flinkJobId"
Review Comment:
hi MonsterChenzhuo:
I recommend to add `id` and `jobId` field in `SubmitRequest`, Don't add it to the global constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org