You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/19 08:31:56 UTC
[GitHub] [dolphinscheduler] huangchenguang123 opened a new pull request, #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
huangchenguang123 opened a new pull request, #10127:
URL: https://github.com/apache/dolphinscheduler/pull/10127
fix #10126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 closed pull request #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
Posted by GitBox <gi...@apache.org>.
huangchenguang123 closed pull request #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
URL: https://github.com/apache/dolphinscheduler/pull/10127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10127:
URL: https://github.com/apache/dolphinscheduler/pull/10127#issuecomment-1131423306
@huangchenguang123 Hi, it is related to #9426 and we have to keep it in the old way now, othewise our document in website can not display img in the right way, I will change them and make it work on both the source markdown file and website
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10127:
URL: https://github.com/apache/dolphinscheduler/pull/10127#issuecomment-1131424808
If you have time and interesting in issue #9426, and feel free to take it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10127:
URL: https://github.com/apache/dolphinscheduler/pull/10127#issuecomment-1132429048
> > @huangchenguang123 Hi, it is related to #9426 and we have to keep it in the old way now, othewise our document in website can not display img in the right way, I will change them and make it work on both the source markdown file and website
>
> Think.You mean I have to modify the script on the website to be compatible with the display of the pictures on dolphinscheduler.apache.org?
yeah, we have some example in apache/seatunnel, it will convert img path and make them work bot github markdown and website. https://github.com/apache/incubator-seatunnel-website/blob/main/tools/build-docs.sh#L121-L137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 commented on pull request #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on PR #10127:
URL: https://github.com/apache/dolphinscheduler/pull/10127#issuecomment-1131595101
> @huangchenguang123 Hi, it is related to #9426 and we have to keep it in the old way now, othewise our document in website can not display img in the right way, I will change them and make it work on both the source markdown file and website
Think.You mean I have to modify the script on the website to be compatible with the display of the pictures on dolphinscheduler.apache.org?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 commented on pull request #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on PR #10127:
URL: https://github.com/apache/dolphinscheduler/pull/10127#issuecomment-1146806330
close by batch fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10127: [fix][doc]: fix conditions.md cannot be previewed by markdown
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10127:
URL: https://github.com/apache/dolphinscheduler/pull/10127#issuecomment-1146943586
> close by batch fix
@huangchenguang123 Thanks for your contribution to `prepare_docs.sh` in repo apache/dolphinscheduler-website ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org