You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org> on 2008/04/05 12:32:58 UTC
[jira] Created: (MDOCCK-10) Use proper file encoding when checking
site descriptor
Use proper file encoding when checking site descriptor
------------------------------------------------------
Key: MDOCCK-10
URL: http://jira.codehaus.org/browse/MDOCCK-10
Project: Maven 2.x DOCCK Plugin
Issue Type: Bug
Affects Versions: 1.0-beta-2
Reporter: Benjamin Bentmann
This is not working reliably:
{code:java}
String siteHtml = FileUtils.fileRead( siteXml.getAbsolutePath() );
{code}
See also [Common Bugs|http://www.nabble.com/Common-Bugs-to14783703s177.html#a15919795].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDOCCK-10) Use proper file encoding when
checking site descriptor
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDOCCK-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=135300#action_135300 ]
Benjamin Bentmann commented on MDOCCK-10:
-----------------------------------------
Yepp, that should be fine. You could however consider to close the reader afterwards.
> Use proper file encoding when checking site descriptor
> ------------------------------------------------------
>
> Key: MDOCCK-10
> URL: http://jira.codehaus.org/browse/MDOCCK-10
> Project: Maven 2.x Documentation Checker Plugin
> Issue Type: Bug
> Affects Versions: 1.0-beta-2
> Reporter: Benjamin Bentmann
>
> This is not working reliably:
> {code:java}
> String siteHtml = FileUtils.fileRead( siteXml.getAbsolutePath() );
> {code}
> See also [Common Bugs|http://www.nabble.com/Common-Bugs-to14783703s177.html#a15919795].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MDOCCK-10) Use proper file encoding when
checking site descriptor
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDOCCK-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=135298#action_135298 ]
Dennis Lundberg commented on MDOCCK-10:
---------------------------------------
I've implemented a fix for this by replacing the above code with the following:
{code:java}
String siteHtml = IOUtil.toString( ReaderFactory.newXmlReader( siteXml ) );
{code}
and added a dependency on plexus-utils-1.4.5 and bumped the Maven prerequisite to 2.0.6.
Is that enough to fix this issue?
> Use proper file encoding when checking site descriptor
> ------------------------------------------------------
>
> Key: MDOCCK-10
> URL: http://jira.codehaus.org/browse/MDOCCK-10
> Project: Maven 2.x Documentation Checker Plugin
> Issue Type: Bug
> Affects Versions: 1.0-beta-2
> Reporter: Benjamin Bentmann
>
> This is not working reliably:
> {code:java}
> String siteHtml = FileUtils.fileRead( siteXml.getAbsolutePath() );
> {code}
> See also [Common Bugs|http://www.nabble.com/Common-Bugs-to14783703s177.html#a15919795].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MDOCCK-10) Use proper file encoding when checking
site descriptor
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MDOCCK-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dennis Lundberg closed MDOCCK-10.
---------------------------------
Assignee: Dennis Lundberg
Resolution: Fixed
Fix Version/s: 1.0-beta-3
Fixed in r657785.
> Use proper file encoding when checking site descriptor
> ------------------------------------------------------
>
> Key: MDOCCK-10
> URL: http://jira.codehaus.org/browse/MDOCCK-10
> Project: Maven 2.x Documentation Checker Plugin
> Issue Type: Bug
> Affects Versions: 1.0-beta-2
> Reporter: Benjamin Bentmann
> Assignee: Dennis Lundberg
> Fix For: 1.0-beta-3
>
>
> This is not working reliably:
> {code:java}
> String siteHtml = FileUtils.fileRead( siteXml.getAbsolutePath() );
> {code}
> See also [Common Bugs|http://www.nabble.com/Common-Bugs-to14783703s177.html#a15919795].
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira