You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/19 02:35:26 UTC
[GitHub] [skywalking-rocketbot-ui] heihaozi opened a new pull request #530: Support clicking the service name in the chart to link to the tracking page.
heihaozi opened a new pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530
Fix #529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906013504
The align of words seem strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906119982
Those errors can still be reproduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r695485138
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -156,12 +169,12 @@ limitations under the License. -->
};
}
private chooseService(i: Option) {
- if (this.service.key === i.key) {
+ if (this.rocketTrace.currentService.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
this.endpoint = { label: 'All', key: '' };
- this.service = i;
+ this.rocketTrace.currentService = i;
Review comment:
The same as above
##########
File path: src/utils/queryParameter.ts
##########
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export const getQueryParameter = (name: string) => {
+ const reg = new RegExp('(^|&)' + name + '=([^&]*)(&|$)');
+ const r = window.location.search.substr(1).match(reg);
+ if (r != null) {
+ return decodeURIComponent(r[2]);
+ } else {
+ return '';
+ }
+};
+
+export const getServiceName = () => {
Review comment:
The function is not used, please delete it.
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -54,10 +79,34 @@ limitations under the License. -->
private handleClick(i: any) {
copy(i);
}
+ private handleLink(i: any) {
+ if (this.isServiceChart) {
+ this.redirectData.log = {
+ path: 'log',
+ query: {
+ service: encodeURIComponent(i.name),
+ },
+ };
+ this.redirectData.trace = {
+ path: 'trace',
+ query: {
+ service: encodeURIComponent(i.name),
+ },
+ };
+ this.showModal = true;
+ }
+ }
get datas() {
if (!this.data.length) {
return [];
}
+ for (const i of this.data) {
+ if (this.isServiceChart) {
+ i.url = '/trace?service=' + encodeURIComponent(i.name);
+ } else {
+ i.url = undefined;
Review comment:
Where is the filed of `url` used? It seems to be needed.
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -132,19 +131,33 @@ limitations under the License. -->
private tagsMap: Array<{ key: string; value: string }> = [];
private tagsList: string[] = [];
private clearTags: boolean = false;
+ private serviceName: string = '';
private created() {
this.traceId = this.$route.query.traceid ? this.$route.query.traceid.toString() : this.traceId;
+ this.serviceName = this.$route.query.service ? this.$route.query.service.toString() : this.serviceName;
this.time = [this.rocketbotGlobal.durationRow.start, this.rocketbotGlobal.durationRow.end];
}
private mounted() {
- this.getTraceList();
- if (this.service && this.service.key) {
- this.GET_INSTANCES({
- duration: this.durationTime,
- serviceId: this.service.key,
+ this.GET_SERVICES({ duration: this.durationTime })
+ .then(() => {
+ if (this.serviceName) {
+ for (const s of this.rocketTrace.services) {
+ if (s.label === this.serviceName) {
+ this.rocketTrace.currentService.key = s.key;
+ this.rocketTrace.currentService.label = s.label;
Review comment:
You should set the `rocketTrace.currentService` value in [Trace Mutations](https://github.com/apache/skywalking-rocketbot-ui/blob/master/src/store/modules/trace/index.ts#L62)
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -248,7 +260,7 @@ limitations under the License. -->
localStorage.removeItem('maxTraceDuration');
this.minTraceDuration = '';
localStorage.removeItem('minTraceDuration');
- this.service = { label: 'All', key: '' };
+ this.rocketTrace.currentService = { label: 'All', key: '' };
Review comment:
The same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r695445308
##########
File path: src/utils/queryParameter.ts
##########
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export const getQueryParameter = (name: string) => {
Review comment:
I fixed it.
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,7 +22,12 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover">
+ <a v-if="i.url" :href="i.url" target="_blank">
Review comment:
I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905434237
>
>
> Could you have a whole page screenshot? And what English version says?
whole page screenshot:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905430847
Could you have a whole page screenshot? And what English version says?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905231288
I can see the box, but it seems using different styles with the existing pages
@Fine0830 Could you check and provide some suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r691991324
##########
File path: src/utils/queryParameter.ts
##########
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export const getQueryParameter = (name: string) => {
Review comment:
Please use passing Props to Route Components rather than this
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,7 +22,12 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover">
+ <a v-if="i.url" :href="i.url" target="_blank">
Review comment:
You should use `router-link`.
```suggestion
<router-link :to="{ name: 'trace', query: {... } }">...</router-link>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905552659
`Do you want to inspect Traces or Logs of xxx service?` Could you rewrite like this? `xxx` should be the clicked service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906180172
>
>
> Those errors can still be reproduced.
I tested it again. Very strange, I did not report an error here.
Do you have more detailed error information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r696253359
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,25 +22,50 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover" @click="handleLink(i)">{{ i.name + getTraceId(i) }}</span>
</div>
<RkProgress :precent="(i.value / maxValue) * 100" color="#bf99f8" />
</div>
</div>
+ <rk-modal :show.sync="showModal" :title="$t('modalTitle')">
+ <div>
+ {{ $t('selectRedirectPage').replace('%s', redirectData.name) }}
+ </div>
+ <div class="mt-15">
+ <router-link :to="redirectData.log" class="rk-chart-slow-link mr-20">{{ $t('log') }}</router-link>
+ <router-link :to="redirectData.trace" class="rk-chart-slow-link mr-20">{{ $t('trace') }}</router-link>
+ </div>
+ </rk-modal>
</div>
</template>
<script lang="ts">
import Vue from 'vue';
import { Component, Prop } from 'vue-property-decorator';
import copy from '@/utils/copy';
+ import {MetricsName} from "@/views/components/dashboard/charts/constant";
Review comment:
""should be ''
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901759645
OK. Do we need a pop-up box to choose whether to jump to `log` or `trace`? Or jump directly to the `trace` as it is currently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906402670
Please sync the main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905530728
> > Could you have a whole page screenshot? And what English version says?
>
> whole page screenshot:
>
> 
Please add Cancel and OK buttons in the modal, and words need vertical center in the button. I think it's better that you set the areas more long for `Trace` and `Log`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r696261700
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,25 +22,50 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover" @click="handleLink(i)">{{ i.name + getTraceId(i) }}</span>
</div>
<RkProgress :precent="(i.value / maxValue) * 100" color="#bf99f8" />
</div>
</div>
+ <rk-modal :show.sync="showModal" :title="$t('modalTitle')">
+ <div>
+ {{ $t('selectRedirectPage').replace('%s', redirectData.name) }}
+ </div>
+ <div class="mt-15">
+ <router-link :to="redirectData.log" class="rk-chart-slow-link mr-20">{{ $t('log') }}</router-link>
+ <router-link :to="redirectData.trace" class="rk-chart-slow-link mr-20">{{ $t('trace') }}</router-link>
+ </div>
+ </rk-modal>
</div>
</template>
<script lang="ts">
import Vue from 'vue';
import { Component, Prop } from 'vue-property-decorator';
import copy from '@/utils/copy';
+ import {MetricsName} from "@/views/components/dashboard/charts/constant";
@Component({})
export default class ChartSlow extends Vue {
@Prop() private data!: any;
@Prop() private item!: any;
@Prop() private type!: any;
@Prop() private intervalTime!: any;
+ private showModal: boolean = false;
+ private redirectData: any = {};
+ private isServiceChart: boolean = false;
+
+ private created() {
+ const serviceMetricNames = [
+ MetricsName.SERVICE_RESP_TIME,
+ MetricsName.SERVICE_SLA,
+ MetricsName.SERVICE_CPM,
+ MetricsName.SERVICE_PERCENTILE,
+ MetricsName.SERVICE_APDEX,
+ ];
+ this.isServiceChart = 'Service' === this.item.entityType && serviceMetricNames.includes(this.item.metricName);
Review comment:
I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906023465
@Fine0830 Please recheck the codes and style, whether matches the project requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r691825797
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -41,6 +46,13 @@ limitations under the License. -->
@Prop() private item!: any;
@Prop() private type!: any;
@Prop() private intervalTime!: any;
+ private isServiceChart: boolean = false;
+
+ private created() {
+ const serviceMetricNames = ['service_cpm', 'service_resp_time', 'service_apdex', 'service_sla'];
Review comment:
I will make changes as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905360577
@Fine0830 how about this modal style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906022218
English:
Chinese:
How about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901747512
If the community agrees with this feature, I will submit a new PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906212276
> > Those errors can still be reproduced.
>
> I tested it again. Very strange, I did not report an error here.
> Do you have more detailed error information?
Since the data(`redirectData`) you define is `{}` and it has no `log` and `trace` fields, this the reason of errors happened. https://github.com/apache/skywalking-rocketbot-ui/pull/530/files#diff-51fefcb84310d16f837fcdbc90449d0a3a349ecba6ac025bec6b1d8bc4030cc0R55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-903040806
OK, I will try it as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r691746965
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -41,6 +46,13 @@ limitations under the License. -->
@Prop() private item!: any;
@Prop() private type!: any;
@Prop() private intervalTime!: any;
+ private isServiceChart: boolean = false;
+
+ private created() {
+ const serviceMetricNames = ['service_cpm', 'service_resp_time', 'service_apdex', 'service_sla'];
Review comment:
You are hard coded these, which is not allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901692723
@heihaozi It is better to provide a pop up box to choose, whether jump to `trace` or `log` page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 edited a comment on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905378977
> @Fine0830 how about this modal style?
>
> 
It's fine. Could you please add a cancel button at the bottom right of modal with grey border? Like this,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r696262308
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,25 +22,50 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover" @click="handleLink(i)">{{ i.name + getTraceId(i) }}</span>
Review comment:
Click on the service name to easily trigger it. You can think of it as a link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905427848
> @Fine0830 How about this modal style?
> 
That's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r696244169
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,25 +22,50 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover" @click="handleLink(i)">{{ i.name + getTraceId(i) }}</span>
</div>
<RkProgress :precent="(i.value / maxValue) * 100" color="#bf99f8" />
</div>
</div>
+ <rk-modal :show.sync="showModal" :title="$t('modalTitle')">
+ <div>
+ {{ $t('selectRedirectPage').replace('%s', redirectData.name) }}
+ </div>
+ <div class="mt-15">
+ <router-link :to="redirectData.log" class="rk-chart-slow-link mr-20">{{ $t('log') }}</router-link>
+ <router-link :to="redirectData.trace" class="rk-chart-slow-link mr-20">{{ $t('trace') }}</router-link>
+ </div>
+ </rk-modal>
</div>
</template>
<script lang="ts">
import Vue from 'vue';
import { Component, Prop } from 'vue-property-decorator';
import copy from '@/utils/copy';
+ import {MetricsName} from "@/views/components/dashboard/charts/constant";
@Component({})
export default class ChartSlow extends Vue {
@Prop() private data!: any;
@Prop() private item!: any;
@Prop() private type!: any;
@Prop() private intervalTime!: any;
+ private showModal: boolean = false;
+ private redirectData: any = {};
+ private isServiceChart: boolean = false;
+
+ private created() {
+ const serviceMetricNames = [
+ MetricsName.SERVICE_RESP_TIME,
+ MetricsName.SERVICE_SLA,
+ MetricsName.SERVICE_CPM,
+ MetricsName.SERVICE_PERCENTILE,
+ MetricsName.SERVICE_APDEX,
+ ];
+ this.isServiceChart = 'Service' === this.item.entityType && serviceMetricNames.includes(this.item.metricName);
Review comment:
I think we should use metric types to set the value for `isServiceChart`.
```suggestion
this.isServiceChart = 'Service' === this.item.entityType && this.item.queryMetricType === 'sortMetrics';
```
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,25 +22,50 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover" @click="handleLink(i)">{{ i.name + getTraceId(i) }}</span>
Review comment:
Could you please add an icon to bind a event(click) to open the `modalTitle`, like the `Copy` event? Now this way is not easy to trigger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901714248
>
>
> @heihaozi It is better to provide a pop up box to choose, whether jump to `trace` or `log` page.
>
>
> Got it, could you consider to add a pop up? Because user could intent to get logs instead of traces.
I think `trace` is the core function of skywalking, so jump directly to `trace`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901693017
Otherwise, accidentally clicking could be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901714952
I am afraid it isn't. SkyWalking could work without any trace agent in service mesh env. We have users out there focusing on this only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901709807
> @heihaozi Could you provide a recorded video/gif to show?
I made a gif as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r696261631
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,25 +22,50 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover" @click="handleLink(i)">{{ i.name + getTraceId(i) }}</span>
</div>
<RkProgress :precent="(i.value / maxValue) * 100" color="#bf99f8" />
</div>
</div>
+ <rk-modal :show.sync="showModal" :title="$t('modalTitle')">
+ <div>
+ {{ $t('selectRedirectPage').replace('%s', redirectData.name) }}
+ </div>
+ <div class="mt-15">
+ <router-link :to="redirectData.log" class="rk-chart-slow-link mr-20">{{ $t('log') }}</router-link>
+ <router-link :to="redirectData.trace" class="rk-chart-slow-link mr-20">{{ $t('trace') }}</router-link>
+ </div>
+ </rk-modal>
</div>
</template>
<script lang="ts">
import Vue from 'vue';
import { Component, Prop } from 'vue-property-decorator';
import copy from '@/utils/copy';
+ import {MetricsName} from "@/views/components/dashboard/charts/constant";
Review comment:
I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r696253359
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -22,25 +22,50 @@ limitations under the License. -->
</svg>
<div class="mb-5 ell" v-tooltip:top.ellipsis="i.name || ''">
<span class="calls sm mr-10">{{ i.value }}</span>
- <span class="cp link-hover">{{ i.name + getTraceId(i) }}</span>
+ <span class="cp link-hover" @click="handleLink(i)">{{ i.name + getTraceId(i) }}</span>
</div>
<RkProgress :precent="(i.value / maxValue) * 100" color="#bf99f8" />
</div>
</div>
+ <rk-modal :show.sync="showModal" :title="$t('modalTitle')">
+ <div>
+ {{ $t('selectRedirectPage').replace('%s', redirectData.name) }}
+ </div>
+ <div class="mt-15">
+ <router-link :to="redirectData.log" class="rk-chart-slow-link mr-20">{{ $t('log') }}</router-link>
+ <router-link :to="redirectData.trace" class="rk-chart-slow-link mr-20">{{ $t('trace') }}</router-link>
+ </div>
+ </rk-modal>
</div>
</template>
<script lang="ts">
import Vue from 'vue';
import { Component, Prop } from 'vue-property-decorator';
import copy from '@/utils/copy';
+ import {MetricsName} from "@/views/components/dashboard/charts/constant";
Review comment:
"" should be ''
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901885326
> > > > OK. Do we need a pop-up box to choose whether to jump to `log` or `trace`? Or jump directly to the `trace` as it is currently?
> > >
> > >
> > > We need a pop up box. @Fine0830 What kind of confirm box do we support for now?
> >
> >
> > There is no a confirm box to support this in the `rocketbot-ui` now. Need to Develop a new component to support this.
>
> Can we use [layer](https://github.com/sentsin/layer)? Or do you have any recommended components?
>
> I don't know much about the front end.
We can't accept a pure Chinese project in the tech stack, it would be a block to other developers. And also, from the principle of RocketBot UI, it keeps the components as less as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on a change in pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on a change in pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#discussion_r695677830
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -132,19 +131,33 @@ limitations under the License. -->
private tagsMap: Array<{ key: string; value: string }> = [];
private tagsList: string[] = [];
private clearTags: boolean = false;
+ private serviceName: string = '';
private created() {
this.traceId = this.$route.query.traceid ? this.$route.query.traceid.toString() : this.traceId;
+ this.serviceName = this.$route.query.service ? this.$route.query.service.toString() : this.serviceName;
this.time = [this.rocketbotGlobal.durationRow.start, this.rocketbotGlobal.durationRow.end];
}
private mounted() {
- this.getTraceList();
- if (this.service && this.service.key) {
- this.GET_INSTANCES({
- duration: this.durationTime,
- serviceId: this.service.key,
+ this.GET_SERVICES({ duration: this.durationTime })
+ .then(() => {
+ if (this.serviceName) {
+ for (const s of this.rocketTrace.services) {
+ if (s.label === this.serviceName) {
+ this.rocketTrace.currentService.key = s.key;
+ this.rocketTrace.currentService.label = s.label;
Review comment:
I fixed it.
##########
File path: src/views/components/dashboard/charts/chart-slow.vue
##########
@@ -54,10 +79,34 @@ limitations under the License. -->
private handleClick(i: any) {
copy(i);
}
+ private handleLink(i: any) {
+ if (this.isServiceChart) {
+ this.redirectData.log = {
+ path: 'log',
+ query: {
+ service: encodeURIComponent(i.name),
+ },
+ };
+ this.redirectData.trace = {
+ path: 'trace',
+ query: {
+ service: encodeURIComponent(i.name),
+ },
+ };
+ this.showModal = true;
+ }
+ }
get datas() {
if (!this.data.length) {
return [];
}
+ for (const i of this.data) {
+ if (this.isServiceChart) {
+ i.url = '/trace?service=' + encodeURIComponent(i.name);
+ } else {
+ i.url = undefined;
Review comment:
I fixed it.
##########
File path: src/utils/queryParameter.ts
##########
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export const getQueryParameter = (name: string) => {
+ const reg = new RegExp('(^|&)' + name + '=([^&]*)(&|$)');
+ const r = window.location.search.substr(1).match(reg);
+ if (r != null) {
+ return decodeURIComponent(r[2]);
+ } else {
+ return '';
+ }
+};
+
+export const getServiceName = () => {
Review comment:
I fixed it.
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -156,12 +169,12 @@ limitations under the License. -->
};
}
private chooseService(i: Option) {
- if (this.service.key === i.key) {
+ if (this.rocketTrace.currentService.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
this.endpoint = { label: 'All', key: '' };
- this.service = i;
+ this.rocketTrace.currentService = i;
Review comment:
I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901731507
> In our project, there is another feature:
> According to the service parameter in the url, the data of the corresponding service is directly displayed.
>
> I also made a gif as follows:
>
> 
>
> After entering the trace page, click `log` in the navigation bar to enter the log page.
> Can this feature cover your needs? I planned to contribute this feature next time.
This works, but you need another PR and main repo document update for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901878363
> > > > OK. Do we need a pop-up box to choose whether to jump to `log` or `trace`? Or jump directly to the `trace` as it is currently?
> > >
> > >
> > > We need a pop up box. @Fine0830 What kind of confirm box do we support for now?
> >
> >
> > There is no a confirm box to support this in the `rocketbot-ui` now. Need to Develop a new component to support this.
>
> Can we use [layer](https://github.com/sentsin/layer)? Or do you have any recommended components?
>
> I don't know much about the front end.
It's better to develop a component by yourself. It's not very difficult. Probably you also can use `rk-sidebox`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901793141
> > OK. Do we need a pop-up box to choose whether to jump to `log` or `trace`? Or jump directly to the `trace` as it is currently?
>
> We need a pop up box. @Fine0830 What kind of confirm box do we support for now?
There is no a confirm box to support this in the `rocketbot-ui` now. Need to Develop a new component to support this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905532928
This sentence seems a little strange to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905378977
> @Fine0830 how about this modal style?
>
> 
It's fine. Could you please add a cancel button at the bottom right of modal with grey border?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906007945
>
>
> `Do you want to inspect Traces or Logs of xxx service?` Could you rewrite like this? `xxx` should be the clicked service.
English:
Chinese:
How about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901762252
> OK. Do we need a pop-up box to choose whether to jump to `log` or `trace`? Or jump directly to the `trace` as it is currently?
We need a pop up box. @Fine0830 What kind of confirm box do we support for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905230068
I added a pop-up window component. We can choose to link to log or trace. The effect is as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905437754
>
>
> The worda and buttons seem not in the center of lines.
The log and trace buttons are left aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905426879
@Fine0830 How about this modal style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901692172
@Fine0830 Could you check the logic? The key is, if this is a service level logic, it could provide jump to trace query page directly.
@heihaozi Could you provide a recorded video/gif to show?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901851774
>
>
> > > OK. Do we need a pop-up box to choose whether to jump to `log` or `trace`? Or jump directly to the `trace` as it is currently?
> >
> >
> > We need a pop up box. @Fine0830 What kind of confirm box do we support for now?
>
> There is no a confirm box to support this in the `rocketbot-ui` now. Need to Develop a new component to support this.
Can we use [layer](https://github.com/sentsin/layer)? Or do you have any recommended components?
I don't know much about the front end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901748373
> If the community agrees with this feature, I will submit a new PR as soon as possible.
Let's do step by step. We need some polish about this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906014605
The title should be `Inspection`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901729848
In our project, there is another feature:
According to the service parameter in the url, the data of the corresponding service is directly displayed.
I also made a gif as follows:
After entering the trace page, click `log` in the navigation bar to enter the log page.
Can this feature cover your needs? I planned to contribute this feature next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-905431701
The worda and buttons seem not in the center of lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901656193
The hard code has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] heihaozi commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
heihaozi commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-906246634
>
>
> > > Those errors can still be reproduced.
> >
> >
> > I tested it again. Very strange, I did not report an error here.
> > Do you have more detailed error information?
>
> Since the data(`redirectData`) you define is `{}` and it has no `log` and `trace` fields, this the reason of errors happened. https://github.com/apache/skywalking-rocketbot-ui/pull/530/files#diff-51fefcb84310d16f837fcdbc90449d0a3a349ecba6ac025bec6b1d8bc4030cc0R55
Thank you very much for your help. I will fix it immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #530: Support clicking the service name in the chart to link to the tracking page.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #530:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/530#issuecomment-901712370
Got it, could you consider to add a pop up? Because user could intent to get logs instead of traces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org