[GitHub] [spark] HyukjinKwon commented on a change in pull request #30008: [SPARK-21708][BUILD][FOLLOWUP] Rename hdpVersion to hadoopVersionValue

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #30008:
URL: https://github.com/apache/spark/pull/30008#discussion_r503017956



##########
File path: project/SparkBuild.scala
##########
@@ -756,12 +756,12 @@ object Assembly {
         .getOrElse(SbtPomKeys.effectivePom.value.getProperties.get("hadoop.version").asInstanceOf[String])
     },
     assemblyJarName in assembly := {
-      lazy val hdpVersion = hadoopVersion.value
+      lazy val versionValue = hadoopVersion.value
       if (moduleName.value.contains("streaming-kafka-0-10-assembly")
         || moduleName.value.contains("streaming-kinesis-asl-assembly")) {
         s"${moduleName.value}-${version.value}.jar"
       } else {
-        s"${moduleName.value}-${version.value}-hadoop${hdpVersion}.jar"
+        s"${moduleName.value}-${version.value}-hadoop${versionValue}.jar"

Review comment:
       ```suggestion
           s"${moduleName.value}-${version.value}-hadoop${hadoopVersionValue}.jar"
   ```

##########
File path: project/SparkBuild.scala
##########
@@ -756,12 +756,12 @@ object Assembly {
         .getOrElse(SbtPomKeys.effectivePom.value.getProperties.get("hadoop.version").asInstanceOf[String])
     },
     assemblyJarName in assembly := {
-      lazy val hdpVersion = hadoopVersion.value
+      lazy val versionValue = hadoopVersion.value

Review comment:
       ```suggestion
         lazy val hadoopVersionValue = hadoopVersion.value
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org