You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/24 22:30:01 UTC
[GitHub] [thrift] dcelasun commented on a change in pull request #2121: THRIFT-5185: Add support for using WebSockets as a server transport.
dcelasun commented on a change in pull request #2121:
URL: https://github.com/apache/thrift/pull/2121#discussion_r414897662
##########
File path: lib/cpp/Makefile.am
##########
@@ -87,6 +87,7 @@ libthrift_la_SOURCES = src/thrift/TApplicationException.cpp \
src/thrift/transport/TNonblockingSSLServerSocket.cpp \
src/thrift/transport/TTransportUtils.cpp \
src/thrift/transport/TBufferTransports.cpp \
+ src/thrift/transport/TWebSocketServer.cpp \
Review comment:
nit: Fix alignment
##########
File path: lib/cpp/src/thrift/endian.h
##########
@@ -0,0 +1,124 @@
+//
Review comment:
This header is likely not acceptable for ASF. If you have no objections, please use the standard license header.
##########
File path: lib/cpp/Makefile.am
##########
@@ -198,7 +200,8 @@ include_transport_HEADERS = \
src/thrift/transport/TTransportUtils.h \
src/thrift/transport/TBufferTransports.h \
src/thrift/transport/TShortReadTransport.h \
- src/thrift/transport/TZlibTransport.h
+ src/thrift/transport/TZlibTransport.h \
+ src/thrift/transport/TWebSocketServer.h
Review comment:
nit: Fix alignment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org