You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/04/27 20:05:00 UTC
[jira] [Comment Edited] (CASSANDRA-16613) ProtocolVersion.V4 is
still used in places in the code
[ https://issues.apache.org/jira/browse/CASSANDRA-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333521#comment-17333521 ]
Ekaterina Dimitrova edited comment on CASSANDRA-16613 at 4/27/21, 8:04 PM:
---------------------------------------------------------------------------
Work in progress [here|https://github.com/apache/cassandra/commit/d99f056cb8189c157dd76110542817e0981397dd]
Seems to me only the tests need update.
I am wondering about a few things though:
* DriverBurnTest contains perf tests for V4 and V5 (it was actually testing current beta which is already V6) so I changed the tests to test V4, V5, V6 but then I observed that the perf method calls BurnTestUtil#generateQueryMessage for [version 4|https://github.com/apache/cassandra/commit/d99f056cb8189c157dd76110542817e0981397dd#diff-df33e55e1def1329f9f1c37173fd1af732a6fb636545097f65ce0344079a05f7L81]... So I am wondering which versions we want to leave and I guess I have to update also BurnTestUtil#generateQueryMessage.
* I added additional test for version 5 in PagingStateTest, not sure whether mixed versions serialize/deserialize should be added too.
* ClientWarningsTest - I decided to leave it to test latest current version instead of 4
[~samt], do you mind to take a look, please, when you have a bit of time? Thanks in advance!
was (Author: e.dimitrova):
Work in progress [here|https://github.com/apache/cassandra/commit/d99f056cb8189c157dd76110542817e0981397dd]
Seems to me only the tests need update.
I am wondering about a few things though:
* DriverBurnTest contains perf tests for V4 and V5 (it was actually testing current beta which is already V6) so I changed the tests to test V4, V5, V6 but then I observed that the perf method is called BurnTestUtil#generateQueryMessage for [version 4|https://github.com/apache/cassandra/commit/d99f056cb8189c157dd76110542817e0981397dd#diff-df33e55e1def1329f9f1c37173fd1af732a6fb636545097f65ce0344079a05f7L81]... So I am wondering which versions we want to leave and I guess I have to update also BurnTestUtil#generateQueryMessage.
* I added additional test for version 5 in PagingStateTest, not sure whether mixed versions serialize/deserialize should be added too.
* ClientWarningsTest - I decided to leave it to test latest current version instead of 4
[~samt], do you mind to take a look, please, when you have a bit of time? Thanks in advance!
> ProtocolVersion.V4 is still used in places in the code
> ------------------------------------------------------
>
> Key: CASSANDRA-16613
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16613
> Project: Cassandra
> Issue Type: Bug
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0-rc
>
>
> While working on CASSANDRA-16567, [~adelapena] observed that _ProtocolVersion.V4_ is used in _ViewTest_.
> I decided to do a quick grep and observed a list of places where we still refer to V4 and it seems at least in many of the tests that was left not intentionally.
> This ticket is to verify the usage of _ProtocolVersion.V4_ in the codebase and bump it to V5 or default version, similar to what was done in CASSANDRA-16567, wherever there is a need.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org