You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Bhargavkonidena (via GitHub)" <gi...@apache.org> on 2025/05/23 08:39:27 UTC
[PR] Fix for issue 34772 to include user provided providers [beam]
Bhargavkonidena opened a new pull request, #35033:
URL: https://github.com/apache/beam/pull/35033
Addresses #34772 by adding code changes to consider user provided providers if they are provided via command-line arguments.
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2907696896
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2924300051
remind me after tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2903865887
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2924302524
Ok - I'll remind @shunping after tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2923132270
> @shunping Can you please review this PR.
Yes. It looks good overall, but to make things consistent, please correct the flag name. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2907697442
Reviewers are already assigned to this PR: @shunping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2906346660
Assigning reviewers:
R: @shunping for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping merged PR #35033:
URL: https://github.com/apache/beam/pull/35033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #35033:
URL: https://github.com/apache/beam/pull/35033#discussion_r2116387662
##########
sdks/python/apache_beam/yaml/generate_yaml_docs.py:
##########
@@ -557,6 +563,11 @@ def main():
parser.add_argument('--schema_file')
parser.add_argument('--include', default='.*')
parser.add_argument('--exclude', default='')
+ parser.add_argument(
+ "--provider-source-file",
Review Comment:
Can we change hypens to underscores in the flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2922856486
@shunping Can you please review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2928471367
@shunping can you please check now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix for issue 34772 to include user provided providers [beam]
Posted by "Bhargavkonidena (via GitHub)" <gi...@apache.org>.
Bhargavkonidena commented on PR #35033:
URL: https://github.com/apache/beam/pull/35033#issuecomment-2906346062
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org