You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/13 10:52:12 UTC
[GitHub] [commons-graph] ameyjadiye opened a new pull request #3: Test fix
ameyjadiye opened a new pull request #3:
URL: https://github.com/apache/commons-graph/pull/3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] kinow commented on pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
kinow commented on pull request #3:
URL: https://github.com/apache/commons-graph/pull/3#issuecomment-663737122
Change log entry added, and PR merged. Thanks @ameyjadiye !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] ameyjadiye commented on a change in pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
ameyjadiye commented on a change in pull request #3:
URL: https://github.com/apache/commons-graph/pull/3#discussion_r456911858
##########
File path: src/test/java/org/apache/commons/graph/spanning/KruskalTestCase.java
##########
@@ -231,6 +232,7 @@ public void verifyNotConnectedMinimumSpanningTree()
* and unit weights.
*/
@Test
+ @Ignore //TODO - for time being ignoring it.
Review comment:
Yes, of course. I have marked it TODO to take followup later. I doubt this was a success when written.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] kinow commented on a change in pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #3:
URL: https://github.com/apache/commons-graph/pull/3#discussion_r460291481
##########
File path: pom.xml
##########
@@ -162,7 +162,7 @@
</dependencies>
<build>
- <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check spotbugs:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check clirr:check</defaultGoal>
Review comment:
Thanks @ameyjadiye ! Just wanted to confirm it wouldn't cause any any issues merging this one. Done! :tada:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] kinow merged pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
kinow merged pull request #3:
URL: https://github.com/apache/commons-graph/pull/3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] ameyjadiye commented on a change in pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
ameyjadiye commented on a change in pull request #3:
URL: https://github.com/apache/commons-graph/pull/3#discussion_r456912157
##########
File path: pom.xml
##########
@@ -162,7 +162,7 @@
</dependencies>
<build>
- <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check spotbugs:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check clirr:check</defaultGoal>
Review comment:
@kinow, I am creating another PR actually which has a maven modular design. just to minimize clutter I removed these things. apologies for being late though, bit busy on the personal front from the last few weeks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] ameyjadiye commented on a change in pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
ameyjadiye commented on a change in pull request #3:
URL: https://github.com/apache/commons-graph/pull/3#discussion_r460069453
##########
File path: pom.xml
##########
@@ -162,7 +162,7 @@
</dependencies>
<build>
- <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check spotbugs:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check clirr:check</defaultGoal>
Review comment:
@kinow Yes, it is ok to merge this PR, basically this PR was to just stabilize existing code. My other branch already having this code and is much stable and modular. it won't be issue to merge in future, if it comes, I'll take care of that :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] kinow closed pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
kinow closed pull request #3:
URL: https://github.com/apache/commons-graph/pull/3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] kinow commented on a change in pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #3:
URL: https://github.com/apache/commons-graph/pull/3#discussion_r456853262
##########
File path: pom.xml
##########
@@ -162,7 +162,7 @@
</dependencies>
<build>
- <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check spotbugs:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check clirr:check</defaultGoal>
Review comment:
Was it because we had too many checkstyle, spotbugs, and javadoc errors, that it was not worth fixing everything in this PR?
##########
File path: src/test/java/org/apache/commons/graph/spanning/KruskalTestCase.java
##########
@@ -231,6 +232,7 @@ public void verifyNotConnectedMinimumSpanningTree()
* and unit weights.
*/
@Test
+ @Ignore //TODO - for time being ignoring it.
Review comment:
:+1: we just need to review these TODO markers before the first alpha/RC/or final release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-graph] kinow commented on a change in pull request #3: [SANDBOX-510] Test fix
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #3:
URL: https://github.com/apache/commons-graph/pull/3#discussion_r456953807
##########
File path: pom.xml
##########
@@ -162,7 +162,7 @@
</dependencies>
<build>
- <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check spotbugs:check javadoc:javadoc</defaultGoal>
+ <defaultGoal>clean verify apache-rat:check clirr:check</defaultGoal>
Review comment:
Not a problem. @ameyjadiye is it alright if we merge this one then? Or does your other branch includes the work of this branch too, and merging/rebasing will be complicated later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org