You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2018/07/30 14:32:30 UTC

[GitHub] carbondata pull request #2585: [CARBONDATA-2805]fix the ordering mismatch of...

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/2585

    [CARBONDATA-2805]fix the ordering mismatch of segment numbers during cutom compaction

    ### Problem:
    when we have segments from 0 to 6 and i give 1, 2, 3 for custom compaction, then it should create 1.1 as compacted segment, but sometimes it will create 3.1 as compacted segment which is wrong. This is beacuse custom Segment IDs were passing in hashset and finally inserted in hashmap, while identifying segments to be merged. hashmap and hashset does not guarantee the insertion order which may lead to missmatch of segment numbers.
    
    ### Solution:
    Use LinkedHashSet and LinkedHashMap which always sure about the insertion order.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [x] Any interfaces changed?
     NA
     - [x] Any backward compatibility impacted?
     NA
     - [x] Document update required?
    NA
     - [x] Testing done
    Testing is done executing the custom compaction queries repeatedly and verified
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata custom_compaction

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2585
    
----
commit f98279b85ffead594d33d35d241ea497b9e17834
Author: akashrn5 <ak...@...>
Date:   2018-07-30T13:52:29Z

    fix the mis ordering or segment numbers during cutom compaction

----


---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6389/



---

[GitHub] carbondata pull request #2585: [CARBONDATA-2805]fix the ordering mismatch of...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2585


---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    retest this please


---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    retest this please


---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7656/



---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6373/



---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6352/



---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    LGTM


---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    LGTM


---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6398/



---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7633/



---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    retest sdv please



---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7624/



---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    retest this please


---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7667/



---

[GitHub] carbondata issue #2585: [CARBONDATA-2805]fix the ordering mismatch of segmen...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2585
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6067/



---