You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/05 19:34:41 UTC
[GitHub] [superset] codecov[bot] commented on pull request #13468: feat: add event_logger to test_connection and create_database commands
codecov[bot] commented on pull request #13468:
URL: https://github.com/apache/superset/pull/13468#issuecomment-791635168
# [Codecov](https://codecov.io/gh/apache/superset/pull/13468?src=pr&el=h1) Report
> Merging [#13468](https://codecov.io/gh/apache/superset/pull/13468?src=pr&el=desc) (ea81349) into [master](https://codecov.io/gh/apache/superset/commit/d2e03ab9b4f6e941040cf60153599b1a64e28ce6?el=desc) (d2e03ab) will **increase** coverage by `3.04%`.
> The diff coverage is `88.40%`.
[](https://codecov.io/gh/apache/superset/pull/13468?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13468 +/- ##
==========================================
+ Coverage 77.44% 80.49% +3.04%
==========================================
Files 906 301 -605
Lines 45715 24484 -21231
Branches 5524 0 -5524
==========================================
- Hits 35405 19708 -15697
+ Misses 10183 4776 -5407
+ Partials 127 0 -127
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.36% <88.40%> (+0.01%)` | :arrow_up: |
| postgres | `80.40% <88.40%> (+0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.49% <88.40%> (-0.41%)` | :arrow_down: |
| sqlite | `80.01% <76.81%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13468?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.30% <ø> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.93% <ø> (ø)` | |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `85.18% <70.00%> (-3.95%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `92.15% <75.00%> (+0.32%)` | :arrow_up: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `87.55% <100.00%> (+0.15%)` | :arrow_up: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `92.85% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.44% <100.00%> (+0.11%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <100.00%> (-0.49%)` | :arrow_down: |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `93.98% <100.00%> (+1.00%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [611 more](https://codecov.io/gh/apache/superset/pull/13468/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13468?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13468?src=pr&el=footer). Last update [d2e03ab...ea81349](https://codecov.io/gh/apache/superset/pull/13468?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org