[GitHub] spark pull request #17633: [SPARK-20331][SQL] Enhanced Hive partition prunin...

[mallman <gi...@git.apache.org>]

Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17633#discussion_r114878091
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala ---
    @@ -589,18 +590,34 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
             col.getType.startsWith(serdeConstants.CHAR_TYPE_NAME))
           .map(col => col.getName).toSet
     
    -    filters.collect {
    -      case op @ BinaryComparison(a: Attribute, Literal(v, _: IntegralType)) =>
    -        s"${a.name} ${op.symbol} $v"
    -      case op @ BinaryComparison(Literal(v, _: IntegralType), a: Attribute) =>
    -        s"$v ${op.symbol} ${a.name}"
    -      case op @ BinaryComparison(a: Attribute, Literal(v, _: StringType))
    -          if !varcharKeys.contains(a.name) =>
    -        s"""${a.name} ${op.symbol} ${quoteStringLiteral(v.toString)}"""
    -      case op @ BinaryComparison(Literal(v, _: StringType), a: Attribute)
    -          if !varcharKeys.contains(a.name) =>
    -        s"""${quoteStringLiteral(v.toString)} ${op.symbol} ${a.name}"""
    -    }.mkString(" and ")
    +    def isFoldable(expr: Expression): Boolean =
    +      (expr.dataType.isInstanceOf[IntegralType] || expr.dataType.isInstanceOf[StringType]) &&
    +      expr.foldable &&
    +      expr.deterministic
    +
    +    def convertFoldable(expr: Expression): String = expr.dataType match {
    +      case _: IntegralType => expr.eval(null).toString
    +      case _: StringType => quoteStringLiteral(expr.eval(null).toString)
    +    }
    +
    +    def convert(filter: Expression): String =
    +      filter match {
    +        case In(a: Attribute, exprs) if exprs.forall(isFoldable) =>
    +          val or = exprs.map(expr => s"${a.name} = ${convertFoldable(expr)}").reduce(_ + " or " + _)
    --- End diff --
    
    In testing this in a modified form of `HiveClientSuite`, Hive is complaining that it can't parse the predicate. Specifically, the error message in the exception it's throwing is
    
    ```
    Error parsing partition filter : line 1:3 no viable alternative at character '`'
    ```
    
    The filter string it's trying to parse is `` `ds` = 20170101``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org