You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/15 20:01:16 UTC

[GitHub] [tvm] mbs-octoml commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

mbs-octoml commented on a change in pull request #8849:
URL: https://github.com/apache/tvm/pull/8849#discussion_r709531817



##########
File path: src/tir/transforms/lower_tvm_builtin.cc
##########
@@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator {
     op = stmt.as<AllocateNode>();
     // Get constant allocation bound.
     int64_t nbytes = GetVectorBytes(op->dtype);
-    if (device_type_.defined()) {

Review comment:
       Filed https://github.com/apache/tvm/issues/9022.
   Just checking your use case: You want to see the allocas so you can later rewrite them, right? It's a bit confusing because I though if the final c code generator sees these Allocates it rewrites them to use globals which I assumed was what you wanted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org