You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "cmccabe (via GitHub)" <gi...@apache.org> on 2023/04/03 19:58:36 UTC

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1156400641


##########
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java:
##########
@@ -40,11 +48,13 @@ public enum ScramMechanism {
         MECHANISMS_MAP = Collections.unmodifiableMap(map);
     }
 
-    ScramMechanism(String hashAlgorithm, String macAlgorithm, int minIterations) {
+    ScramMechanism(byte type, String hashAlgorithm, String macAlgorithm, int minIterations, int maxIterations) {

Review Comment:
   can you use standard indentation here
   ```
   Foo(
     bar
     baz
     quux
   ) {
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org