You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "VladaZakharova (via GitHub)" <gi...@apache.org> on 2023/04/12 12:47:12 UTC
[GitHub] [airflow] VladaZakharova opened a new pull request, #30598: Update CM360 operators to use API v4
VladaZakharova opened a new pull request, #30598:
URL: https://github.com/apache/airflow/pull/30598
Support latest version of Campaign Manager360 API, because of sunset of version v3.5.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #30598: Update Google Campaign Manager360 operators to use API v4
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #30598:
URL: https://github.com/apache/airflow/pull/30598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #30598: Update CM360 operators to use API v4
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #30598:
URL: https://github.com/apache/airflow/pull/30598#discussion_r1164434190
##########
airflow/providers/google/marketing_platform/operators/campaign_manager.py:
##########
@@ -188,6 +194,11 @@ def __init__(
self.profile_id = profile_id
self.report_id = report_id
self.file_id = file_id
+ if api_version in ["v3.4", "v3.5"]:
+ warnings.warn(
+ f"API {api_version} is deprecated and shortly will be removed. Please, consider using v4",
+ DeprecationWarning,
+ )
Review Comment:
This is redundant 20 April is just around the corner so these versions won't be useable any way.
I assume that if one submit `api_version` to the API then the API itself will reject the request with relevant message? if so no need to add additional logic from Airflow side..
##########
airflow/providers/google/CHANGELOG.rst:
##########
@@ -233,7 +243,6 @@ Bug Fixes
Misc
~~~~
-
Review Comment:
don't remove this line
##########
airflow/providers/google/CHANGELOG.rst:
##########
@@ -23,6 +23,16 @@
Changelog
---------
+9.1.0
Review Comment:
```suggestion
10.0.0
```
breaking changes in provider requires major release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova commented on pull request #30598: Update CM360 operators to use API v4
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #30598:
URL: https://github.com/apache/airflow/pull/30598#issuecomment-1505332154
@potiuk
Hi! :)
Could you please check these changes for Campaign Manager?
P.S. I also can see some errors in CI build, but can't really understand the reason...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova closed pull request #30598: Update CM360 operators to use API v4
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova closed pull request #30598: Update CM360 operators to use API v4
URL: https://github.com/apache/airflow/pull/30598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova commented on a diff in pull request #30598: Update CM360 operators to use API v4
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on code in PR #30598:
URL: https://github.com/apache/airflow/pull/30598#discussion_r1164463613
##########
airflow/providers/google/CHANGELOG.rst:
##########
@@ -23,6 +23,16 @@
Changelog
---------
+9.1.0
Review Comment:
I was not making any changes in the logic, just changed the default version, so picked next minor version from the list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] VladaZakharova commented on a diff in pull request #30598: Update CM360 operators to use API v4
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on code in PR #30598:
URL: https://github.com/apache/airflow/pull/30598#discussion_r1164462542
##########
airflow/providers/google/marketing_platform/operators/campaign_manager.py:
##########
@@ -188,6 +194,11 @@ def __init__(
self.profile_id = profile_id
self.report_id = report_id
self.file_id = file_id
+ if api_version in ["v3.4", "v3.5"]:
+ warnings.warn(
+ f"API {api_version} is deprecated and shortly will be removed. Please, consider using v4",
+ DeprecationWarning,
+ )
Review Comment:
Yes, for now if the user pass version 3.3 (that is currently deprecated), the error will show that there was no such version found for specific service.
Thanks for the idea, i will remove this check :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org