[jira] [Commented] (PARQUET-1385) [C++] bloom_filter-test is very slow under valgrind

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583419#comment-16583419 ] 

ASF GitHub Bot commented on PARQUET-1385:
-----------------------------------------

wesm opened a new pull request #489: PARQUET-1385: Do not run TestBloomFilter.FPPTest when valgrind is in use
URL: https://github.com/apache/parquet-cpp/pull/489
 
 
   This test will still be run in other entries of Travis CI where valgrind is not being used

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [C++] bloom_filter-test is very slow under valgrind
> ---------------------------------------------------
>
>                 Key: PARQUET-1385
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1385
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: cpp-1.5.0
>
>
> This test takes ~5 minutes to run under valgrind in Travis CI
> {code}
> 1: [==========] Running 6 tests from 6 test cases.
> 1: [----------] Global test environment set-up.
> 1: [----------] 1 test from Murmur3Test
> 1: [ RUN      ] Murmur3Test.TestBloomFilter
> 1: [       OK ] Murmur3Test.TestBloomFilter (19 ms)
> 1: [----------] 1 test from Murmur3Test (34 ms total)
> 1: 
> 1: [----------] 1 test from ConstructorTest
> 1: [ RUN      ] ConstructorTest.TestBloomFilter
> 1: [       OK ] ConstructorTest.TestBloomFilter (101 ms)
> 1: [----------] 1 test from ConstructorTest (101 ms total)
> 1: 
> 1: [----------] 1 test from BasicTest
> 1: [ RUN      ] BasicTest.TestBloomFilter
> 1: [       OK ] BasicTest.TestBloomFilter (49 ms)
> 1: [----------] 1 test from BasicTest (49 ms total)
> 1: 
> 1: [----------] 1 test from FPPTest
> 1: [ RUN      ] FPPTest.TestBloomFilter
> 1: [       OK ] FPPTest.TestBloomFilter (308731 ms)
> 1: [----------] 1 test from FPPTest (308741 ms total)
> 1: 
> 1: [----------] 1 test from CompatibilityTest
> 1: [ RUN      ] CompatibilityTest.TestBloomFilter
> 1: [       OK ] CompatibilityTest.TestBloomFilter (62 ms)
> 1: [----------] 1 test from CompatibilityTest (62 ms total)
> 1: 
> 1: [----------] 1 test from OptimalValueTest
> 1: [ RUN      ] OptimalValueTest.TestBloomFilter
> 1: [       OK ] OptimalValueTest.TestBloomFilter (27 ms)
> 1: [----------] 1 test from OptimalValueTest (27 ms total)
> 1: 
> 1: [----------] Global test environment tear-down
> 1: [==========] 6 tests from 6 test cases ran. (309081 ms total)
> 1: [  PASSED  ] 6 tests.
> {code}
> Either we should change the FPPTest parameters to be faster, or we should not run that test when using valrind



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)